From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9A65C4345F for ; Mon, 29 Apr 2024 19:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E4666B0099; Mon, 29 Apr 2024 15:14:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 491DB6B00A6; Mon, 29 Apr 2024 15:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35AC66B00A7; Mon, 29 Apr 2024 15:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 16EB06B00A6 for ; Mon, 29 Apr 2024 15:14:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B9E5DC0169 for ; Mon, 29 Apr 2024 19:14:17 +0000 (UTC) X-FDA: 82063520154.07.25CB661 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 304A140009 for ; Mon, 29 Apr 2024 19:14:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Z6le/KRO"; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714418055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8mi5fuQMjyC+zCauZm3C5RMQMUvqEO4+XbkT4fjPOk=; b=YgsNrwP6N6h/4WI4EcwXwVmWpGOjNgEFoXxPnTl6JIdUpr2yICh6mFQcJTI04vPNHHAJ9w iPgIdFswDvi74U+Dq4whwIU7Eh2BUtJq4FYurM8fDglmEDnDotg7GNaRCcB0/XjhKkJkIG 3maYl6fWTJ3+KqDJYsOB6KeLEOPjsFw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Z6le/KRO"; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714418055; a=rsa-sha256; cv=none; b=JeVPa6gvLNY2HfR0Iab7slCQX24SOYdPbQ955Un2I5LBWRIpURZUTBqY6aqgiJVCplCFTJ 8ErtOrONbMsx5mAvmgNhaxiscllyCDLeINw9OZ7YJ989R/6+7bMX3b6NaEi4bM0DzAwXxk Iq+0yC+AWpgauklqz06XSCA/VRdlLlo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=T8mi5fuQMjyC+zCauZm3C5RMQMUvqEO4+XbkT4fjPOk=; b=Z6le/KROYcC+NFOlYV92v27bVl D7LvXRrBcHno7hue80XlJt4wr3n1KKwZKSza2q//ky7/hy/weTSkhBfFOqb/3rHpoZ5CNozamhiAD gsILdQ1+0QDHy9ylsXFFBScu0S5yiehlE1eKkqNkqCYa9211wEUgG4z2HT+Xp+d2dCbpnIrToTRMs w/qlTEBN3nUZf7lMgiU4vxCRlKAciMqJRrM2lfFjOlCyG9EBxoDvWtcl467Jf5Xq4fVXCL+hfkzSz NctnbUk1cVBDLbyvA/k1qDgOhXkLr8+mFPEiqcPl6FWjUKrddNmyLciXh4KSIXOG7acTHLJfYTSkB f9TvWQWA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1WRs-0000000D975-0t3R; Mon, 29 Apr 2024 19:14:00 +0000 Date: Mon, 29 Apr 2024 20:14:00 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: Re: [PATCH v3 02/12] nilfs2: drop usage of page_index Message-ID: References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429190500.30979-3-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429190500.30979-3-ryncsn@gmail.com> X-Stat-Signature: m8tt4qyhzo3gyx59x16qoaskzi4gt4zz X-Rspamd-Queue-Id: 304A140009 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714418054-478521 X-HE-Meta: U2FsdGVkX1/L0nkIsw92ezVPdVJYJlURI+eWomRdYycRWcJi5MBV0b+oeg5Nm2eYdYwo9rUancIrp9q4Y84GNd8BqYyVlgF3p6ehIymtjKpKxYlVRNONaKJxM5yjnFhAmyRI5EiUh15ylNtqYu1OoY9Q42IoZUdR5UTwEE/moyWp+TmDzM2Uh+CxxWJBtC8UcjAoIRLg2pKGQs19iwmS7YVmZ6+L9THTjO0mnDjzUhrUVLFPApjTyMIzhOgSu3M8CbLTekDldh5GwTCDUxHQnPmz+Vg0oR1/U8EFjs8Hre7t3rwxh6nl2R06dCPnVMXw3SS3/0bSmJ5AuQl4Y8iWUoAb5kNTYIAX0MfRauQZBvFTKCOWyAVkaikWjXPHRHRW0h3dWHC6r+GIRTG7bSPtP591lOkrle0c1MJA5iT2knghJW0nVFEvkBVHlDCfmaWrwKQJ038rwjlw+LN7PmQvzx8Eb/vTvciwCLB2MMXKq+wxRGcdtoum6RtipCXbhEl2gkYtQ0tELacRGpIl048shT/o/OoVCv4qw+eughe8s6Df6mr9ds6dScmKEByPiL4W6PberXGKfVpQQsFP7USTZBTLIOQCy0tyYRJf53R3z87CblZsdpwO1BG4CQGoS9XQZcFnP8JbRejLIm5Wxi1/RrDCh+0V7TA6WD5qwxpGXnB/FffR2iF7LR9DhdYCm1Egjt+dEmOmYjKepPnPi8kIj9tQPQWH+zHva2kWPAMGOJTCKfWM1/klY0frsnxihamZrxCUZx118djFbXASlsN22+kUgt/3yVGKkwgXRKQNfCjTLbH5lqvN1ESUB97nL0SkgRKlRCesYPQ3bwuMdDoNeU3k2TYp0jAQ7a2IvBXrdXuBpBhzzvHbswSDlwp6/Vx+o7+D6X4gpvBg0t54OQJFtFHAT/b7S8+FR8ba3TPM5UCPeyuv6/iDlKmaxymSpKi8GMv+LM8VS6spuRxyDFp +m7tClKB FMpYuqtetw/RYAyFVJWxFBLVnootPvVBvhB3qUygzwQYmoowfSACEN3AeIT0qR/vEgYaxL9y3PZQQgR1xhY6YfjqNMl7rV52fOpGoVFh6F/Wqk2lnmR5O7gk0nn7KuVE17oqHgCeuQIZZamD3NstaJizMDtgGBpbtCpGE5Y5SB5EtFv2fOZ0UE2cBiOAsNt+qkNvUWl+MSVVRF4autI1H3vpNpul4Cc0UQMr9Jpi1WLYJAxOXRFbcsQF6MiwbH5Oq7zxf+3TWg8H7uZtAGs3f8ucuAkT/PbdGznbi3L/xAvO7YDdvLCwpAD2Ulj/+3FCn98VMhvf3iwe5+XJrMV4Qaqq4Y3D5C33H/4VKvZRwuPeFZav7VYaVpx8d7cBBHO7B4ChmPsxx5wCUCnc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 03:04:50AM +0800, Kairui Song wrote: > From: Kairui Song > > page_index is only for mixed usage of page cache and swap cache, for > pure page cache usage, the caller can just use page->index instead. > > It can't be a swap cache page here (being part of buffer head), > so just drop it, also convert it to use folio. > > Signed-off-by: Kairui Song > Cc: Ryusuke Konishi > Cc: linux-nilfs@vger.kernel.org > --- > fs/nilfs2/bmap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c > index 383f0afa2cea..f4e5df0cd720 100644 > --- a/fs/nilfs2/bmap.c > +++ b/fs/nilfs2/bmap.c > @@ -453,9 +453,8 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap, > struct buffer_head *pbh; > __u64 key; > > - key = page_index(bh->b_page) << (PAGE_SHIFT - > - bmap->b_inode->i_blkbits); > - for (pbh = page_buffers(bh->b_page); pbh != bh; pbh = pbh->b_this_page) > + key = bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_blkbits); > + for (pbh = folio_buffers(bh->b_folio); pbh != bh; pbh = pbh->b_this_page) > key++; > > return key; Why isn't this entire function simply: return bh->b_blocknr;