From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599BCC4345F for ; Mon, 29 Apr 2024 19:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5C146B00A3; Mon, 29 Apr 2024 15:21:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0C396B00A5; Mon, 29 Apr 2024 15:21:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFAC76B00A6; Mon, 29 Apr 2024 15:21:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B7CBD6B00A3 for ; Mon, 29 Apr 2024 15:21:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6E658A0FD3 for ; Mon, 29 Apr 2024 19:21:31 +0000 (UTC) X-FDA: 82063538382.04.400E7A5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id DBDF38001F for ; Mon, 29 Apr 2024 19:21:29 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Jc0JoP+e; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714418490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=neJzdRz9MNUmJ0r+KdRG51iWaNXVEV9Q2WvkNbVMuAo=; b=ub+V9nds1E5S3JUwGBPt1bcLB8Pr6gYrmOmpwugxMkl1gDu2s2jST04P0swO7l7cEwIXbT TWCWqFtGv+vxSeSZbNN4EmD9db49Sb5N3ugh4xZTtWTfsIJQV+xBNYYeq0EAfMW7c2QS+X ZovkSQGvJhehGakjACOZs4t4Fdn23Gk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Jc0JoP+e; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714418490; a=rsa-sha256; cv=none; b=nCyQPzDp55u5FNLSToB0MvFQqFaBOvquJOEVNOfCl6omCbKd28fwIejvUprjryqiLsaT1X Hi+oxMQJw9rrJpXrHU93uPM7wmN1Hogl+dK5daGEUvP1T4eldODfHtvjhWsUse52A0mKOp eWs8bgmTgrPhFRjc2eAszuacuq5SY9c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=neJzdRz9MNUmJ0r+KdRG51iWaNXVEV9Q2WvkNbVMuAo=; b=Jc0JoP+eKlc+BEPzMeneXAxsma j/OYXl9xWbSVrgWEs60bJmZmC5ymQ6SxfijEAStU0JqYGSMrjhQl6oNoCCKdGKJWUrSWku+ucHqTd PX1zm4qHityOpwJAN4lQlbZteHHAf1yVdNPaFECdf0EE0gXFMv7iJgeYnyrdgXnQBOwxRVi4j4q1K +NWVRPqo4iabfKD59KHwsIpvkgf1QQuiO/oAQl1F9jEZlKEvQhCb+NCFSPzmwkpI9i7cev5c5lHkB 6zsNABrfOfPUa8ebmNG6SglJtXXI0vKLoXXI5iLW3FpLMd/2fpU/w572XWrQS4/s+eomGeYpFOSvw sqIfsjmw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1WYv-0000000D9vn-12aN; Mon, 29 Apr 2024 19:21:17 +0000 Date: Mon, 29 Apr 2024 20:21:17 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 08/12] nfs: drop usage of folio_file_pos Message-ID: References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429191138.34123-1-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429191138.34123-1-ryncsn@gmail.com> X-Stat-Signature: 86z4i6wxwmwmpwgp8za43i5jcfdwxtos X-Rspamd-Queue-Id: DBDF38001F X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714418489-35269 X-HE-Meta: U2FsdGVkX19kWokBS+GWIfL5YZOcdm4y5r9BdBDpFJqCWhmtg8Fq/hQ+GrGPzskatO3k7NKu0ut99pzCfz+zGvxr/4c4XpFUlvIxjj8BESO1sNkzvnpdEOlsZ5finbEP21TpMyNJ7K81gHM6tVjm6zsPrJ3yvLK8aQBMtELSRVlqSs9ORU4W6EoL4A81jgg6mH6LFrEzNx+KsOx4p7fGCj5epsTTm0TV1FGyhfbfhmvvX1Qjei3pighrKVkYsIiWOYA/3Vqu6zY2tSKtPtSxZ7EOQbJ+qvmziy0jfXg02xv1shdOBXROqvrHHcM6R4ADO1Xyp/NRNOEq9JGP+fezPAPuoeeza0/2wv4bEQin79SiEOy6oBOnPDie3IxS8qubRN5h23dNdb1ECb9RWtUc6t3mBQ0/BVg2eBl6bGXN0CPRoVJtC51mZgjBEaOyT75pBcsz62x7sRvTddm5akScrtn2b5C6IK+ML6IHlYbwTPFYz+egdxZ2dWWqNClPE6Vyl8P1z9kbMLgBaCX47WLbH//jeU70UHPwIn0rVpV1uEtKrrmn9zjSjJD4hdZ9Ky360stLUm84z4fqECGUABU3vng1Ih/4JklLa+2xrHeKdJacoHzueS/EmkQx54tyD2zx6BI/pPACD+1vNMDhCTEqQlCwNtE7vIsi8nY/Vf7UtEUBezE+gM+zNh97W5TRcV7NsAeOr50dC1qXzwh54QnOyknwAqwPTjknXErKwb7oiEDroGiDw117ivk2f7/WVxROVwpDLWyxv31SdFNohXH6Sw4FGNRafV155tUVg38sqEIvVr8js3aIveNW3V4PnhrqliYwzgPqMqzwqbUIb8eUezhgx8Yhl05ZM63DdIK0lQCQDiCPmkuCJ3YG1dpp0tfYuXw5k7CbhJ5JMh2QkojmxgFJcqDUVxLMewEEOo9TAuhf4lV6M3BSJSXMT64vooXVSLW1Nn1VO4LAXTXfksS 1cH38VAS 0NmRH/kzgjpL5YWzTttdXyY/dSf6Ow5B1CxaK8Ym8uFAYmQi8z8Jue/AjrXX18D8QzNzV0BD/AtKgvwbFCrlxGqBFiZW3poTLSwJ6K8pf9mgNnKOVFxe48NbEFqNSikw1h2iG0pNdNMSMQdvdwBL/xTnF5+EBPToI+ALVWB0I/YhPvDieY3yrCUbkKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 03:11:34AM +0800, Kairui Song wrote: > +++ b/fs/nfs/file.c > @@ -588,7 +588,7 @@ static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf) > > dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n", > filp, filp->f_mapping->host->i_ino, > - (long long)folio_file_pos(folio)); > + (long long)folio_pos(folio)); Yes, we can't call page_mkwrite() on a swapcache page. > +++ b/fs/nfs/nfstrace.h > @@ -960,7 +960,7 @@ DECLARE_EVENT_CLASS(nfs_folio_event, > __entry->fileid = nfsi->fileid; > __entry->fhandle = nfs_fhandle_hash(&nfsi->fh); > __entry->version = inode_peek_iversion_raw(inode); > - __entry->offset = folio_file_pos(folio); > + __entry->offset = folio_pos(folio); > __entry->count = nfs_folio_length(folio); > ), > > @@ -1008,7 +1008,7 @@ DECLARE_EVENT_CLASS(nfs_folio_event_done, > __entry->fileid = nfsi->fileid; > __entry->fhandle = nfs_fhandle_hash(&nfsi->fh); > __entry->version = inode_peek_iversion_raw(inode); > - __entry->offset = folio_file_pos(folio); > + __entry->offset = folio_pos(folio); These two I don't know about. > +++ b/fs/nfs/write.c > @@ -281,7 +281,7 @@ static void nfs_grow_file(struct folio *folio, unsigned int offset, > end_index = ((i_size - 1) >> folio_shift(folio)) << folio_order(folio); > if (i_size > 0 && folio_index(folio) < end_index) > goto out; > - end = folio_file_pos(folio) + (loff_t)offset + (loff_t)count; > + end = folio_pos(folio) + (loff_t)offset + (loff_t)count; This one concerns me. Are we sure we can't call nfs_grow_file() for a swapfile? > @@ -2073,7 +2073,7 @@ int nfs_wb_folio_cancel(struct inode *inode, struct folio *folio) > */ > int nfs_wb_folio(struct inode *inode, struct folio *folio) > { > - loff_t range_start = folio_file_pos(folio); > + loff_t range_start = folio_pos(folio); > loff_t range_end = range_start + (loff_t)folio_size(folio) - 1; Likewise here. Are we absolutely certain that swap I/O can't call this function?