From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B336CC4345F for ; Tue, 23 Apr 2024 18:27:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2771C6B0164; Tue, 23 Apr 2024 14:27:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 228496B0165; Tue, 23 Apr 2024 14:27:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EFB06B0166; Tue, 23 Apr 2024 14:27:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DD4346B0164 for ; Tue, 23 Apr 2024 14:27:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 73C34140DA8 for ; Tue, 23 Apr 2024 18:27:16 +0000 (UTC) X-FDA: 82041628872.29.08606CF Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf12.hostedemail.com (Postfix) with ESMTP id 1F6AD4001B for ; Tue, 23 Apr 2024 18:27:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AlPEiHoB; spf=none (imf12.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.18) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713896833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=csBt27HW6WFYdWXVqw2voeFu9693veSxR3QXkWhU4qc=; b=hGmopQNggpR72WzOazm6fV7YTj3+7H1D3t3PEfx3r0iRuDkCFuW5LB1cj34daVCfzPw86q +cgjovSc03k/0+0vgngTAl4Etmk6GJEP3FiqYyfw/O4GT5NIf9Jwpael73goCJTl5w+KDL +1xr6kFNeQhPpZKP06d6q8Si70Wtmls= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713896833; a=rsa-sha256; cv=none; b=OW4OqyuZYNhSCw18UiWgH0QTz1sE16GSl4soVTZKzguPCHOaPvLyQe5APeXINYimyGLJGl fFIhwOIR4wOXwjkPIiwVpmBMe5SaKSZU1r7IrXVQ9NHjoSbYLCf4/GoI/KYdwZOVsDAIz3 etSDeB88FiDQXNmgJ+sNqdMDRCtOSYY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AlPEiHoB; spf=none (imf12.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.18) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713896833; x=1745432833; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Lk7VycwmGvCZjbAAwt/L6renm7YzvX/n9HKi03awkdo=; b=AlPEiHoBESAGx9bwYG3yQ4p5nKi/w62Zr4emHw8jYiSlh54CfYC3WcQt AjFf0NWPbP7pkf/IwDxc049z3U2mG+7evpgOc6hSh7mVr1FrBizs3fM1t r8f2EaqAUkg1xy53nBmewUZXBDrZGOjxMVEtS1bSs4PrzzufosgEZrz8q zKr/l/xpB4JZFXbMAjdPb7o6N3yIEtMjoSvgFMtnib0mM71lw0WS+MYzO tTZfA7wvp2PixhtUQUQiq0rBnm9kQXC5540nyzx2igAdf7SrzaxzyVjVK jk9I2yd8SfWJEw4+4Ildo3UWAVegtXhUuLDTHh2iJNW5X3TnNOOz5YHl+ A==; X-CSE-ConnectionGUID: DbwPDSPpTH256mqOBsAAKA== X-CSE-MsgGUID: IMBi7j0pQ5e1SSMD3+FxgA== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9350887" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9350887" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 11:27:11 -0700 X-CSE-ConnectionGUID: C3h4PbPBT92bOWbiY3yfFA== X-CSE-MsgGUID: YT3HDgReQn+PXP80GhgySw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="29255465" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 11:27:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzKrD-00000000QuI-39qS; Tue, 23 Apr 2024 21:27:07 +0300 Date: Tue, 23 Apr 2024 21:27:07 +0300 From: Andy Shevchenko To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rasmus Villemoes , Johannes Weiner Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function Message-ID: References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> <20240423111000.aaf74252a07d7e7fd56d7e12@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423111000.aaf74252a07d7e7fd56d7e12@linux-foundation.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1F6AD4001B X-Stat-Signature: 68yyg763bx5zhmufg5wozf9773r6ie15 X-Rspam-User: X-HE-Tag: 1713896832-890436 X-HE-Meta: U2FsdGVkX195dQprjYQPAJv80CdlqpI4VKoP9fAfuMEFpRZehNhl4U9npVpBY2GK2HWybqgf3xZaqik695PDa/XgctLXkT7GjhKPzzw9+cB8oKdWe+7Y8Buv6DXc/AJHMgv0yVxI4rWMy4hQt1ppDp2ClbJYfjgJTMALIBkGxxlKgAlEE+RgushugY+ebJuP3il6MiILCIgf9ziigwJn4rZmiggYOTGWjRAZGTmzkMBxjjrPwk58XPx3hd2QTb0cun4TwkEy8Y0+OFo+wv8Le9Xi2Q/WB+hjzwbuPjlH5DIF4W5jiHw5QDvm3U63vdATE00I6ouaG40sGqnGIVpludPa7XA9YkyopKVIXhrMetYRKOKpRzUv+fctTE9SrOPj2C3AGuxgKfK2R/jGmsoOhapMBqH/6cvqGEIVUT50gHBF62YZRL9SaYpBEQydKIjXDyHin9fBre4Z7dR3iZqsys5U23hooI154cJ5FgkDXPRM5ORjHO06qEQZY6no+GGCJLWSF2EdRxJe2+pam3+3T79dXo6GPqacHjXD8OgOC29LcA7+Z5HvHZ7oidJqSjK9pNAJeDhV48hLEx0ciXL0H9chfFLW+jPdfQDP4mnaC9Zxf7luzRCQe0BMBrOfd/GZdKyvZCreNEAcaIId/FUEkKn/OuB63Wd9aMhWf6hK7bQgYdQe1HtatnWKrV7A86TDkcv+/oEPNkVebBtQfFl8k1LXLowlw5akhrOoaKS++/PIYDciN0O7DVEs0ehOp8APdnHV5VitSyJJkbmo0zM8iOwPYMB+gpDVByXreBL18X4DA1nbCCpJh5JNAAtLtlggodPpP4EMAK/p0Dm7Gor0TgQYFwCFVUhn38roPNaCZj+jUJDWSjVlwAk8v9ZwKpzDSsgwwt5TCfjMAmn/eHc9l1XDe7NJ+mV7Jg6ZLEICvijtFOPufomROumQXPzsp4+DPtpine3HUpRXVnQDIuv shmj+Sqr Tp4Z9cRcywzUSMW9xu8/mnYgCeBIp7Hk1JaKe/1wdfel4DPr4Y7WyaRaCGJJ6rUTZIaGC4trZUPe7NeBnSTaywjswo9h/h9XtWo1mV74zOcXh7tcShUtH882QxyU3TEvFFT0G/0YC41Eexjkh2KwxtBNmZ6dOq7cP+vNKNwI9dfmkvK5HSuhMGWGWzTfmOgwaF/d1u6flnI2yH0Rg39/kIZ/1g1FIwjjVg5rJ3FYkMPOAVJs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 11:10:00AM -0700, Andrew Morton wrote: > On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko wrote: > > In some configurations I got > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > > Becuase the only user is guarged with a certain ifdeffery, > > do the same for add_to_free_list(). ... > Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate > free page accounting". Thank you! > Please do tell us the config when fixing these things. That way I can > do a little bisect to ensure that I correctly identified the offending > patch. Hmm... You mean defconfig? I can share it. I built this with `make W=1`, probably that one helps, but the MM parts of the defconfig have not been altered by me from the x86_64_defconfig. -- With Best Regards, Andy Shevchenko