From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C244AC04FFE for ; Tue, 23 Apr 2024 22:59:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5377A6B0198; Tue, 23 Apr 2024 18:59:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E73C6B0199; Tue, 23 Apr 2024 18:59:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 388276B019A; Tue, 23 Apr 2024 18:59:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1B3826B0198 for ; Tue, 23 Apr 2024 18:59:01 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D899A1C125A for ; Tue, 23 Apr 2024 22:59:00 +0000 (UTC) X-FDA: 82042313640.17.5680EAA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 40FE2C000A for ; Tue, 23 Apr 2024 22:58:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NfHZ0wWx; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713913139; a=rsa-sha256; cv=none; b=W0hP/f4B3tgQMqbyHCC5ypzydAR+8SRLoxQv7RgGzCxm3Ynn2cSR1uDO5LD/JU0x6IKcsJ Krnf2p//mVdmVhnXOZ5bOZAjH+ne6ngkAkyh9FB09gTXnwT7fAeSpiW82L2SF+nx0DOkkE v//CCQeUdBauxml0uP3KaGNgix6QigY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NfHZ0wWx; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713913139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vs2mxITFBV+nRdHIV1uS98AGVTfpM4tELm97x05ajm0=; b=BEJJqnmDQzgutGvVTqOmz6t0ob2vtUgZVOTSjDkznj6eNBQe5Nmpgroh4fJgfLK0pElf46 f73k87ltJGmwAL+dbsYBZHyz9OwuqbRHKHJAEm38bLX8TGWJwWKA36jvgn1Gjtnk7ag/7T RWqg8FGLtfbD/G+YYG6qkS/B5RirFj0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vs2mxITFBV+nRdHIV1uS98AGVTfpM4tELm97x05ajm0=; b=NfHZ0wWx8GsndEQHkBQc5Ztki1 +thI/9cbCmFDfsBKQdJhpY9sdYrV/3LG4b9EaxZ0lQ9V30/cPkhT3QlooLztHyMRN0CXpRp3xNP46 x4cp4efIgNLFzO5QRLE3Q5J1Axh70ssti9HIPvCLDgDRJ6ZlOZMOIeD7MQdzG43fH26hzdZ6DeMnX iYYsZmvc+gaKlIlop7wT1ysPbtC6FwsO+/CDxp8D60K0LK8ef7xSNgaJzqYS8rfLG8Gwak/hUZuRt YFxaII764S2palC6DlSP+PhM5yULs8nvv0FSPVcWpRz6TmGmlLPH7/umzcJ+2ccIKSYRnRP2pgL4x qDIkZ1SQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzP64-0000000HGFU-0pot; Tue, 23 Apr 2024 22:58:44 +0000 Date: Tue, 23 Apr 2024 23:58:44 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Yu , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 3/8] f2fs: drop usage of page_index Message-ID: References: <20240423170339.54131-1-ryncsn@gmail.com> <20240423170339.54131-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423170339.54131-4-ryncsn@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 40FE2C000A X-Stat-Signature: twwye6yqx3yd5rk31a69wtdrudsbsw4i X-Rspam-User: X-HE-Tag: 1713913138-368432 X-HE-Meta: U2FsdGVkX1+ovuX4vJcE+FrWhHNvE9qx/nKvnwilhZuLhJcOCpkBfORZXSnOiG2FkbZqhL/JY75dfDDUTR6KxYi97bYAYkDTxOqS1t4O/Sm2TFd0Nwq8OM5RABJ9D9MkIH9vjjBBD5R1jrYMyweDGedTZWV0vkY1+wx9KaZevTI8d7kxozWtbUy+k8pfnJzbZVUA8jVuDhGER8euC7ZQSNL3J214ywS55iIBMdQU/yLG3drUgtLlqGRdK2adhtjbh85EejJhMzVWnAL+YWiIKcKbGxmsTOvH2tpjLahdlIOT0E+JUWzNcWi/k6sH3yat792TYiSnyfG1Qe5B/hGU+HGSgBzVgyBoOJjzsGOx6eFq7GctsbwTXYRPNik+xnc9BIrOEqpL37K4vo1CweQJC6qUUgOT1VZAq518FNW7CQArb2hmlgOVJJbDRuvSdEYqDtuNdQ/xG8IIALTBQnUrACPv9VUOph49nHEiLKg+c4f1rLuISjFXyWa7dkpyKOqGWTCxMZo4pBu/IGRtevr8E//NzkNJCWFhLnIrTeHjb3P9ue95RuITEbZNiUlbkfzwfhzR6OzHcm71JzVb11fxBDvFRTJEkKMNEDuG5rayZZe6HIV6ct3SNJ5ipeh9vNBk43HLaM3cL4Maq+nSwjQkoVYMas4ltYcKNz2j1J2xhtDqjWgTAvpbev9Q0u0mf/2WRCHUeSww5URY3lqJiSB+P8vXjWqbIaYUXj8Bw6To1IRWsQjBF73XO7GL2/9vauZvCHcPFAUiz2vB0+ZM3iI9yANUcOIGU1JslcPVKM8REPpElAHLNBu+UJhUoFiaVFXqN+c7pD3TJQK60I6ZWrWKKmx8RmhdSUFBl66yPrgw5EtVQCWf8Q3/Q0nLtIMxQysRQoCWFJoJElP5SMhCOeWusMzlRwulhkaVRdZFNnr5tGDAE7lg+c9iCH8ICtjD+x+rfydTvMpfbFxlKQ+gvA7 6Vmub/LT SA0KalN7izDnlDuVp89Dk5tzi/0Zt80J8zwCudJftV6xacuFNh7D+IHNDOsHt6A4E6ox+0yYSWYEAqq5VhDH/GR65DgyO+kN+EEzJ7DrZkNLwwku+kgpPDJ6Wig9Knar2dkq5Q1QIfNwgBgwX7Oc8isIjkYq1ecu/pJzDuyM0a4F0y+Tq55Y0T2qvNIdXtWIYPzJH82iAi90acdNw/r4Z1SuW9+dq4RWYBCyvqRJC5/M1T30mVl64UXL0LdLzMUh8LK5JapAEVLij+DikkZ9FrlsbrUtY3Blis2v048Z+a/oExmE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 01:03:34AM +0800, Kairui Song wrote: > @@ -4086,8 +4086,7 @@ void f2fs_clear_page_cache_dirty_tag(struct page *page) > unsigned long flags; > > xa_lock_irqsave(&mapping->i_pages, flags); > - __xa_clear_mark(&mapping->i_pages, page_index(page), > - PAGECACHE_TAG_DIRTY); > + __xa_clear_mark(&mapping->i_pages, page->index, PAGECACHE_TAG_DIRTY); > xa_unlock_irqrestore(&mapping->i_pages, flags); > } I just sent a patch which is going to conflict with this: https://lore.kernel.org/linux-mm/20240423225552.4113447-3-willy@infradead.org/ Chao Yu, Jaegeuk Kim; what are your plans for converting f2fs to use folios? This is getting quite urgent.