From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A790C4345F for ; Wed, 24 Apr 2024 23:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A45C26B0085; Wed, 24 Apr 2024 19:19:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F58D6B0087; Wed, 24 Apr 2024 19:19:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896836B0088; Wed, 24 Apr 2024 19:19:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C7976B0085 for ; Wed, 24 Apr 2024 19:19:20 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 10B82A1E9A for ; Wed, 24 Apr 2024 23:19:20 +0000 (UTC) X-FDA: 82045993680.29.66AEEEC Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf08.hostedemail.com (Postfix) with ESMTP id 310D716000F for ; Wed, 24 Apr 2024 23:19:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EuEaeYGU; spf=pass (imf08.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714000758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sakwDrIIsmCz4hVkB1z5sN2fWtElfeE23GuvVoi+CRM=; b=5gbDa7BJNhIbFOsD1h4Mn5S76ftCboQO6G01Sei8Uhk1DVfNxV1Q8gE8coLj2yc65S/9Ul S1Tc51RkBHrPBe/Nm2ZUN5PIr2C9I/Z6jQ3v4YaLAjGVhOHFv5X++477pTbzc7DUuH6tf3 66FvUpIA/zV6wQWOrYyde8wxl1QUDqI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714000758; a=rsa-sha256; cv=none; b=7K+fIaY9WijRYJfYT4yv5p40r3Rbq8/CXfxGm/AkZyQ1vkrz8qVN7mYLBkQq972sv+BHw2 m/tf3W3eA2iiKm9wIiPMAUFGMHTtcrvswk76lQkVgouqlf7WC5l5ZRw/S67Sivx1ZsZkxu qGbLcjvdoaIV6aLssR2FgpSAkS3IvxY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EuEaeYGU; spf=pass (imf08.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6eff2be3b33so465260b3a.2 for ; Wed, 24 Apr 2024 16:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714000757; x=1714605557; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=sakwDrIIsmCz4hVkB1z5sN2fWtElfeE23GuvVoi+CRM=; b=EuEaeYGU9DVjejivjvLpn3AVVrLxYavJCgIYm4QAIYrQ9gZNOx+kbk+GG0bCQ2S6gF TnLzjNqYwsxdOhJnJycARXF1lBs0aaSBF14jS2/wHQj8P9MkFwtMLL8cZShLqjHn79MP vLnR8njW9xvYLeKjotNFo4r2tm9zKd8rzebvWaKs3AQHVBWgchAOfo9SkQqK8QImV4V5 oD0eXuGYcAl8uh3uDfPIYvayWWZJV38Vh8xMOd/Ku2ctkJ/hWkfYXk7xSNyOntKfNfF2 TMqW2wOzfA8WX3QGdVFA6HuzAHhgs5vVQxTl6JsXsYSEP3eEuLRI8gGAHUIh9Zr1XBjD rMWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714000757; x=1714605557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sakwDrIIsmCz4hVkB1z5sN2fWtElfeE23GuvVoi+CRM=; b=YyHH1Dx5zTGf4PDi2SaUB3JHrLRmN6tgz51NMFQE9gV2xNwh4jC8B17gbqdUFwrb9F yhSh/kdpWqJ8ACLu6BIa+tgkb1dVaKs9otL7ztMpsQanubSfaeD6JFWSFL5hvlAUw/8E zzNyguqyJMrmiPx+PSydfQJBcFJMiHZ0wDeAfnAHAYlGuNQC07xf8XN4MTSoi/0jhJ5K 6oPsYbNVuPLsMtgSKjNldVgbkVl2NeEsU1C/gis3q/gs9m43iX/aiBtG88OUSPlVf3dX m9E9i+X9Gc0lKi2RAxAy6ibA7no0DCO6etvU9vTO40woPIoLzQRJWMTkvuRfPSdi8c8O 06BQ== X-Forwarded-Encrypted: i=1; AJvYcCXGTjW8beDKGl5EHtnf2kAT194Gz6ibF5Q6eqFfotv9EbmrHoQOsZwFDrr6I0dxTJzlIJIMec2HHOXk9VZ/pNt+hF8= X-Gm-Message-State: AOJu0YxLjXlIeJaOWEjWn3NbemFnMr4StgK7+3WGx2apQExFK7boRLB8 RLtPfsVrTJw365kNQCTYvQfvVkwhjcEi+TH5zD7gSd52RCNuXDvb X-Google-Smtp-Source: AGHT+IEuvZAJziMcw4WYyCy553sul9ZkpvveDxJ7UhszeD5DLuljCvM3wLrc+K7mU7JskjhiQsWU8A== X-Received: by 2002:a05:6a21:2709:b0:1ac:48a9:8a42 with SMTP id rm9-20020a056a21270900b001ac48a98a42mr4263409pzb.14.1714000756872; Wed, 24 Apr 2024 16:19:16 -0700 (PDT) Received: from debian ([2601:641:300:14de:56e5:6d59:647c:63a1]) by smtp.gmail.com with ESMTPSA id m5-20020a170902768500b001e4478e9b21sm12438135pll.244.2024.04.24.16.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 16:19:16 -0700 (PDT) From: fan X-Google-Original-From: fan Date: Wed, 24 Apr 2024 16:19:06 -0700 To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v8 03/10] cxl/mbox: Add GET_FEATURE mailbox command Message-ID: References: <20240419164720.1765-1-shiju.jose@huawei.com> <20240419164720.1765-4-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419164720.1765-4-shiju.jose@huawei.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 310D716000F X-Rspam-User: X-Stat-Signature: kf4x49e5zd9ksopfz7gw9z4ihnz8epj9 X-HE-Tag: 1714000757-872733 X-HE-Meta: U2FsdGVkX19LVNohwRZxyIW8gLkoBIAShPZ7JwFeTVlVeyikAUV1DN3K/YcY+L9LQcJ3ruF/62zaZ0rAzPbnm1W9MAuPTo7QlXpUOBUVrbSafgx87BFFRoNVYfkrXKurn6e/a+jGgmfUjfer0BwTiv3ciTRascUjGGERGTfxUoGYMOsWHatObyfowQTlfcrwl8GS8TVzb0iyQy+kLuRnXphCnYldo5Kcug2Bbaq7uZ6NAtCLsdaUN4Us9JiuwQPkKGWGmvS7lLrrYzy9wQEs7yEzhUHSPA2TFPOIJmqIyDwsOnrqZtVHGqjjQAhV08z+xz4s4wvNx3RoqPdyfUIA4C6qGxpJ6wDFNTWrA7eK6T0+cIJw61gUMQer7Qcgovywh46xLpgArERj8R7h5yzm8tdq90UkNq4Qod1VRdE9so1VAxfBmOxOel9ZitY8EJX5dBFNtYdhlFe8Byj/jlNla6ihn+jY70njJebZwT094UIdhIIaCTkjAXSQnTDGvj0bNCZ/fGmyHXL4/eMPhn1unBoUzHsvm3UhLdRJuyki/HQLlhezo09aRg8Xct+8go41CJNyIxsUwtaGQmHQoIY98UETDdWBvRTksUQvbEmsSq+YuQGSe3PfNTuzppOEtUFnzczfdwYz51Vc53/BYcwqUPiBgV+2Xpfs0X87FnnXO8Bwejs4H4nfPgDbagDaGwOOLU+tcKy8y3k+Q+bcBaDH1bfhem6UFg9eb3RqKWIBM/uNX0V1VmUKFHKULnqDuxhccPx/MVaGAM36qop5/HhPIAUCHiSaUCFKcRja+Q3cyu5ppxQSdMq2WE7FbCF5CMTqFINhqLoEtCqAaFd39EqWEcdMTZFuHpJCDTLtsq7wC/zxYV9O0MQiNtswX5SxU+rhorN/jk4kwWQ6o91W6Tmr5yKXFtU/C3LwwSqPtoepE1V3pY0jDZpHDd1R1SyYYmJzHo3INEDmVoS7ToNqS9d hbYwFlhX 6IoJ5m7xDQE1dp8jbODkl7iBFoRSy0QSjYLVVLY1VpaI6+6r7kyATmwNE4csEQQmr8ODdT8Q3vEzcpfVcmorc874aKiju/0OF2VTbNG6A/sue0utgvXnAE27azDDHlny/d2cutS7nBGfj3G7Be5TeTbznHl2lxi2APtukZ+5naAatcgFWn7bnirfbHcMb8Uq9eS4tkiM1LemeWx/T6tRGPbgvOizwacbBI+xCpzlgHkyFY+YL1QGCJgVwhKR93Xp07nuJZ4gbO1f4m4TUmnl91fOwD1FZZXNCzGxSZEmFysrNCDIwmDAFNwPQ5w7NqppvOLJdIx/MgtQkkfwXkj/7/Rn7fWqMpJh2hdpMAaWDa90dN0/szvFnrAJjaBqMUXfEMOdAY9Xla7uVaIdJugW7UoBCrl9Mu0SoAkAszP6JDisc0/F5aZQ7Q1msCjCE/1sijoGpUbmRx0F6/6GkuAnKS89GPV0eQLRHQnuOzAbsXuHI+ffkl9SAZ/GJhjxP7bTI95MsEQsypKW0kX5LYNYXbKEYdedNPrAmXdWpfm40Bd8t86EjoTLW60/xv+J/0TRFqJEzUbIOlRmCVFE2js6GfVqw9zlNCEmKtEqRSgxBx85XLSYF/dS/969Vbtk0B7ChYjiPPQag0Lk4dtZsu+Sul78WdfpXGiKwRUxRo/Q41bTALn+eraclKvapjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 20, 2024 at 12:47:12AM +0800, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for GET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > The settings of a feature can be retrieved using Get Feature command. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/mbox.c | 53 +++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 28 ++++++++++++++++++++++ > 2 files changed, 81 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 82e279b821e2..999965871048 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1318,6 +1318,59 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, > } > EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); > > +size_t cxl_get_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, void *feat_out, > + size_t feat_out_size, > + size_t feat_out_min_size, > + enum cxl_get_feat_selection selection) > +{ > + struct cxl_dev_state *cxlds = &mds->cxlds; > + struct cxl_mbox_get_feat_in pi; > + struct cxl_mbox_cmd mbox_cmd; > + size_t data_rcvd_size = 0; > + size_t data_to_rd_size, size_out; > + int rc; > + > + if (feat_out_size < feat_out_min_size) { > + dev_err(cxlds->dev, > + "%s: feature out buffer size(%lu) is not big enough\n", > + __func__, feat_out_size); > + return 0; > + } > + > + if (feat_out_size <= mds->payload_size) > + size_out = feat_out_size; > + else > + size_out = mds->payload_size; Using min() instead? size_out = min(feat_out_size, mds->payload_size) > + pi.uuid = feat_uuid; > + pi.selection = selection; > + do { > + if ((feat_out_min_size - data_rcvd_size) <= mds->payload_size) > + data_to_rd_size = feat_out_min_size - data_rcvd_size; > + else > + data_to_rd_size = mds->payload_size; data_to_rd_size = min(feat_out_min_size - data_rcvd_size, mds->payload_size); It seems feat_out_min_size is always the same as feat_out_size in this series, what is it for? For the loop here, my understanding is we need to fill up the out buffer multiple times if the feature cannot be held in a call, so it seems feat_out_min_size should be feat_out_size here. Fan > + > + pi.offset = cpu_to_le16(data_rcvd_size); > + pi.count = cpu_to_le16(data_to_rd_size); > + > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_GET_FEATURE, > + .size_in = sizeof(pi), > + .payload_in = &pi, > + .size_out = size_out, > + .payload_out = feat_out + data_rcvd_size, > + .min_out = data_to_rd_size, > + }; > + rc = cxl_internal_send_cmd(mds, &mbox_cmd); > + if (rc < 0 || mbox_cmd.size_out == 0) > + return 0; > + data_rcvd_size += mbox_cmd.size_out; > + } while (data_rcvd_size < feat_out_min_size); > + > + return data_rcvd_size; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > + > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 06231e63373e..c822eb30e6d1 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -528,6 +528,7 @@ enum cxl_opcode { > CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, > CXL_MBOX_OP_GET_LOG = 0x0401, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > + CXL_MBOX_OP_GET_FEATURE = 0x0501, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -754,6 +755,28 @@ struct cxl_mbox_get_supp_feats_out { > struct cxl_mbox_supp_feat_entry feat_entries[]; > } __packed; > > +/* > + * Get Feature CXL 3.1 Spec 8.2.9.6.2 > + */ > + > +/* > + * Get Feature input payload > + * CXL rev 3.1 section 8.2.9.6.2 Table 8-99 > + */ > +enum cxl_get_feat_selection { > + CXL_GET_FEAT_SEL_CURRENT_VALUE, > + CXL_GET_FEAT_SEL_DEFAULT_VALUE, > + CXL_GET_FEAT_SEL_SAVED_VALUE, > + CXL_GET_FEAT_SEL_MAX > +}; > + > +struct cxl_mbox_get_feat_in { > + uuid_t uuid; > + __le16 offset; > + __le16 count; > + u8 selection; > +} __packed; > + > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; > @@ -888,6 +911,11 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds); > int cxl_get_supported_features(struct cxl_memdev_state *mds, > u32 count, u16 start_index, > struct cxl_mbox_get_supp_feats_out *feats_out); > +size_t cxl_get_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, void *feat_out, > + size_t feat_out_size, > + size_t feat_out_min_size, > + enum cxl_get_feat_selection selection); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); > -- > 2.34.1 >