From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA51C4345F for ; Thu, 25 Apr 2024 20:24:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37A306B0089; Thu, 25 Apr 2024 16:24:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32A0E6B008A; Thu, 25 Apr 2024 16:24:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23FF06B008C; Thu, 25 Apr 2024 16:24:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 066356B0089 for ; Thu, 25 Apr 2024 16:24:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CE613141284 for ; Thu, 25 Apr 2024 20:24:43 +0000 (UTC) X-FDA: 82049182446.04.9DE75EB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 21A67140009 for ; Thu, 25 Apr 2024 20:24:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lPp7XSJg; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714076682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aPI+REeR7ehD8uzT6D6XxnDHOJihS/G4o6C/kIyX9uM=; b=igopYVspl4xbwig6mPcJKuGouhoQeRGspc3IPo6zcC59NpLnJRTsQyurOPaS6ZTuVe9phh aY+yUH+ibKRyMfNTK2CP46KLhLr1vH4NVQdUKstkDF9Po6518rWsDl74umBpJwQXQTNGNq UmHG6i8eDi5wbossFtAGSyJIWql6X4I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lPp7XSJg; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714076682; a=rsa-sha256; cv=none; b=ttvrO5jZDT8e+S2MwqavSw+miUnKa2wbQ2PVu7sDmYR0XgqU4ofNXdI72pG6MBbV5uRXw3 7HIBVgCmUntS96zfEWuV5c6u1LCi6tIOgO84IJ0EnHX05wahBYSoUTJba7oe0U0DLpGc1/ fRmIStutvgmvrOsteCYt3ZIB1ph2NgI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aPI+REeR7ehD8uzT6D6XxnDHOJihS/G4o6C/kIyX9uM=; b=lPp7XSJgb/pOL8V98kRsv6/EMT VnAqT4WFX66hgjwwHp579W67Kn5pgqbXose2hro4ga/tmMpIvCjzPxkkszCs62Rjn5NJZ4q2NtHGg 0fwyAVq3Fx/4Z77NG5R5bl9iphq8ysrV98J5TRiOYw0V0mmdDqwN/FW2vmuagAn45zyNLEgyPxVWo Na6lmOD/qa0TAIMy/XB4XbH1kM8arNUL2Jj8e5p2Oc4rX8Z3W3uLhQtF+UVnvXMIsdvKCQueKTBbS unv3oEdxTgSlktnSzxyRxn58CG9uqb30ArVUZqXybllM6te6cMMlaOvwB8XZj9580fYaE432aQW5v gdRmykOA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s05dx-00000003jQX-2rsR; Thu, 25 Apr 2024 20:24:33 +0000 Date: Thu, 25 Apr 2024 21:24:33 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 06/11] filemap: cap PTE range to be created to i_size in folio_map_range() Message-ID: References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-7-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425113746.335530-7-kernel@pankajraghav.com> X-Stat-Signature: cg8wm6mi3sew8btwk6wotowffaqyacpg X-Rspamd-Queue-Id: 21A67140009 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714076681-359146 X-HE-Meta: U2FsdGVkX1+KgF1l9LLiSewybg+Ts+m7vviKjA9KgezDlvHHrMmEtum22e5MOrRvdhtUNMnvYj5wd9j3IrHZ5YLr1SRMZHZRoRrt4D+tZ1iBzwU/26Fv0l4GS0hp4uwLdQzc8H+QDRvYuGKAYadIMzHB9fQG51G9eGJxh80zA1t03vmgarQEVbhp6Dbi6fzNzRkodD/O0BJKCI/m3ndCeoLwcRlg8xv4ZV5DYi0qvp6hF5l9Ruyj0wd0EvmZVvrNamn4x4A8vCuO7/I9ULCjoCn1tRfQknxUMQDWWwHr+wFDz8oVOIqY3JR0ddWp+Oe154j1H2uJGwRXmJdUCS8la+dCr+CGgZT/aoLJCFiW87m59lY4QkoU+8X7HLvCgTlI7sPw6iwmij9g4o7bx46zJ7ausHFCbaHF7ljHGwA6OQ9IziTJ8GEDCKt7MAmYSQ8uAEjWi1O4lfXGx76fstBjlXy4wPJv0rbWg4h5viD1TLkCzLeT0ReAkP7UPkeEzaGp1OPTsCxqpZeH4X+lUeVC4QpR8Q3A/vTbqQZT7imq6MJDtPYlWFDqy1x5H9gKPaq2nSCd5AxAG4/Ep1pcOcxXs6TnIREPm5cCR/5L9QG34+RPY1KFTxWQk/HQBMUOyew3rkENr0Lwtnq6JTz+UyW00Laaw6jRIGp+FkAp5MHczm5m+PSfgXZxepBThfikSbDcZ1Vf+Xde4wIRP8ZAjj24iTPJ84n6S0GyHh6kVwE3fq9IwUwJ+MQAcQLNY0NEVJPaYi/MGPvNLBiRP+YRuFt889IjbK0UlxRX8QlbfZzIF6wGTmMM94oSPsowmlTgceOkqgRax5sVevk5M2MSuPECSkJd9TAD6MCGQjPTX8nxQ0GwpgnmIzC+pJmlUdEh9IT3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 01:37:41PM +0200, Pankaj Raghav (Samsung) wrote: > do { > unsigned long end; > + unsigned long i_size; Usually i_size is the name of a variable that contains an loff_t, not a page count. Not sure what to call this though. Also, can't we move this outside the loop? pgoff_t file_end = DIV_ROUND_UP(i_size_read(mapping->host), PAGE_SIZE) - 1; if (end_pgoff > file_end) end_pgoff = file_end;