From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613DDC4345F for ; Thu, 25 Apr 2024 17:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8D5D6B007B; Thu, 25 Apr 2024 13:27:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3CC66B0082; Thu, 25 Apr 2024 13:27:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD8B6B0083; Thu, 25 Apr 2024 13:27:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8BCFD6B007B for ; Thu, 25 Apr 2024 13:27:04 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 223D4C11BE for ; Thu, 25 Apr 2024 17:27:04 +0000 (UTC) X-FDA: 82048734768.07.7B4EC93 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf12.hostedemail.com (Postfix) with ESMTP id 3F90E4000A for ; Thu, 25 Apr 2024 17:27:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lZJduECv; spf=pass (imf12.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714066022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K0g4XLw3B45byIB1RDNUY38GqRrTXx8Au6b71CzhcTY=; b=oAdHAEK2sbcXUnb0XprO038zxkshcTzLdMqN4HiITZTOTgYOvsykGJjkM/swGCueHZftVK SW9bFCM/bxgoKFkEqfAYYxO06a+yNnklLfNeFBS1qEP2ulGOyK68iTqGEKMVuqCBa1+zB3 C7aclVjc3eKvAHQODP1SMS9iHYPPNXg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714066022; a=rsa-sha256; cv=none; b=EFrVMh+UUuvnX5bi1WEMEwysrBfQymXX0FVXTPYG+m82fylpaBwLkkXSFb8pK+3sJeqo8j AShhQ8TXon4vsusDmM6FrySyu6HDvDBWfokQuj9rVerpAo0HKJdDVBadXaxwgukrYaoqiz ItLUZTS1rGoOcdVtTpJ3qaoIcMLimtk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lZJduECv; spf=pass (imf12.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1eac92f7c74so6517325ad.3 for ; Thu, 25 Apr 2024 10:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714066021; x=1714670821; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=K0g4XLw3B45byIB1RDNUY38GqRrTXx8Au6b71CzhcTY=; b=lZJduECvU0gWcoAyQHXail3w7sTzqcqoIYuzD5KoDNvLT+OuGskamnyiriyNO/5r11 QdoM78+Z9ixJ4HBZd1NZ3Z6bVVkLlmIae1eNgly0nw8o6TG97Fy5e3CDhOX8rvk7GyBR eHJODq6m9nddpeitLj+Sc18G6x6RxSoBPR0NhqCPEcrbaYWvPlEJD0osXZBm99Oy8/K8 l9Obsk2DIHv6lfjxCwfYmk82ClmIj0imta7xSf+C5rjH55mhb+IuTfM4HjGOXK5U0OVN Nb3hMqeAPn+fOqI0CobkG/s6l5STMtjWv/OMs4NHbPnHtT3+jEChRUHu7WbLVgVksYGv cHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714066021; x=1714670821; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K0g4XLw3B45byIB1RDNUY38GqRrTXx8Au6b71CzhcTY=; b=BtLXR9D59TwW+9GGO0WytXSedZR8RS1DCTdqv7Umb2RgXmFkjufnjj4U1YHMlRY6xc UuE1kGelKrfIwcB0iY9GiQVMH1cpRLRu4AMr/+X7bRIG0COgl3ZibFD9z+pT1/wUb1XS RVAGl4BsJDg8net8m03QPJuhSsZOKk6TJ8zhYxkJ6V4njRk6plobJo2h9Nz/P2nJ0qMm 29djj53SppNZCpKqAUaEoTwz4RwXcZjspnpcaU9ERqPFqj4ZapcmfuFyJkLiP/sxUwHK MwGkos3HUnzQgN5/cgplmcBfE62+PvqFCwieXJ6G24z9zxS+OouPM99exBTTWDS5q6Rc WQSQ== X-Forwarded-Encrypted: i=1; AJvYcCWDhWNCT5e4twzagMQWbs+9XEw9OajzlJ0UxYXwBiFEQHhlQQbPIt041/UeEFWQH99qaw93bl/E95vCZe3cwgE8BKA= X-Gm-Message-State: AOJu0YzhFWEyZ6FecymIqiB2R427ElK7jNkXpfizLDs6sONVgXrH65sT TjmxQV6dpthAlcvboHkHrlTar8pnvemDjqqHg5toZ9th3ppdG8ow X-Google-Smtp-Source: AGHT+IHw1urF2jSmmVEyN/pDFpaeHgkS2s4n3bNqIbCZc/EzsYBVznM5xl8ZZJoveHKfQd5yVAxpTA== X-Received: by 2002:a17:902:8e83:b0:1e0:e85b:2d30 with SMTP id bg3-20020a1709028e8300b001e0e85b2d30mr174445plb.42.1714066020873; Thu, 25 Apr 2024 10:27:00 -0700 (PDT) Received: from debian ([2601:641:300:14de:8052:4ab9:f3ac:ce61]) by smtp.gmail.com with ESMTPSA id jv12-20020a170903058c00b001eab3baad5dsm1680463plb.4.2024.04.25.10.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 10:27:00 -0700 (PDT) From: fan X-Google-Original-From: fan Date: Thu, 25 Apr 2024 10:26:54 -0700 To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v8 04/10] cxl/mbox: Add SET_FEATURE mailbox command Message-ID: References: <20240419164720.1765-1-shiju.jose@huawei.com> <20240419164720.1765-5-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419164720.1765-5-shiju.jose@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3F90E4000A X-Stat-Signature: afa5ru8fbu4dims6zb58aeo7amr4bwe3 X-HE-Tag: 1714066022-468966 X-HE-Meta: U2FsdGVkX1/DigvXbwj+bk/4rCthAm3iefkM6xwsrpZ7GlIxZU1nhGhabPCEc3xOjiLrhmnxT1ysZ7CyHFermvFJUHdDbWdUFGZwk2t4AAL9P3r/eOTpfJOxqvnL9jJ1S8v8Bp5MZBWPjLf7eDoJUDvdIVQL+/wRxompmlETCZxXEyR8cOpRJh5Qid+ys52EudQS9c/ZQun92ORIZZuKh376aA5ouDskpv5llrZPLByLAcR+r84VEqD2dqVdnck6AR8+kt+4P45XdYgzy0TUNwtdiANDOxSvEOeZ5XCQYXukKN1RaVA3sSAn3XiHaXWH9PeA9Sc2VsEGWWgUAGV73sRGIHlfNgRypjiwBBbm/6dwTSyQlu3fOZ9n7lzNVDjUkeY6vdTviISKYbMbOJ4ZMWm4WF5TdQtIv02bXYjfQ34/AtGQTD0eKEHZshQsZV/C4CxAvGxbYsz0ZKWh0uYI4x6zelLI56/u+2lf2aLXOOubwyztQM6Rp8e75oFmJLDFmhuks5/1NfcrJeIVZaoCzdCn5eT9+pg1LcnTQ8My525Jbbz7PMdUhfqTWbAEudeUTkSDWKOZ4jlUR07EItTXtTDV1jobhOYiwoUd31nEG8CFQ3IatkFex3FIxBhvTTauFEBSHvB8bLs8yG5M9MICJGb/lEC/ZKeF7NjPOWZXAe5TkqEEmZmbWEcxl477kqg49O8fSVDAVIq39atD+KmACbRqqTFjwMyOlD3IBbL4MaEADDchrQ5eMLXzHBCwAwNZkgF4wybu/OqbjFmq5Ry64YW5v4O6WqoULW5kZn36DXVP7qdwb8p7cMaZ5+nXgeSe1xxMxXIBvaYrfZ4HZpvK5YxJjuN5cvOeOiaxSSiw2w52+hsG0RBOOcpUn6i392Wetvl9iorarxr+tMaUEOVqaWoXxB0zVENkba8zttvzUy9Jys9HNc80WPxyVC9L3Zjvsh2TIeE96LEMzDaJ5d7 /Q5BaPTb YDFPoDMX93k1usq1TuvU5gxGaaDNj/2BnPp+4Gfhc23lk8o324rdq1Y2biwI/7rpyNSmh9vfh8u5R5JfdcwT+VL/OSbCHNZgfjSr10y3CE1si6Ymp0baqe+4xiDS2T8e0NIZ61ukJvyoNxWt1ELvgay66JNjT9WyzGOMmRHzpKMmlwY0qHJbycV9aPGtSppEb4z+C/2QpbvNG4RE8HFCvE0401mBVNTUW2W6Fa1m9XPAw0BqIy1mxrBKQnA5V4iD1nAkiBCNeyYD+G5clIQLlhatjzo4tJLW/Gqj4FCIovfRPPw19tlRd7TFkZ6rwyWXStYUjc9lDvZywpMXB+9xmIiFswZ4WUMOA9Qe5ZoDvD/vMXwxu8fUifhYps7xQ5UdC5zaHMMWUjNd0KW1OAGARpFkzmctri07iUgPxS9MWK2kInH/8MWgWu5VaYBlkCqA9mN5aPPalmnmQqT/GUtRwwj4QhMXZfh6lhAPlghIzy0ikyN+jS0WfNvXKL6TRZ+RTEVKv3LImks/OJrajDFk+O6IukK1so+OU+g1+FUOmS8UtO3E0/sliA71hx9+z8g6oMAfa3ahFkJGYURFYkoZBV5dkHYkuB9OBSZ9uuBtFv/refIA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 20, 2024 at 12:47:13AM +0800, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for SET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices supports features with changeable attributes. > The settings of a feature can be optionally modified using Set Feature > command. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/mbox.c | 73 +++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 33 +++++++++++++++++++ > 2 files changed, 106 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 999965871048..4ca1238e8fec 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1371,6 +1371,79 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, > } > EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > > +/* > + * FEAT_DATA_MIN_PAYLOAD_SIZE - min extra number of bytes should be > + * available in the mailbox for storing the actual feature data so that > + * the feature data transfer would work as expected. > + */ > +#define FEAT_DATA_MIN_PAYLOAD_SIZE 10 > +int cxl_set_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, u8 feat_version, > + void *feat_data, size_t feat_data_size, > + u8 feat_flag) > +{ > + struct cxl_memdev_set_feat_pi { > + struct cxl_mbox_set_feat_hdr hdr; > + u8 feat_data[]; > + } __packed; > + size_t data_in_size, data_sent_size = 0; > + struct cxl_mbox_cmd mbox_cmd; > + size_t hdr_size; > + int rc = 0; > + > + struct cxl_memdev_set_feat_pi *pi __free(kfree) = > + kmalloc(mds->payload_size, GFP_KERNEL); > + pi->hdr.uuid = feat_uuid; > + pi->hdr.version = feat_version; > + feat_flag &= ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; > + hdr_size = sizeof(pi->hdr); > + /* > + * Check minimum mbox payload size is available for > + * the feature data transfer. > + */ > + if (hdr_size + FEAT_DATA_MIN_PAYLOAD_SIZE > mds->payload_size) > + return -ENOMEM; > + > + if ((hdr_size + feat_data_size) <= mds->payload_size) { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); > + data_in_size = feat_data_size; > + } else { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); > + data_in_size = mds->payload_size - hdr_size; > + } > + > + do { > + pi->hdr.offset = cpu_to_le16(data_sent_size); > + memcpy(pi->feat_data, feat_data + data_sent_size, data_in_size); > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_SET_FEATURE, > + .size_in = hdr_size + data_in_size, > + .payload_in = pi, > + }; > + rc = cxl_internal_send_cmd(mds, &mbox_cmd); > + if (rc < 0) > + return rc; > + > + data_sent_size += data_in_size; > + if (data_sent_size >= feat_data_size) > + return 0; > + > + if ((feat_data_size - data_sent_size) <= (mds->payload_size - hdr_size)) { > + data_in_size = feat_data_size - data_sent_size; > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); > + } else { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); > + } > + } while (true); > + > + return rc; Dead code. Fan > +} > +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); > + > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index c822eb30e6d1..1c50a3e2eced 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -529,6 +529,7 @@ enum cxl_opcode { > CXL_MBOX_OP_GET_LOG = 0x0401, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > CXL_MBOX_OP_GET_FEATURE = 0x0501, > + CXL_MBOX_OP_SET_FEATURE = 0x0502, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -777,6 +778,34 @@ struct cxl_mbox_get_feat_in { > u8 selection; > } __packed; > > +/* > + * Set Feature CXL 3.1 Spec 8.2.9.6.3 > + */ > + > +/* > + * Set Feature input payload > + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 > + */ > +/* Set Feature : Payload in flags */ > +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) > +enum cxl_set_feat_flag_data_transfer { > + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX > +}; > +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) > + > +struct cxl_mbox_set_feat_hdr { > + uuid_t uuid; > + __le32 flags; > + __le16 offset; > + u8 version; > + u8 rsvd[9]; > +} __packed; > + > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; > @@ -916,6 +945,10 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, > size_t feat_out_size, > size_t feat_out_min_size, > enum cxl_get_feat_selection selection); > +int cxl_set_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, u8 feat_version, > + void *feat_data, size_t feat_data_size, > + u8 feat_flag); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); > -- > 2.34.1 >