From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D2CC4345F for ; Thu, 25 Apr 2024 18:54:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF67C6B0085; Thu, 25 Apr 2024 14:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA68F6B0088; Thu, 25 Apr 2024 14:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B946F6B0089; Thu, 25 Apr 2024 14:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F8866B0085 for ; Thu, 25 Apr 2024 14:54:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 25F301A0679 for ; Thu, 25 Apr 2024 18:54:11 +0000 (UTC) X-FDA: 82048954302.10.AD67C2D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id B23AD40013 for ; Thu, 25 Apr 2024 18:54:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Jxve/Ywx"; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714071249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oyktM7E7M+KuWF5/aH7rtY519Fb1ZAYOKfjC4XC5Z9w=; b=0FxzwPQyAmSFTEvjL8yqMo5F3ETDbbsP5JDxHBSMH1mXyqosM1bGnuxjunt0NSakKReRRJ FMLNrGRNGZqvtNdFbUpXS9uJ3EIhOjt0Cdtll2ST25v9TZlCBbjaGK8UQKfwMafLCbQH6C TcflSt9rX0oROyCzpkIglYBohE2Z+A8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Jxve/Ywx"; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714071249; a=rsa-sha256; cv=none; b=BaeicNYBPwNBneLRuryDYsHW167q4kRI3gdMW6hL0ATIwsLYcu3ZOnsX8m0MR6VUZD+Vvc Ycb7f3HcvaF9/MLnmNnkQRIUEF+ebsylLzlzhKe8NbwW5v/1zGGM5V6eIh2ZBkPLphdZHm BdGJ27W91r/XeICNyA/EbZX+lNNdBHQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oyktM7E7M+KuWF5/aH7rtY519Fb1ZAYOKfjC4XC5Z9w=; b=Jxve/YwxL+dQtqIlLtYdKWLJMs UbHt8PJvUuKGgFbyB3H/5NK/iatBxYjqomlid8oQOKtjGb/7lMi/9+lVr06WliZh0NZyxuEalolj4 vyNiKjVObuqv2rnIgkltCLSW29eDwOXj5WiF+di6I1l0zKXkRkt6SbG8OqH6+NCnCtxQMd9ZLPXNg ov2w1wl4w5UwEqDCzwWnAYQrrNeYzO6BDIAiN/tuRCVA/yuz1EEKLRpk6xav/3RT81EL3RmVvwAgF kNBk9P0Y7DcOxH1NZPnqVX+0LNpHA1jrI7WovPoDfiyCwIPnEKRyzRIoKDgJTy55B+TnC6F/ATIlt pPpvhqJg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s04EG-00000003apA-0XsP; Thu, 25 Apr 2024 18:53:56 +0000 Date: Thu, 25 Apr 2024 19:53:56 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 04/11] readahead: allocate folios with mapping_min_order in readahead Message-ID: References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425113746.335530-5-kernel@pankajraghav.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B23AD40013 X-Rspam-User: X-Stat-Signature: 5yidtgoit4mr6gqwew6aucp7n7qzd9xq X-HE-Tag: 1714071248-868883 X-HE-Meta: U2FsdGVkX193I4GmUBbsTZ31CW264BSwbz88hbFY8E6RUN8JNIwWFWnubIghJmRpiOXuGxchusNVTPevatE2K+KShvgBCLVl6dGwnpaWIdMeSPYdBxc5igtMuQDpbEwbmDVgDR4bVcr8eY+qQaY3RN3jO8amHg6dXKVA28D+JwksHNicA2NSSqMpivxS5EGpA7dNPvYI3R3e6d9qts6SL3PA3jW0c3TvykWvH+NrDrU0FPIz5XorFC1TciO65c4eosl3n9Xb9P33a/VN0ug7Nz7vagxvFOy4rFnhSsDuhSlzaDs93dh2hbe+or2iG/R133AE6p081kGe71UX3gbqCvtJqNdj4FVtZnnxeBafQABBaM6pH1MgTVgWXQe+5/MvtEz1mnwRhn1UN0sMGdzLqPuqlewaky70T+6xb8CU42m+sc6c54ZR/ZMsQIxqHb3wZE9BKunAQ6uQnR9JYYmoeD4VK5uEgLvC96avi/JSWj0uh0NESQsXvcTPC2fdqoo7oa2Y3LE/PI5AUWumx0QF7x75BUg15qtlqHeMgcr2rsNlckeO02nQQtXdIaLEAYfABS8J9xVmnsjw2heeX22zQNqiI4o9KXRboFiBPm7OHI0r9H/PAiBQXkFmiRvO9tkwbqxTAo0ipYtmAxAOhIqjs7HGZ4d+tgoWuca8fIA5L3RMC+KczXhWFd1K2CtU4LGcRVLrvkWGAMvVNQEoITx0nvU/7UMfory2/YaRY7A5xcCoQfxl9N2WmzV1wWHNsexnoEJANkOV1NJjKmsPZZQAvuHigccuwwaNBk36NDXxohFIvdMmG7TX1XchKFpSmZLOobWicSidvMsx+k4NPdT4DS8/oebIKEI5NQPsVmbxFZvVI6HFqrKvkfq/5UM862pA3x+ixv9jdzOS1ETn3Why35qlz0qsi6BRowImDb3hew6EAA3KkESEmitF6veptFe4MOQwU+bNXmirvK+IoYZ WWTbfiPj XZQTMaryfUhpiXxpkoAXyZqe5UyPrYD8SzcCGcxFENhNb/w1W+nwJqKYJr9pskb+42WlliuDTOvsWoR3Xy1nDoNPy0wevsHbULCR1foOCgmPdZqmWnq0zpMtX5peMfxpoyax35i+caIv4PSD/R5f7E8JywAvpkYwgb4Vd3nujppCMOqhQ9bshC2hCkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 01:37:39PM +0200, Pankaj Raghav (Samsung) wrote: > + unsigned long index = readahead_index(ractl), ra_folio_index; This is confusing. Uninitialised variables should go before initialised ones. So either: unsigned long ra_folio_index, index = readahead_index(ractl); or unsigned long index = readahead_index(ractl); unsigned long ra_folio_index; > + unsigned long i = 0, mark; ditto