From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9438EC4345F for ; Fri, 26 Apr 2024 23:46:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB80A6B007B; Fri, 26 Apr 2024 19:46:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C67C46B0082; Fri, 26 Apr 2024 19:46:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2F1A6B0083; Fri, 26 Apr 2024 19:46:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A65F6B007B for ; Fri, 26 Apr 2024 19:46:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3F2BB1606BF for ; Fri, 26 Apr 2024 23:46:22 +0000 (UTC) X-FDA: 82053319404.25.2E819B5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 1E8A2180003 for ; Fri, 26 Apr 2024 23:46:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xRE0wDIs; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714175179; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oEICw/YBQkHFydzURongpQCI84RNVUsQ3AXdXR1HsB8=; b=rHV/Cg73yEcteMTpAzJrob7mtbd9zZ5HFybaiSPirT8dCnUMveFu4Yv+O1IwZDf5Q1iiU1 6k+iAJNQl4rK7VJb4UQ6V+D3quiOT+bazxkgdjCNDJlEs8ygIjTlc+ltqqGJS2dLnFi9Qb WGY76FxXQMQA4TDxj3TLgEhxQj0B1mg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714175179; a=rsa-sha256; cv=none; b=RBHdimX0VPZkuSxKZi8ONflYn6LC5G8elLrbyXgWyCmgWEuUVJtIVxOp49DqhmRPu2a8KT vCN6WrSQ+aCAhXfLyk5Qfd5UuHoPbAq0Fr4GF4ROkEFEjz3z0ajaqhIPUezhxYArjIEzW5 TIEwSCCaEAaNMQp/qvLwbgoklwO/Nn4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xRE0wDIs; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oEICw/YBQkHFydzURongpQCI84RNVUsQ3AXdXR1HsB8=; b=xRE0wDIs5SY5sV0mNmw7sdP037 4tOO5LC8H0SVowqjZeSy9lYEmZJYVFvcjBVXyNnehBzVqXcRwDjohOENq26j/98PrZkhAQP8qNrJk yCEbmT7DXmmwydHutCZPtO8vBDheohXL91jYHolL5nYoy4K3FU6Yga6nYPJDS7xoxVmzZ+toNricm rbnAabsp0fEd8cxbBi5hivc2rBXSDUMrSCkjDWPqh995LL41quiI2FQlmVNsIN+/4sJ2MbjmxH/84 5V3qxlcw9ou7VzvTUNMijxpdELciJt92Q3k7USXxzcUqmtDSBiRLbbpsTcdUxolacCAGcNUZzPxlj ZeWjDZyg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0VGd-0000000EOAk-0VYk; Fri, 26 Apr 2024 23:46:11 +0000 Date: Fri, 26 Apr 2024 16:46:11 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: "Pankaj Raghav (Samsung)" , djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 05/11] mm: do not split a folio if it has minimum folio order requirement Message-ID: References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-6-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1E8A2180003 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6t4e5sisqcqac6sbthi7jyiprbi6ayby X-HE-Tag: 1714175178-67571 X-HE-Meta: U2FsdGVkX1/vJPO2GryyLSK3YsqG9cM6gZx5S424LYPfV9+qgfWcT8C12MRVcHPQnqbTPlv9W0JP8g4PY4ytqI9qgNc2Cn/ntgsW22TFtN/JOLrhKqQiDtSOFQggAPYQV7Nj/fMf81y9WLze8uVyB3QUrJUbfxMFZLWjZ5aYzhR/L0DaRh8nVripTbNxrx1P4G+BXIxWQ82kXaP7vET5rfgBp4oO9RuGSpjvQLySK0IGQMcRnrf2NZwvTxsY5yU7pH9c1VQV6up5msMAMybiiqQXaCuDNdYrSCVuVJkRHEc9Fgb9TRxKTb2LW6EfeRII5zmVP1q83SRpbliG8irt7rWe99/L78Sm0sCr8oMKlf/Z9PAita2RjZmohirXQ9bvsZmazBRA50TjPU1ij6brG/pJnEdfTkObyVMUN9DWya7Arklk9vRb1I56vKmO2KYZ7tRofQg5Q38lnh4HkOhCh0jeFFlmGy3XN5SeBeoD+AMD5ZABUN58yzPSuOzujxDKY1a5hD+JGICPiuWbOKQzRuUtihBPAz3gJp3AHz6M/8OeAXoeEzaWiPPMuJRp1+d9MFULmJNcBUNHe4WrfhtmdjroxUGeFQLht+iQmYLQwLgEQj/mru4KbcC8T7uh+3irvZ7CKWuemZJVGPqCCySueIq2epzmn+2o3iVv5aNGWHNu1vnOPJ0Pj9eftdNMuG/Hv+JrKFA69259Oo8IhMSzqhvB0dktgZOV5mqecs9gn2JtITjYpp2DB6DHXH2KLDf9u/yFqnikmQ5d8LsWRzyQ/E6WWgcfdx+vnRXxJmvm/s0F7klnTdjZaXnby55H9dv5cXrYsLgn5YJH724eMx/NBncx6ymovIu4LJcAGMu3o5VQzCvCQo6y0tGk8mvacel9humsDCiGRxBs9O+JDmSHmloXYqJfdEJi93souCzdGBLddsgEeFr6A6JlJ39e40bQ9ZJR2mqUZ5MvWq94lU3 AD4bjT2t OGetuJdfRIFZ/ILf624Tg35JTcqc2tyRg/HRD98F7HFe0ZdFkLS9QEkRrBVsjC4MWxwjiRORxHRz6+2flFUPTNYOxp+ZXToA4YFYAmaKwZlZ/Mp1QKsMuzq6rVOwYTmw6rsEEul/RvrTgiERPCxTYTA2Z5VKSHP+TVAijRt1M9ZNnjc9kA1mUdI/d5E/BHpW0eI5X63dLXYUm+LlmpS4dy+S34spiboDljB3x+W1lC+xJWZZySJskgG8h/Hch86L7Z7Hz8YwscUJeV+HsUFBKerhL7cElHo/7JJ2l0rSUdsQXakVAN/CIFnvdcmnM58bREPRtXfqdcxUzXC7FhIrRvCuayu0Jpr89Qjt6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 05:47:28PM -0700, Luis Chamberlain wrote: > On Thu, Apr 25, 2024 at 09:10:16PM +0100, Matthew Wilcox wrote: > > On Thu, Apr 25, 2024 at 01:37:40PM +0200, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav > > > > > > using that API for LBS is resulting in an NULL ptr dereference > > > error in the writeback path [1]. > > > > > > [1] https://gist.github.com/mcgrof/d12f586ec6ebe32b2472b5d634c397df > > > > How would I go about reproducing this? > > Using kdevops this is easy: > > make defconfig-lbs-xfs-small -j $(nproc) > make -j $(nproc) I forgot after the above: make bringup > make fstests > make linux > make fstests-baseline TESTS=generic/447 COUNT=10 > tail -f guestfs/*-xfs-reflink-16k-4ks/console.log The above tail command needs sudo prefix for now too. > or > sudo virsh list > sudo virsh console ${foo}-xfs-reflink-16k-4ks > > Where $foo is the value of CONFIG_KDEVOPS_HOSTS_PREFIX in .config for > your kdevops run. > > I didn't have time to verify if the above commands for kdevops worked I did now, I forgot to git push commits to kdevops yesterday but I confirm the above steps can be used to repdroduce this issue now. Luis