From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 252CDC4345F for ; Sat, 27 Apr 2024 04:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9A56B008C; Sat, 27 Apr 2024 00:52:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99A1B6B0092; Sat, 27 Apr 2024 00:52:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863496B0093; Sat, 27 Apr 2024 00:52:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 679866B008C for ; Sat, 27 Apr 2024 00:52:56 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DB5EA1C0F20 for ; Sat, 27 Apr 2024 04:52:55 +0000 (UTC) X-FDA: 82054091910.25.9D8575D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id D880FC0015 for ; Sat, 27 Apr 2024 04:52:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bPAWAAb3; spf=none (imf28.hostedemail.com: domain of BATV+cfef69f9c3dbeacee83f+7552+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+cfef69f9c3dbeacee83f+7552+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714193572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cI4NhT54XJQW9j011jj9qavFEqDFKemcmwzLd5Nc2A8=; b=rML41/mYFjYAwovQ7oYrQW8626jFIAiaGTmSDu204ErryqK02zRwSBHA4RpN3iRScKNoTn Y4vrDCIvYqIRE2UcG+nfXx2fYB847Ndmutw+hWwB/1j0+C4klOp8Bdz8fpX/RJsJEQvgqq p6yJa0HcQAZCrEvogzNsfuM1E4qQetU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714193572; a=rsa-sha256; cv=none; b=fxnDevq3doboT+gST3CAMv+fTafrYUNDioo5k6G4Kuk8ascjffoGqS3HHx3K40sD+bo9Ty IrqDztNWT2wFQf54qXnM4QiPX6tu2qBb7bL4BC4BqPfIXq0yr+N74bqRPmNGuWSLUDWpjv L6gdHbMWTSAFYnJBjy7bBQS3hWUeYq8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bPAWAAb3; spf=none (imf28.hostedemail.com: domain of BATV+cfef69f9c3dbeacee83f+7552+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+cfef69f9c3dbeacee83f+7552+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cI4NhT54XJQW9j011jj9qavFEqDFKemcmwzLd5Nc2A8=; b=bPAWAAb36C3P7xHAHzgnjaFMDU Y3JaYL8W0w6BCbiw4fK0P4bIYdYeAwF+l0SmQteiR75RBPZBMMfqUrWx/kfPkQ5osfV1yOl9/wkDX EW5O9JUCXsDVsJAcXVPnT0sOdJoNlEzh5HF319wEqhfI/l+dAt9Z4/BiAMqCRRlxLL7MaCZGBYJ1n h9Xo52YenoDDhRkWerBLXskUz0cpjOhMVqsii+9ojdP6kHhvuO5pEkBaJbC39T7laYB9sWswqxRh9 Jof0E3VnLBsAheIVsnjrMVTF3LSFSWhtmWe3vZJd2REjC3xWJwioZb9+SzISJULpQ9Gg7uMelDVAi 8K9J4GQQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0a3F-0000000EpDA-1S8o; Sat, 27 Apr 2024 04:52:41 +0000 Date: Fri, 26 Apr 2024 21:52:41 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Pankaj Raghav (Samsung)" , djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-8-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: 7jgqecbmetihh7gzq9s8di14rb9iaxcw X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D880FC0015 X-HE-Tag: 1714193571-782946 X-HE-Meta: U2FsdGVkX19fCn7AKXjKe3pp/H03EWECo1wSPj9KF9QXWUlKpm0Q14KW5ndj8VLhPxn2I0Y1BBPmn504WwLb8PykwvTfrNs/CLbfDkfZqjy2DSzV2+uW6rpZWwHN3KoCp9FrmB3TeMVC6NpoWcBjhdOKn7GSwt4t3g/Hxpl6v4jaxVNRyubZbDOXOIWe+1whbeWU1Yx7gSA+RkyuqP91c2qY7pRGPY85DB0a7yK6WsU8rM/uzUl+9jFeTPxRsMiQKPFFKlN311QnwG+ubEhKIqM3AQd0Mc0Q43ha55WmJdsyWHWoC0UucG5SdayghOTg5udz/6cVn/hn8EzIpDQi39xgGW3tqPvZoCRDaO76uoepZ6mT7UZWFDzHo2QL08vN+xzQpxliHQSx9D5uxiC8uIXeqjPN+nUED6ZZwG98orSAtbEPQUMdjTlccNJ2WMauutDG7OxSiJf40wQH8MfIYvqTOgiNCazBJInX7mMwlElAICGnFDn/WshN0i/FXcDTS5N4Nu8SG1QtQJi/DBOHM7A7gqdf+3n0hmp2QmwzaTEtzO3dvC4eNvwVekek8+QHvHMRm01FjkKtD6lB4GhAZJYqQwmQ4O+je0YmpzY1FG+3+/yiasUF7ja5Jv0A5irZf4VdfmANXVsf/+O+clPp5Z5biTmNauT1dRI2UEa43pVxtTyDpZhMuQZD+9E858luVG3ZSguxV4bWzIpqTY0FDHfBeqBd6exCtmhlOgtLXsexWUUchtaFkw2wBb80LrX9b5DvFCrVXFeXYutwPmuSI6AXLpjFOWPyNUlWAdYFpBNvLE9eu5SEIIPb/O+8fLhBTCKxX4pLGfhnjX0U7pFqA8DenBIhehT5S/h1LKKxC6Q46jcdoJ07grxpPGpG9O/iicjpDtSDlsF+eO8lPHCFgV0f+W9e1QsoikW3DjBMWhJRVAWu8luP1jkrluYndi/i5nJPYmWK7iro5PnoF6v BIHJezqQ g6EH36Q/TlDAw8JmwOZ01UZk3ClNzFqLkXnJVDWlkeCo7F6I/NzaenGhwzOBI0mOtzIxHNJ+ms7BWS8Gwi7IZxwrWxgZ4X8ABIa487t1a9ouy5uNjCup3qbirea3nB6Z+eQjwHwASHDPYzGt36/Q6C6lX9lwMF5fv3Ho06wqL/O6GTxp+tqCzpMwmzCOYJU9qsFOQBYl9Vu7jYMQ1mM+htC5V6ZpGk8KDNUidMwI9It8JBH1QR6gbQ6jWgr4pDmHXU1GsK9nOgd3kubagG39JrGrAbOzh7EDpYM1P5jH0piHAE2y7dT/fkqw2u8784EcIDMjYa3I+nwXwup0Uy/E+a9Dj7fAknJfdcTcA0maLBguP7XsHHRx6JursnWX3pLHNmPz7i0KSsQNpoRSc8c7s/zDKZaeZjEpJuHmp2ElIURO4rD8Zz/KSA9yvlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 27, 2024 at 04:26:44AM +0100, Matthew Wilcox wrote: > There's a series of commits in linux-mm with the titles: > > sparc: use is_huge_zero_pmd() > mm: add is_huge_zero_folio() > mm: add pmd_folio() > mm: convert migrate_vma_collect_pmd to use a folio > mm: convert huge_zero_page to huge_zero_folio > mm: convert do_huge_pmd_anonymous_page to huge_zero_folio > dax: use huge_zero_folio > mm: rename mm_put_huge_zero_page to mm_put_huge_zero_folio > > > it available for non-hugetlb setups? Not only would this be cleaner > > and more efficient, but it would actually work for the case where you'd > > have to zero more than 1MB on a 4k PAGE_SIZE system, which doesn't > > seem impossible with 2MB folios. > > It is available for non-hugetlb setups. It is however allocated on > demand, so it might not be available. We could just export get_huge_zero_page/put_huge_zero_page and make sure it is is available for block sizse > PAGE_SIZE file systems, or is there a good argument against that?