From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C31C25B10 for ; Fri, 10 May 2024 20:30:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F74E6B0122; Fri, 10 May 2024 16:30:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8803D6B0123; Fri, 10 May 2024 16:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F9FB6B0124; Fri, 10 May 2024 16:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F1146B0122 for ; Fri, 10 May 2024 16:30:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E2962121050 for ; Fri, 10 May 2024 20:30:42 +0000 (UTC) X-FDA: 82103629524.11.0060043 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf26.hostedemail.com (Postfix) with ESMTP id E718D14001C for ; Fri, 10 May 2024 20:30:40 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="LOdx/WT4"; dmarc=none; spf=pass (imf26.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715373041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f6+vAbiClRDiC4uIvdtPo+0v0pdzSTB+/qaSHejfRyI=; b=siVFWC8yYySkVu48jxyWTtPgYdJxbB6dDnRHIFPhBumtCCel03q1XDhtpqpTOirhuQN4sj rr4U4Cq0MArcMwhQPqpj9ckRhzGOP9ujRFv9ClUdojuU+MzIPusiUtVasXvbpfYbxxfzhB pLMp5vPl9hZUpsEDeozpTWBsuF4GoKw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715373041; a=rsa-sha256; cv=none; b=46RFQB90lL+1C2OecvmHSTVGTvGCCIWHSqHBv/zQW5EnQ9p0OfKxSUZfUdN/Ilv2mY/Rjw f2CGkJYTH2E+vNmxxxFy2uVPnI8mdDkzET/X0Jy6Eik24WJPqiC+wQZRdsfPVn2uJf1PrJ 0SNJgBSTSjcFU4IxZOittor0jy4JL4w= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="LOdx/WT4"; dmarc=none; spf=pass (imf26.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=charlie@rivosinc.com Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1ed41eb3382so18347535ad.0 for ; Fri, 10 May 2024 13:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715373040; x=1715977840; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f6+vAbiClRDiC4uIvdtPo+0v0pdzSTB+/qaSHejfRyI=; b=LOdx/WT4552tBKNm4vy2m591RW5i/7MVzYqShBpqY+Zu8/7oUn6PzBaUFHExJaNlnQ Zu/sbTp8edi/lRt6t+9MpUBKgnQ2fwOF4EQYqom5nzwFzzpu5d/ibPt6fWzgh+Luk25J +7CPao5ySkoLw4xoSIusEXNKdVP98LKD/Nvl5mXhoWgNdjBaWbWTV5cntYTiyluHA4zg /JOWH0V81qBJaYSDd0DmSa+/Ce/bTGS/L0PmuGImADm9jVOQSvgHlO0BhcGj8P7Q2Xg7 BSvuvTWbtUENiJGEDIlDOlVtp9GFEzMLPAgH9ad02IBixN0tRi0kuG78JW6FiMl16hdA CWBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715373040; x=1715977840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f6+vAbiClRDiC4uIvdtPo+0v0pdzSTB+/qaSHejfRyI=; b=QRk3bDT4qB4C0HZdsbyS8vNpwIkYs6HdAuah/EouoaZ3x3X8aFEWvwejSGjUi6EEcC fmI/d4wMPBs+LEv8O5Nhr1HkRI5bK4OwwuX/sIyzFW7a05127G2TMEyYVOvwa0G/d1FZ zaAbrUGWoumC3uyKPAMHq5OOiaBBnZxWAi2PpFCpPUQnx2ISo0nZf3ZfIhDsiO10MqKk 4PpNMsbbcqlUSw8ib4eP/tNaAo5r+KfDLeHwQrnvbhzdilc87Z+Tp4vLDwefqOsAV20z A38dTBe7qUZCimtf+G3HtJ7/q5P2wmgPGJnr8sa1OvhXDVlZ9Aow45Bi+ylHJ4CXjdHV MMTQ== X-Forwarded-Encrypted: i=1; AJvYcCVj2JAbhKG2K6siCM/fNQSY1zv8u0yHHGY/NNgrbXlPlYIyNQhn6/HbGnPtG+6y2rP7rIWnM4g4MY66s69A/TSLgNM= X-Gm-Message-State: AOJu0YyY1eBoYEQvlDcyjeRsuW4eKTCAzhE7GE5ITZq4GwYy6ZcYE0Lj 5Hdhx33sjqmxC+mVQefZYnZCFQKZ+vxWHt/r3CpHBRNsau409SQxxKyANnbZavI= X-Google-Smtp-Source: AGHT+IFPBkbU2aNYrXQ8809dzA+eKb9uiS2PXSzCao5t90cyhOzkMcMmTiaCTPqTvHS08OSljlo5Sg== X-Received: by 2002:a17:902:7ed0:b0:1eb:dae:bdab with SMTP id d9443c01a7336-1ef43f4e315mr43128725ad.46.1715373039531; Fri, 10 May 2024 13:30:39 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:629e:3f2:f321:6c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c138c04sm36433135ad.267.2024.05.10.13.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 13:30:38 -0700 (PDT) Date: Fri, 10 May 2024 13:30:32 -0700 From: Charlie Jenkins To: Deepak Gupta Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH v3 27/29] riscv: Documentation for landing pad / indirect branch tracking Message-ID: References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-28-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403234054.2020347-28-debug@rivosinc.com> X-Stat-Signature: 8dqe18kosrnbrztqc5ken3pk9o455pym X-Rspamd-Queue-Id: E718D14001C X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715373040-974959 X-HE-Meta: U2FsdGVkX19zZRoOv4bGhdhXVpX/MlGeUW0iukW/vgcMFfHuBnw5Bj1aNmjWOMZif0mUr2h+EWW+J3NtRnrMVXP9Wc+4lHbyklo4sIOpbzuO0mQBiOy0KdeUFWRnPVIJDM0u6qnGamOA4qfjx5hjM9Ts14HTgXoeKdmeFqWk7KDHdnrjcAC03dIAl+kd6f6RY7DZHcGxLoUi3Dl4+0swDl9lNeoyyevKJjZFx788ijFiNq62/dkeD8R5ccqmoc64gSZrT8k+WV149BCKE1gn0gHzdNe7uR2oT5ziyDSs8AOKadELUXSNxFTU5T/rd0J22bwfni9eHUB8IxfSsyhVKQkR9nRZvCO48wMbxmqqepjTTWfwF5zWWxKZ006Q7k6LfAcNquyU8iKesl5EWSGwZp1ot+mUmlDmiQ6lRh6pA2DiI3L0QjBi4N+DcC6ZXkmBDlXmqkqQohHwiXq2gZX0kgex/jbBSGVxK9wnQGQG3QWx7rfStFiWVr5Yf6WjBnxkUiRZMQ2vrDHj6hHfM6w1vjixR5EZKjnTY3W3KuNSSgIums135eCn17IVrXGRSU61LXS+7KKT0Y3j/zWufLDcCEKPCLs0Bt5vLZAOWDqW+jVHVZfRhYg6Ys4RhAteh7WdcmQ0Y9Wd2nS1ZGbCuEC7Yi/2Me3jsGSx2JtBlBqswu1GwwVp5qK0iqacLfZwDeAPupuADKTOnVPYVPPydHzNImnM6aKJV5As8pcAtXgE56HnYN7AEcGd96hsBScGl5lBWJXjtz6BvRE1eDkM1Ju0PQ8yJeFqUA85A5Sl1ybPvE3bADyPALF1LPQk8ITecQLxHiVdFr9CVCzwvHzUV6WamtPlSqeskspiTgUs3ETEWBx3euk05r3VlzTD1LgKH9oOgRn4mm0FRyVEA620sNsSHhdAZ7cit+kbyWpVL2T0L9Otc6qdIszR39Nc/o2eO+FBXtbRwbxBIwXmn1YsWXX 9QXapenJ Vf5x1XhF1C6/TNdPHupURBOSBqyEw6dPNW/nsmM27Vvzswt5znebKFCp5lF3G+p5QjNXSG8GXIIq82lzbNtuT/tw8Py8NODcYeRMoXML0VTGCY/zDa/AaYwH/jrJtUhchT/6K+KJpXaMKQb5uEVkeEw8c1JY2jnkka6M9uBUghklbqkQmWadLhpW3bW5yVo9sUKf1my9UtMiY4+QQKqFTrZdLacmbK7IlVAji6XAHONHUIg4QU7zDY/Yqmli/sEkZyW252uJNxFXJ9R6pRvaZlJ1g3Ft0Jf+S/4j5maHS+5CJKsWxml1Ll1mYF7QPAG+dtTMf1wkeTVhKNYYKUbPI3lcn2d5gle9K9rcEHExt2Ncm+RGawvb4im5FaSRPg28HpnNemd0c6vwkJGz+qUKF6he5iP3uttSu+S0U9Owt4mOYd6imeWxW6vibBO8JO1pjWow+McKySSRyLwfS5nSExTDfj2U4/GiOE/oIvc6Iif6+9zuAIuJ7m4ENI9a8Pblb0VsSnx+tFvvm9fDxZq9rM6ylOvdJ1SJBIjbQUan0DWhNy43RCFogkvWCFkZJ9QBNv/+Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 04:35:15PM -0700, Deepak Gupta wrote: > Adding documentation on landing pad aka indirect branch tracking on riscv > and kernel interfaces exposed so that user tasks can enable it. > > Signed-off-by: Deepak Gupta > --- > Documentation/arch/riscv/zicfilp.rst | 104 +++++++++++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/arch/riscv/zicfilp.rst > > diff --git a/Documentation/arch/riscv/zicfilp.rst b/Documentation/arch/riscv/zicfilp.rst > new file mode 100644 > index 000000000000..3007c81f0465 > --- /dev/null > +++ b/Documentation/arch/riscv/zicfilp.rst > @@ -0,0 +1,104 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +:Author: Deepak Gupta > +:Date: 12 January 2024 > + > +==================================================== > +Tracking indirect control transfers on RISC-V Linux > +==================================================== > + > +This document briefly describes the interface provided to userspace by Linux > +to enable indirect branch tracking for user mode applications on RISV-V > + > +1. Feature Overview > +-------------------- > + > +Memory corruption issues usually result in to crashes, however when in hands of > +an adversary and if used creatively can result into variety security issues. > + > +One of those security issues can be code re-use attacks on program where adversary > +can use corrupt function pointers and chain them together to perform jump oriented > +programming (JOP) or call oriented programming (COP) and thus compromising control > +flow integrity (CFI) of the program. > + > +Function pointers live in read-write memory and thus are susceptible to corruption > +and allows an adversary to reach any program counter (PC) in address space. On > +RISC-V zicfilp extension enforces a restriction on such indirect control transfers > + > + - indirect control transfers must land on a landing pad instruction `lpad`. > + There are two exception to this rule > + - rs1 = x1 or rs1 = x5, i.e. a return from a function and returns are What is a return that is not a return from a function? > + protected using shadow stack (see zicfiss.rst) > + > + - rs1 = x7. On RISC-V compiler usually does below to reach function > + which is beyond the offset possible J-type instruction. > + > + "auipc x7, " > + "jalr (x7)" > + > + Such form of indirect control transfer are still immutable and don't rely > + on memory and thus rs1=x7 is exempted from tracking and considered software > + guarded jumps. > + > +`lpad` instruction is pseudo of `auipc rd, ` and is a HINT nop. `lpad` I think this should say "x0" or instead of "rd", or mention that rd=x0. > +instruction must be aligned on 4 byte boundary and compares 20 bit immediate with x7. > +If `imm_20bit` == 0, CPU don't perform any comparision with x7. If `imm_20bit` != 0, > +then `imm_20bit` must match x7 else CPU will raise `software check exception` > +(cause=18)with `*tval = 2`. > + > +Compiler can generate a hash over function signatures and setup them (truncated > +to 20bit) in x7 at callsites and function proglogs can have `lpad` with same "prologues" instead of "proglogs" > +function hash. This further reduces number of program counters a call site can > +reach. > + > +2. ELF and psABI > +----------------- > + > +Toolchain sets up `GNU_PROPERTY_RISCV_FEATURE_1_FCFI` for property > +`GNU_PROPERTY_RISCV_FEATURE_1_AND` in notes section of the object file. > + > +3. Linux enabling > +------------------ > + > +User space programs can have multiple shared objects loaded in its address space > +and it's a difficult task to make sure all the dependencies have been compiled > +with support of indirect branch. Thus it's left to dynamic loader to enable > +indirect branch tracking for the program. > + > +4. prctl() enabling > +-------------------- > + > +`PR_SET_INDIR_BR_LP_STATUS` / `PR_GET_INDIR_BR_LP_STATUS` / > +`PR_LOCK_INDIR_BR_LP_STATUS` are three prctls added to manage indirect branch > +tracking. prctls are arch agnostic and returns -EINVAL on other arches. > + > +`PR_SET_INDIR_BR_LP_STATUS`: If arg1 `PR_INDIR_BR_LP_ENABLE` and if CPU supports > +`zicfilp` then kernel will enabled indirect branch tracking for the task. > +Dynamic loader can issue this `prctl` once it has determined that all the objects > +loaded in address space support indirect branch tracking. Additionally if there is > +a `dlopen` to an object which wasn't compiled with `zicfilp`, dynamic loader can > +issue this prctl with arg1 set to 0 (i.e. `PR_INDIR_BR_LP_ENABLE` being clear) > + > +`PR_GET_INDIR_BR_LP_STATUS`: Returns current status of indirect branch tracking. > +If enabled it'll return `PR_INDIR_BR_LP_ENABLE` > + > +`PR_LOCK_INDIR_BR_LP_STATUS`: Locks current status of indirect branch tracking on > +the task. User space may want to run with strict security posture and wouldn't want > +loading of objects without `zicfilp` support in it and thus would want to disallow > +disabling of indirect branch tracking. In that case user space can use this prctl > +to lock current settings. > + > +5. violations related to indirect branch tracking > +-------------------------------------------------- > + > +Pertaining to indirect branch tracking, CPU raises software check exception in > +following conditions > + - missing `lpad` after indirect call / jmp > + - `lpad` not on 4 byte boundary > + - `imm_20bit` embedded in `lpad` instruction doesn't match with `x7` > + > +In all 3 cases, `*tval = 2` is captured and software check exception is raised > +(cause=18) > + > +Linux kernel will treat this as `SIGSEV`` with code = `SEGV_CPERR` and follow > +normal course of signal delivery. > -- > 2.43.2 >