From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7B0C25B10 for ; Mon, 29 Apr 2024 20:26:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D01A26B009D; Mon, 29 Apr 2024 16:26:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB15C6B009E; Mon, 29 Apr 2024 16:26:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9F906B00A0; Mon, 29 Apr 2024 16:26:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9D99A6B009D for ; Mon, 29 Apr 2024 16:26:44 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4552540382 for ; Mon, 29 Apr 2024 20:26:44 +0000 (UTC) X-FDA: 82063702728.18.268A689 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id AC76220006 for ; Mon, 29 Apr 2024 20:26:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kZEHtgTt; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714422402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XElX0lvIknbzU1NDM+bexuVd/PeN5erbXNf5T0HVgR0=; b=tukXDXgywwFxTQYV21fPPbtD3x1V6p58FHYHeZViuwNjozpPulRqZ6YR+hvbNfSuv0OGgJ BWNi/crkeTmhPo+GivWe9BE9SnOELnC0r1vuxYeJvRjqdxpgQxzw7r+zTraaZaYPuFtzhT 87K1OMHBs+48G5GvPaAe+IFx/kJ5OwY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714422402; a=rsa-sha256; cv=none; b=HgEjlk5+aHIxfqKjNJlyE2xo0+ghEPB2QZ/kADvYNSKXh+E1vIXZ3XZB5F/diHc7fSpgeS 4M+QX753VHyFe6C2Ptx0dhpqfaTfDn3Q9H/v9EWjQ1GADqedA8Kvlz5KYE3v2KaaWClCGJ PDZFzn8tTlZjRSr1mVnExBpDD4aQ7oo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kZEHtgTt; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XElX0lvIknbzU1NDM+bexuVd/PeN5erbXNf5T0HVgR0=; b=kZEHtgTtATtVM7PAa6DPuem5Qs A1s2t7aJxmzFsYPCNADQLan2N8aOxgW6ra1ZK7K74lVVy0UUCQ5DqB/sIBFziUhBWjYmJ5XAm43e9 zrqfI5C0ONWscynumaTB5MOl7/zquJgdbtSwoSN8Zm1pVeNTorZsN1q1AZdzJMwWwA/TSRrYxw6hW KwpfxYh76/u3y0U4EzpeJHi78OPrk2R22ZFe4gnnJupQEdwPu7Fn1u8MEEviDBJiGmvULVTEdQS0l bZyLP5pI4ro16wfeBB2cJqkWzCIEy4nqiKrhaw1P3kP0yc+zHsV2abJMSxp6TLhiM9WvhV+1nd9Vp IzMWksWw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1XZy-0000000DGF8-2VzG; Mon, 29 Apr 2024 20:26:26 +0000 Date: Mon, 29 Apr 2024 21:26:26 +0100 From: Matthew Wilcox To: Steven French Cc: Kairui Song , "linux-mm@kvack.org" , Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Namjae Jeon , "Paulo Alcantara (SUSE)" , Shyam Prasad , Bharath S M Subject: Re: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file_offset Message-ID: References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429190500.30979-6-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AC76220006 X-Stat-Signature: 6k85zu4w95kbtb14ib6hg4ae9o53dwaa X-Rspam-User: X-HE-Tag: 1714422400-759012 X-HE-Meta: U2FsdGVkX1/I53y7q/lqvNPpG8qhHFf9PG4CazDCOaVo7Mcl8H3kIK5inGLy9bp/NvEVFw8x+tv+r/m+RO9MU2TactsAG9AkNQGogkCSn37w6gzjm4owEc3gxypf+Y/mpvnkXpusopXWzipW31RWjt/x+6MboLceiQ1G6YgzBouV4zcPQoo6Ohaa6Ytw5P7EZZyITmvXpd6K3Wyx+S8fSO1nihtGLq3AzP43FWIMT4mYm/XhbI3eT6c+7gTZSriW7D9KWTRvUX/Um3/t9fVbb+e48+dlg9G7uN6UwMIFdCG+BQEWRb22xErQM0G2ewjb9TYsD4M2SZ0SuGJ58VMkmHTsusFrLO8IHethuAxXKVymBzNpzQZEwKmad/+fY4r5RY0yxsoJoaDisADHJdqgXYpmGWfm/qfxfvQkxEzRvMoKlBeTRTxm88vgvg6sFtta+5MuUc0CQ1hHatTd4BohC78WxaqIOFkPO3ZzVWU7YG8lxYeyv73WEyrn7kQ0Af4v2cLqTw/uCgm+HaNThEUPJIU/LJbIzkiS+S+BKxkTB98gqT4z7Hfl18iQAGSGbcB7CCg/TTY6hYid/LYTAoUtD1QynRLsmeWfhGrGhcTgnyiU6cuEDG9PlvwNf75ocrD7sMQQNx4ALqD0GMTyiHLJsf/gm/N8X+lMMDIhkk6pJCnwLur7b7cVyTYDxXX1qzU4e4v7SfdWnjXxW82HJM5RZds64b0awjciguLNiH7Tjf6HwZUeLBL0RKx87bOrHGUPAn+Mfy9FmXOCrX+7Y5n/lprGIfqreKgn/dfS1v0Jx7nNjiMAtwGg+9eAZ6Ju2itM5WvJtH++w4IpoX5T7CnJKNqLLagUt8byCjH2UZzDY1/xhpkOMMDXfw7pyfRg2Dq8xdSgdjOm9rhDSSmDOGn7KlCoa4mjjkka5u3elyw8gW3Kmj+xxfeU7Md+wRaJ9sU0DlDSdLzOUo6OazzGkwb ADGlhqAw Q/tiOxtWpI4NbOaPShY3/xGgZrcSDI9ZzSsYP/hBt+ZoE0pz0MmPsZ2tKPL7gU9DAWeXXxOQ55YDmwad2XxGj4lZNYTgl9yQvJ7GUAd945b+c8mInuDmzTIJGmEmRUQ/wN4VOXB4ckdlo/Fw1pAuSjy5tPvASGarv1IkUIPcFdPR8BLUWFWEnmjpbIb1ydtJ45EU79zWE3ByFHrKEuDiI4bJTC65r0CaNSLwS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 08:19:31PM +0000, Steven French wrote: > Wouldn't this make it harder to fix the regression when swap file support was temporarily removed from cifs.ko (due to the folio migration)? I was hoping to come back to fixing swapfile support for cifs.ko in 6.10-rc (which used to pass the various xfstests for this but code got removed with folios/netfs changes). It was neither the folio conversion nor the netfs conversion which removed the claim of swap support from cifs, but NeilBrown's introduction of ->swap_rw. In commit e1209d3a7a67 he claims that Only two filesystems set SWP_FS_OPS: - cifs sets the flag, but ->direct_IO always fails so swap cannot work. - nfs sets the flag, but ->direct_IO calls generic_write_checks() which has failed on swap files for several releases. As I recall the xfstests only checked that swapon/swapoff works; they don't actually test that writing to swap and reading back from it work.