From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEBFC10F1A for ; Wed, 1 May 2024 07:56:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 904FC6B0098; Wed, 1 May 2024 03:56:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D7B6B0099; Wed, 1 May 2024 03:56:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 708BC6B009A; Wed, 1 May 2024 03:56:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D4266B0098 for ; Wed, 1 May 2024 03:56:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8DB151C0D92 for ; Wed, 1 May 2024 07:56:18 +0000 (UTC) X-FDA: 82069069236.15.59E7F76 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 6A525C000A for ; Wed, 1 May 2024 07:56:15 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="J/y3JC+u"; spf=none (imf10.hostedemail.com: domain of BATV+011d7bbbc156b7093f8d+7556+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+011d7bbbc156b7093f8d+7556+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714550177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kI1xPooe0vRm8yuP/wEpOQOaMdpVY3Q57qzI2ng2xDE=; b=zoqbmvKaMnG49nAIZTH96B7NlHFZT8itsdDORbcLt/XoXdD22szINCmuf+xNbQnVR09gGh 1o3bY7FHVMecZLeSOH39wzZ3FLiLwIHM+m6IIxATjvFCMVa5wMpFky6zAd3Doi0zy/OXXX qQJjaapld7fuxIrihGfqRm4PF2ak97U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="J/y3JC+u"; spf=none (imf10.hostedemail.com: domain of BATV+011d7bbbc156b7093f8d+7556+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+011d7bbbc156b7093f8d+7556+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714550177; a=rsa-sha256; cv=none; b=Bvu8ygDRjfhXSGx/h5OSWJSIBm9hYbqWB3q3AXX7Y5ChJveP9hlrzfq4F+7yQ5SZDtrtFe Tm8/vnwTw5m4e3L4mVkna8MlJPZHg2tbESlD2SbnG7WI7hkD2Q36C5A5FFLRCe35dfX5b4 uYsAYQlRNIrNBId9eid7YhkDsbySN7g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kI1xPooe0vRm8yuP/wEpOQOaMdpVY3Q57qzI2ng2xDE=; b=J/y3JC+uNHN7m7SMPgVdFJKt/c 57BHimAAIRpRkne6SQfk+jKcX4mPvyu+LfsDNQBTgUkqHf2SQqQhIEZZSwdHTbdpMWkgT/11ht9hB d9m9qhH1gfB1Rjya9ovhLAxOneF5XWWvwMe1JtsmLEOLrNv62FaC8jPwn5YX1WihIy3V1Lgbzon06 idEKewzYL9XzxDeJg9V3m6Z2X5FxOy2xFLfj804/dqlmiDn70cjG0jOEAbGHd2zAV2O6w6R1Y2gFI qP2xH3szsl1g/rZd8JiWnJwrdS0TQeZNLg7D6Cv94PpdlQts339B/PpAS/WrgzZi4eSwWsXKkloBt e9AXXIDQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s24oe-00000008nyg-0IBv; Wed, 01 May 2024 07:55:48 +0000 Date: Wed, 1 May 2024 00:55:48 -0700 From: Christoph Hellwig To: David Wei Cc: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Amritha Nambiar , Maciej Fijalkowski , Alexander Mikhalitsyn , Kaiyuan Zhang , Christian Brauner , Simon Horman , David Howells , Florian Westphal , Yunsheng Lin , Kuniyuki Iwashima , Jens Axboe , Arseniy Krasnov , Aleksander Lobakin , Michael Lass , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Richard Gobert , Sridhar Samudrala , Xuan Zhuo , Johannes Berg , Abel Wu , Breno Leitao , Pavel Begunkov , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support Message-ID: References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-8-almasrymina@google.com> <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 6A525C000A X-Rspamd-Server: rspam06 X-Stat-Signature: c154sozaszwsj87qzusnnnc7jdw19hnw X-HE-Tag: 1714550175-131388 X-HE-Meta: U2FsdGVkX18LnJi2UOWlmDxJKPLK9bs7jOWmIxFgdNzKNQ+zDWgEmWWdzOsERFE1PgeKzV+LrnQWx5oPXVvC8eHtEVlUBd4GMhR9qWHjZipMVMVaj230XpP0xfPAGILr4BUQ3LgrQK6g5WGSQNKw7btD/H00sf3kh59rlx+8S78gnJswiMyrR8TOa2Vrd5+TtrSdyAo9ddNRV+mjFnpX7RykjX4BYLwuDXyu+dXRYiU9N9j1mHee+950LvE3KBxXIi1XivQG9sOE9TlkIaze1jTE4P6VYgK4OQygq1G0f+rqSPJup2XE1B9UKx3lbKCpVbaXK8kx04iLSGscgNQBzQUqLEYRXGw5vTh7Qx3OoSJ63BwAACS67VI0FkeBDrR/ZJ6Gir2JfSBq3vGRtoWPPbK7Qr0noJWL3XrEylchWk7vkzvbaTlE6S7FU6tR8ciPCJKljV2Bho7wBnFQsNtOChL+7WVILJfc8ueTJGgYwLADqpc9WpTLgMzukOD4Idvor7PvHIaVl79OEvmP+6AUqTpfn58IV/zp0gC6zDs8GjpqGCWcKnTWtVjjf4NquVQuqsYEUpCvnGiWde91FSRG65KNJrveMga1ggNsOrGL8vToUrbmxUncm+OcXM+IWpx2g6h+rM1ZnAw3WFt/xncSGldv3rYg6t+NZna15kMpRRcjdK1QCl6BPQvWyczI41RHvyv1xOzu4UPElbN+avtZNWhLFWH8ewd5HISch5KKymIscP4/xPWaLyJJouMjG9TO+TZXn3gabZUeeWxxk2v6IgDPt23cMcICo5maICogYCHws5e9T+h55FzRRJa4G9lQKqhiPYTM0MOIBLpF0BlmZbt66GQ6EONs2GnCJPqzPvmNYGisXqa2OvVu8tYBKF2FH1O2nnSWG/K7NngUhzYU/Zz8h/9bCBhGPBPssyvYF90vs9sAYfIMUWbu/lPb7Is7lGfDqTuH8N5BQFq93U0 Rt1aLYrl E9agxvvLvF4PnsssnLTVI+STUdxg3ruAdOQqZIG23Uoqoa2vWDyYEQCLtm0DeLDa2JDh9IITQIwBpxqIpOBwn4zaiOAMfW1EazvidDWokvQtTlQZ8CEI1DLdyNVWxXxg6SlcYOo32avUEW8NHLJFTtIKM5Jsv53XNjiCbtlncs4cPDlZDaNlWvkcn/3V5LAqrE1H8eVQc4THD3NjLpen6bmVnE1e09By33090ayhyvNcMOso= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 05:17:52PM -0700, David Wei wrote: > On 2024-04-02 5:20 pm, Mina Almasry wrote: > > @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) > > */ > > typedef unsigned long __bitwise netmem_ref; > > > > +static inline bool netmem_is_net_iov(const netmem_ref netmem) > > +{ > > +#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER) > > I am guessing you added this to try and speed up the fast path? It's > overly restrictive for us since we do not need dmabuf necessarily. I > spent a bit too much time wondering why things aren't working only to > find this :( So what else do you need? I was assured last round that nothing but dmabuf and potentially the huge page case (that really just is the page provider) would get added. > ---end quoted text---