From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91580C4345F for ; Wed, 1 May 2024 04:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1DBE6B0082; Wed, 1 May 2024 00:14:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCDBE6B0083; Wed, 1 May 2024 00:14:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD2C6B0085; Wed, 1 May 2024 00:14:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C9876B0082 for ; Wed, 1 May 2024 00:14:14 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 390214030F for ; Wed, 1 May 2024 04:14:14 +0000 (UTC) X-FDA: 82068509628.16.9B41B51 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 99A5D1A0009 for ; Wed, 1 May 2024 04:14:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hMyozbQi; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714536852; a=rsa-sha256; cv=none; b=hU3xUDajGA0v/1WwYl0wVOzOqYXJJ/8IrpwVBDsIr2SfRXh3yMVlA9umZMytw7v0jE1kdH eyAj+qQhKWgFcULUkofNOse9ambrZCXVNQIpOB9TPSLRk0+uWpPZ5iFEROm0XZEG1061rE yM4ZtFEqHBX4U3yr1zl4bK/xkmRR1dE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hMyozbQi; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714536852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HVf+4ZQ4Imh+RkWB6AT2WtZQ623w3oYQq+TISB4ThZM=; b=3+ow1WksvF/kSURTNPswHMG46T4URGloGImDS3NMdAGv3S6RdIbAI2tjj0PBaJ2loXKm6/ pmTa196qjFt1AJMxKa7rT3QngdcBxTrVHM2/Uos6iHAGiPJ7Ft48itu5G/FegkVtxlWSYH LaZQE03vu0juDB6F6z6Di92BaUm7LU8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HVf+4ZQ4Imh+RkWB6AT2WtZQ623w3oYQq+TISB4ThZM=; b=hMyozbQiEMJ6TFFO2IInPbCVA6 H1sabx9aEHhdO0qvCKGOlCb9+l6cq1jKHRe/vtYa8J5usz+YcioXOwKtO1YlEaFrOPFUd6zEj4zNE 3eJxjAoRMzv8e/9YPQdsBxnvH/MXahvY5mvBHgr7+lTCnLLjrVRtilQ/9/8SGJclW2v2v0oYMmef6 zhNv1S1abnxt0ClpfEAA7IYU5/9gWVPVj/LwKKnSmwUwmONlelDjLKXm9OeuqhFaR4YeBXM9EoWpE Ps7a1XRNnuATcSHNvQwz4CZvk90JQUVeprpv7BfQpMa1CtkgDMXbJLjq0Iu6vVzXbnOBkNHqFLYWm n1DqebJA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s21Lz-0000000G9qX-2e7R; Wed, 01 May 2024 04:13:59 +0000 Date: Wed, 1 May 2024 05:13:59 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: Zi Yan , Andrew Morton , Vlastimil Babka , Sean Christopherson , "Pankaj Raghav (Samsung)" , djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 05/11] mm: do not split a folio if it has minimum folio order requirement Message-ID: References: <20240425113746.335530-6-kernel@pankajraghav.com> <6799F341-9E37-4F3E-B0D0-B5B2138A5F5F@nvidia.com> <202988BE-58D1-4D21-BF7F-9AECDC178D2A@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: kshcxj9xu8itwhrrjmyoheqeo5j884yh X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 99A5D1A0009 X-HE-Tag: 1714536851-468933 X-HE-Meta: U2FsdGVkX18I8DKH+grM3BjvQoLvnlHR25SQtdkXlJ8jZDf4L95kmD8zm5sYefO5aGZ0ztWVRbIRWd7VHNTFndaDq4ojts3sSs7++13Tiumwy+w2HNJQzNEUp0cYouWzywy/EghQCL/3sE5ZiVN0XRNLxT54kdkeX7i9I4mQ/I0Go78PcvjS7tSJRx5yg8HjBuqoiMQL8TVayj1rP0WWXoEqylDxsW1k77lfh43sR+jmwcdCw39C++ir9QqwxROHoVI0nVkK3yp71X29ed5XfTfu28MXQQAyhIS/qxrYl6M7KSYHkdt88gGVJmlWVYVI/xAll8w3CW2zhb9S5YdoELPw66EZR/xG1Y0PqhepVHbW18inKG7tdGRn6+jQGb0gjD62YWL4dHGKDYmlkCvYvdN/gdIQwKnP0cToganNa4QMulT645QsJUzzmY+6+456m3VaJZR9bhCgV9dgl8goBa9pI8UKxvNW/hSSpV/HfTc2UZW2JiQWA8bnwUSmJIRqBt3rjCsjH59vmtmANAa/TZtKzrGbyqxwGP7c1aOMfZdMQjSGhiHRsxhtBDTFld+aWg8xQh4RULKvCOMLgYSxm8eFqvk5cwcE3QTnQcSIOXcBM4YWT2xhkooq+yCNOHFd4PT+ncH9a0JNf8tE9+lTx7W6qSXbfJv6rniiS4Vy0FqNOsWTzuOZdHrTrhENJhnh85RQ0ROQSUGrlhJyRby3RMkj18VzyKnKmj/vQsQWPF2Z0LXtyZvpHCeMTxmYw9M1DoCjlyNSb3UZSguofkL/uYIsFTDs30q4R16J0JJRybvsD/oUYsNei5yMf0GI3TgG8v3LaDQ6wzQfUCn6SOLTbzme87ULK9L5wK9n+LMys3WWjZaVCFqDghaQdPBjlMlZ1zSiDoqcJsOPkjqUjC/OgtLhjqROYWFRs6JJhUMUi/GR+dqjL4p3ihYYPgWXcGanXyT6yT6+gGwWcDMxFV1 36SGM5+U +hCI9phS4uTmjV1H0XTrd3Tb7HDlmWnZ8Ep/hnI6t41z4RBEBIxIiCpCRUd/q3CYfuvujaNsaET0p6O+QFnP5OshOVXjpbM5tPCIH9KUSaJ78/s3sU67cRIyanK639lVOrYyS+pN622IfXLI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 12:27:04PM -0700, Luis Chamberlain wrote: > 2a:* 8b 43 34 mov 0x34(%rbx),%eax <-- trapping instruction > RBX: 0000000000000002 RCX: 0000000000018000 Thanks, got it. I'll send a patch in the morning, but I know exactly what the problem is. You're seeing sibling entries tagged as dirty. That shouldn't happen; we should only see folios tagged as dirty. The bug is in node_set_marks() which calls node_mark_all(). This works fine when splitting to order 0, but we should only mark the first entry of each order. eg if we split to order 3, we should tag slots 0, 8, 16, 24, .., 56.