From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 895A8C4345F for ; Wed, 1 May 2024 08:46:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A61D6B008A; Wed, 1 May 2024 04:46:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02EC46B008C; Wed, 1 May 2024 04:46:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E11C26B0092; Wed, 1 May 2024 04:46:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BEAD86B008A for ; Wed, 1 May 2024 04:46:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 53748160619 for ; Wed, 1 May 2024 08:46:14 +0000 (UTC) X-FDA: 82069195068.25.9D40617 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id 29A724001D for ; Wed, 1 May 2024 08:46:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FfhMrQ28; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714553172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nAP9/o3K7WsFg0Sljaej4SwFRcxI4yax7D2aEpEbrJ0=; b=nE3TPXoSdcIR7473fjNWuBH+Ux6eT4QcgLsPs7B5xVBoAdwF4x4KUFGc/JqQWg8tY+UwkS bwKbYEw1VaxDfJoss93WONu+ZhvFSi+3PJg74OK4rnxryhFBwDOpt/PBWduIf1AH0ei/gZ 5f2y8eS/XrXtx8wyK1bzPmFGdgVrb2Q= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FfhMrQ28; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714553172; a=rsa-sha256; cv=none; b=pmeI9/WFK7qL3d0TDUJzadm/k67/s92c21UaJlx55/hE8pALl5/W6m8tZWiOVrkM7eQqyO F26/ZVQTKlmNZa8hNxShU6uXZAMqRCXop5eJGpsyFiOtGNmQ+T74g3TY3jW+7ep9+n3bmN fJ3X9LpSVA4AN9IJmPJMAsWMqt3CuJ4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 96074CE10C5; Wed, 1 May 2024 08:46:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61F02C113CC; Wed, 1 May 2024 08:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714553167; bh=Pcg9z74ZETPo1dOJZX4qXQPzqqSneozwmYUxguKBkss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FfhMrQ284qZLQJlA00MZM86P5gxpGqIGKtOjDIdjJlrHnSBPbzKS2/+D4gLGgdILk zOhryvdDs++dQSltzz9xLapANrq7r7G+dFs21mljeHCY+glqBXf8wVjIYI9q3wOoOV xJvQ04pmFTVkUcG5K4MOt03eNqWTv8ZhoH7H4hujLbYDp26a0jNZJLVQd5NV13Lkkl ekFR8mag1GlIMG2ROF1aHmH5poQfPtrwpfWUf5eSQ61e/IvyhKKE+T/zH4wOsC4pEW R2gdAPqAsscCDSxuzMbw/H+QCAfZimznoK71htZsdE3RniQNHEUdDvzvYivSVg0+Cf VuXCS3hE0YlqA== Date: Wed, 1 May 2024 11:44:42 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [Patch v2 2/8] memblock tests: add memblock_reserve_many_may_conflict_check() Message-ID: References: <20240425071929.18004-1-richard.weiyang@gmail.com> <20240425071929.18004-3-richard.weiyang@gmail.com> <20240430014905.p2qlmjilkampka4c@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430014905.p2qlmjilkampka4c@master> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 29A724001D X-Stat-Signature: 1cy6wet3i6mgey9f6jdwbw4ytwb9dzxj X-HE-Tag: 1714553171-991125 X-HE-Meta: U2FsdGVkX1+akUq/sp4yJ5d8tVjKrCffaNcYYBk0olZkT3I3RHxiMCr/QSqWA6psYMl+F+Pdyf3R0l5uX1X3QYG4IWkI4v+FsQcjacuvcQ9PelCQ3mnj1hHUpSK4FZNvCEsJt1sdEEEw592COqKX+MKaPYB5rzU2X+6N7iXmFkxJbie9+fyxRZ8DD+LwO4O15pTLQIc+NM8x6BKoJkaneLDn43qp5zUIwsAUUeIpCghxblxLU38QDLmDX+tC/4w7IjBH5MeUHnWLPaVidNWGZVnjynsXdMqyAdbEFYiQj2Eu+SDHVkQRQprVPxg9j3EgSTAEmb851C64QBHioKcjp4eWLp79Rjad6GSSbm4CkmjBtKuJkGEELIIrpdyEs9edgRjPsXu77hpXUO2hLgBznkm42VmVpbp11n/2zTLME3yAahcHOI8p6NtSEvVxbbL5rdVCMe4qIWikmEdaodOGsrrNC7DtfD6xPgj3pXa7bGBFPK7BE0W6l5VwyqRJ9uxc9hg0bcaLimI9Dz3VE5dpV1iP350mazDZfBBO83xAqOD0I5BeURXN7dMRQr8wvNbb5nO7LauJAsnFljoZvMZPhg6KmyW1jxamagNYUzMPkLQp0fLDccwh1ci1/PcCupd07mVw2VEw7bMyTtZbsrN98XnEIrC4YpI08zZh3FvnKgNUN19m4N/b2s/8QnVYoyB1a78MmdN1AKBDjbwR+GRwjcs7SQ9qJsIYSPTStvg/yavsDtlae0iEOT6k3ynYTKGWg9varJkFOaZ8hG62TR/YxGuRezZpzlbGI757U7pzvUmhFRXtYjM930EJ1D+TV2piSkkzzwTkNYjmGThV1c5oEz5wMj+rt0CUyMuTZiNWNmtBIYERNnMXzwZHgeBYyeAnlEUTWBC/0pBjb4a2Dv9ubXHxGcV3cIZLhSq2IcYGkZpnwFjpBw6LpDX4bB1FEo5p+22P172ErTKzW4FgEKq 08A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 01:49:05AM +0000, Wei Yang wrote: > On Sun, Apr 28, 2024 at 09:40:33AM +0300, Mike Rapoport wrote: > >On Thu, Apr 25, 2024 at 07:19:23AM +0000, Wei Yang wrote: > >> This may trigger the case fixed by commit 48c3b583bbdd ("mm/memblock: > >> fix overlapping allocation when doubling reserved array"). > >> > >> This is done by adding the 129th reserve region into memblock.memory. If > >> memblock_double_array() use this reserve region as new array, it fails. > >> > >> Signed-off-by: Wei Yang > >> --- > >> tools/testing/memblock/tests/basic_api.c | 123 +++++++++++++++++++++++ > >> tools/testing/memblock/tests/common.c | 4 +- > >> tools/testing/memblock/tests/common.h | 1 + > >> 3 files changed, 126 insertions(+), 2 deletions(-) > >> > >> diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c > >> index 1ae62272867a..748950e02589 100644 > >> --- a/tools/testing/memblock/tests/basic_api.c > >> +++ b/tools/testing/memblock/tests/basic_api.c > >> @@ -991,6 +991,128 @@ static int memblock_reserve_many_check(void) > >> return 0; > >> } > >> > >> +/* Keep the gap so these memory region will not be merged. */ > > > >The gap where? What regions should not be merged? > >Also please add a comment with the test description > > > >> +#define MEMORY_BASE_OFFSET(idx, offset) ((offset) + (MEM_SIZE * 2) * (idx)) > >> +static int memblock_reserve_many_may_conflict_check(void) > >> +{ > >> + int i, skip; > >> + void *orig_region; > >> + struct region r = { > >> + .base = SZ_16K, > >> + .size = SZ_16K, > >> + }; > >> + phys_addr_t new_reserved_regions_size; > >> + > >> + /* > >> + * 0 1 129 > >> + * +---+ +---+ +---+ > >> + * |32K| |32K| .. |32K| > >> + * +---+ +---+ +---+ > >> + * > >> + * Pre-allocate the range for 129 memory block + one range for double > >> + * memblock.reserved.regions at idx 0. > >> + * See commit 48c3b583bbdd ("mm/memblock: fix overlapping allocation > >> + * when doubling reserved array") > > > >Sorry, but I'm failing to parse it > > > > Sorry for missed this one. You mean how this case is triggered? > > Suppose current memblock looks like this: > > 0 1 > memblock.memory +---+ +---+ > |32K| |32K| > +---+ +---+ > > 0 2 128 > memblock.reserved+---+ +---+ +---+ > |32K| |32K| .. |32K| > +---+ +---+ +---+ > ^ > | > Now we want to reserve range 1 here. Since there are 128 blocks in > memblock.reserved, it will double array. Now memblock_double_array() will > "find" available range in memblock.memory. > > Since we set top down, it will find memblock.memory.regions[1]. This conflict > the range we want to reserve. Please include something like this explanation in the test description > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.