From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D13C4345F for ; Wed, 1 May 2024 17:19:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65396B0087; Wed, 1 May 2024 13:19:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EE276B0089; Wed, 1 May 2024 13:19:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8682C6B008A; Wed, 1 May 2024 13:19:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 66D6E6B0087 for ; Wed, 1 May 2024 13:19:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E05654062C for ; Wed, 1 May 2024 17:19:01 +0000 (UTC) X-FDA: 82070487282.05.6801516 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 05365100008 for ; Wed, 1 May 2024 17:18:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k/8+NsU6"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf14.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714583940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m07c5Fi/jiQW9GTxIy2Gh/ikvj0HKOu2QlszwrphLI0=; b=RX2evxtHFKNNSHMUdJNwvbdIMcMxDm0Wac64wvIxOxUbJqLnRpH3txWxbVVPdxVoyPKAJC X/4vyvcOdFzdNFUm2UdNq1BYQ6k+l2dK2vT9n8JRxwwIv4oPrkkjxQwB4Cs2T7Uf8IMfQQ 2Za91p1F5EyM4GyC8x9C1sm4Zf1vtNA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k/8+NsU6"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf14.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714583940; a=rsa-sha256; cv=none; b=KTlWJ+p4BX1hn7bEu8FM1p2nSFIsSQu7i2w34A3Zp6ppAiBDy3qsm+QYecE5eca2B3Y3En xf3nDEFJpl8F2RCsGgDIITwyaFC5+ibS8bI3J474CKIW9onMdJ4ybk3jTsnD6qpVMeD1H8 4buJgQ5GMIkcNNrBwDFYaHIxMNjqz10= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-6001399f22bso4856815a12.0 for ; Wed, 01 May 2024 10:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714583939; x=1715188739; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=m07c5Fi/jiQW9GTxIy2Gh/ikvj0HKOu2QlszwrphLI0=; b=k/8+NsU6Vg3WKGHes7bT8+JUf5X+U0mOIHw+riHqVhjGPdBNW/BB7ZW8E1Gh6ZDQXI hf/888KUdbrp5CXxK83wSS6aEu+9UMoEN/nUjWjcVINjWnwQh1wos5OSFEXa8OwOK5tl /XzDXhQhwzN9Khspp/QkrHRdZti4GB2wg+hu4z7QRhGkG5h1zNuWSHQOplEOgXvKnMy7 LA1Ef0NuxqF5R60XTRjDO9yyt1DLIEi1Z+w2cF35DPTdLuBtsy2PqidGva/jdBuOPTwe X4MM4WTZGMeHPC4UVMKyljP9LQPALuCSo3kRPgTNOwCtQ/TxlhAcdj6uBhDHVa+SuedO uQVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714583939; x=1715188739; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m07c5Fi/jiQW9GTxIy2Gh/ikvj0HKOu2QlszwrphLI0=; b=d25CaKCkay28rQ2vH3Uzb7saXB9QjTJ21s2ShtSablvxnGyB4HyMtjQA/euAcrh5x7 nzgb5OHKtAhmymOc/mDFfqh/XX6ZdkMBDaIpTaXrIO3j2o1IZm0quVUSHhENADpYMV3t cmrR1uJ6SEXyLSHWjBNxLnK6nBPDen4Icpvei5zx87vLhSLKp31kap5gD6NuaO+/vHag OZpPOOPpSoayCXyk3cqATFxJwc8DPes1ouzV2vh6k1ydHpztkacW5eHHoEB0KlSObihV 5XwyR5PECTf3Xy6pP5OPREeyOb4VrPu87bBnqTvCw/R1gAXifTbhbMpNUkEELo1eZXDp 1R0g== X-Forwarded-Encrypted: i=1; AJvYcCXmek+Sc82wCm9EZP6EfIaE09kNYdO3YwtUoRc1ghbf5jSjdWDFVxP8gtkH3PqdbKGj6/AJxgCVtZ6HsL0tCwKOAFc= X-Gm-Message-State: AOJu0YwJYii9ZETPc4G/jQp0I1GQ2FH98PR2oyBE8CBV0535kWJJ9fea 2u2BA8VQdCDxlvJEf2xk2Xcrb7iTdrWMuhnEn+MGwrL6gUy9rjON X-Google-Smtp-Source: AGHT+IEM3V8NcvdrAmWIJZjePi+DWealRmXF6lmrLSb3GFNx1agPl7w6QxPM1Kw8esx4uAxxYweJOw== X-Received: by 2002:a17:90b:602:b0:2b1:535f:c3dc with SMTP id gb2-20020a17090b060200b002b1535fc3dcmr3293351pjb.26.1714583938764; Wed, 01 May 2024 10:18:58 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id o9-20020a17090aac0900b002ad059491f6sm1572839pjq.5.2024.05.01.10.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 10:18:58 -0700 (PDT) Date: Wed, 1 May 2024 07:18:57 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] writeback: factor out wb_dirty_freerun to remove more repeated freerun code Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-8-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-8-shikemeng@huaweicloud.com> X-Stat-Signature: 4j48tsk71crok8xemwnxa33dud41bfcn X-Rspamd-Queue-Id: 05365100008 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714583939-425725 X-HE-Meta: U2FsdGVkX18Er+3oXKu+c7Jr8hq5JgqI0ZUPTEj+EZ964kIE/wuAASVvGCW90ivPKD7gv3IBZtyNNR6z4/NC53FO+/AHd7+8qvz5tK5wHp4z/b1VwaSNiHRG2yJtPQxLz9Ly9xe7+d69Kjv0Bs6V+gcS+V9SLsEZT7YyMbMYHs+s4iclJsmFnfvDQG3X0xRNebu15ndv5CAv8eArb+uxncg9kiJZRxzpMJvN2IhrbFpfutRcIRjJ3uhKFc/l1G/b+0EsyTtQAWVmH8BZ/5iOYY3PwLPSLt9e8+qzS9LE5+Z6+XcIXZbhKYXs42BVPnw9ngPePZSS9ZCU3+w2ndB5/OlYq8dANQwkG1hjEURmGMExQGu8rhnDrKeLwfdzEH7gaJ3y9M7bMFRZV1/nlePbrZERKnlA76vWQEOGQJBPb4AtG3aKOitmwoGUHUnhxWu5paokc02pP/7c0P/6zUsvExQCmVk6LHBrgtstOsHrcpMh+0gEy4gluDXrrTM6LOi8d1bX6/Ed3cgAGSBK8CB9px9xbIlFT/cKRyKhTwhuoR7NLtlOskzYbs9lEXeMp7ykXZGH/mua1eMlq8EdiMQpdX4PhCFCLYTrbeJVKMvouFyT2eYi2vJ7bZbRU1iFetIpA2yN3PWShe4uE3wBKjNc7xVXTdgyNenh5wLuxgXtzZS2qPpu0MrBeiNVt7PCn0s6B80kGr22l5r11TvDB+otM2zr0KvH2gBZYk+/PYzJUSRFDdqnqS/36IT7ukVFsjb0ifxnBC5mPj/wX3ysa1zIR5L9cGQPabXYJe9JuKX6E0cxLa1vj+6UQzYRyFqqDculUCN7MxbYcp5CbQDoOvnGhPiuHLvCrXeXvQM4KsJX0Fg8+bitbylbwGJCdpeATFBjc9T78hOkJHXlMpm8yYo7+0ZD6MAPq+o5QjUbsLntTDOPHP7yxa3xfQUXeN4NaRsbjmZSS7AQ9qraTZooWlx ubhpQLIv GQ00jzkVwsftbDae09DJCDOealvgU3vldQTorTEx/rJCh1FWB66vuZ91mgRHGLbr0h5roWVgLZbrCFcUrX21CN0E+J6iRzMXn+aEyKbXZ6BdyyfVIrw6rvZB4t5Z49BhMGizPLdtlduIZN6quuSd60l69rgPh5pFj1gQEHy8PS1Sh1DI3Kg8EsoqBKpzANZ8UCVn9gUcLuX9QzUWqbqZiEGaBjCFCyUFiCKaOGkyDy3PUi5LfNwvlt4LxDCb20KxoFilwLFkpaFm63LCku8SW5M92Pczc8H1MdJs3AhL9WyrnNNbjGKddD5763K8JYLt0XMGLZvYKXlwDhHznEh7/4kwNEkRMs2FMCUgAt01+5BLZ7W1qQHj6cIXV66MI5WaP8Mg/6P26ZQFu2F0JPlLw24rSbyvI+KFU0p5WDjPQimKRO9TxrvZ1Aqu0FvtbUhGj48b6ZdGdgmy7XXLEUjoJfc3CYXe5KbZ0LslFrxMDMTu8DjJ1VovU/ZXNJBBawB8Vw96boO8Fsg4NapiYdrhBCkaZ8o9F3hYan9iUi+eyagQVBfU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:47:35AM +0800, Kemeng Shi wrote: ... > +static void wb_dirty_freerun(struct dirty_throttle_control *dtc, > + bool strictlimit) > +{ ... > + /* > + * LOCAL_THROTTLE tasks must not be throttled when below the per-wb > + * freerun ceiling. > + */ > + if (!(current->flags & PF_LOCAL_THROTTLE)) > + return; Shouldn't this set free_run to true? Also, wouldn't it be better if these functions return bool instead of recording the result in dtc->freerun? Thanks. -- tejun