From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F81C4345F for ; Wed, 1 May 2024 17:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C9C06B0087; Wed, 1 May 2024 13:21:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07AA36B0089; Wed, 1 May 2024 13:21:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E83C16B008A; Wed, 1 May 2024 13:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB2D36B0087 for ; Wed, 1 May 2024 13:21:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D3E6160BA4 for ; Wed, 1 May 2024 17:21:51 +0000 (UTC) X-FDA: 82070494422.06.E5C0794 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 51B81C001D for ; Wed, 1 May 2024 17:21:49 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m87H5ixF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714584109; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LexDuQOmjtzlpv4qE2uqvocvD18bmhUjJZSZg5SoNA0=; b=IeXcBcvT1nZDjkHEQLnPije9LZKFqe6bZtw/mfcKxupZwvE7K2QyEQaTHQMDspB2W0b/2+ /ExQQMuxym3GX/oSyIuot3NQF7+g8ERpPMkerHSefw9zZIXHC3yWW863Ut1gFK1OlOwcGI LGhq+EMy1fzIp0e/dLDmsRzRFlzrWSo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714584109; a=rsa-sha256; cv=none; b=BamgI1zekJZoZDPIo2ZukD01qrgG46LUoXclDMNfbPdqOt0UaDTGXAXS9b4fQMR6oiIl19 nZFeogsjPeDW+ycuzSVV1JQzYC2Zt6O94T6eithjoAndU8ogpiBaqJx2uMT107vkZVNpkZ 17mTEIrKRtYRgiBbADJ/UWfzSRE7UUU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m87H5ixF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=htejun@gmail.com Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6ed112c64beso6486701b3a.1 for ; Wed, 01 May 2024 10:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714584108; x=1715188908; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=LexDuQOmjtzlpv4qE2uqvocvD18bmhUjJZSZg5SoNA0=; b=m87H5ixFcqQcbr9Rul3JEEt0op+onFj3r+rfZb4D2eY4eoRyYVHrf/7HsmfE/vQV33 OMLK3chw6HUNPwrug7sRj+f570QAn51Xqr+lPOc0Bn3PFw9WlVBHevQK2lHNf65hnPSZ dsrExJxQWqzYonsZUIUaP2ax3sEp8H3Gq98oIn2ZZGkrynOgUgdN5uJBt32et+Gc0PpF vIVZO/rKQCEmpNULJQiJIvDT+OB41TTV7yWIHXzbquYGrF8hVBHPSLaG8K/nQOa9e1c7 KM98IKB3NaPklLKcoAc20zqDPF0PONABMHiJ3JoFCuQ/XIABxCk9k32pmfgs1dP9RxSZ k9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714584108; x=1715188908; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LexDuQOmjtzlpv4qE2uqvocvD18bmhUjJZSZg5SoNA0=; b=cjhVQTQYGiG+Uq/gKL6yzowpknn5iQ361i31IaqLR1WijqDX+NUcHb1Dm2DFJCCAJP pbV5S/Jh2nK0bqQsmWZw7XodwfRChmjLOqGHUpnfQeHzH+vEe5oQgNS4oXkFeLdknxro QKKMq6tox+XOTwfAsDfvPsSrEFVJm+K7vSWf22OATMXeACBX6dczAglKog2OWrlY5ea4 U5607drmFpkvaY3Nl8H83ltoJhxvXyzh2sx1yZ6Ml6fJvtgYZs6ZiMHoMMZOxygw8951 Mrt/Nsfo3X+y6dTmI5vCvjJlhK/ppXCpzaw9+5uJ8wcWWJBkoJCqN/jT/OUUcrAY6ccH GTOg== X-Forwarded-Encrypted: i=1; AJvYcCV0wsr+sCiAJOAnc0xDfcibJP496tf8GUoc387jYYmOZjedHnbrMn6dGY2VlSZ+h6kWUgLt/x5dhTjCVvlnybEa+CM= X-Gm-Message-State: AOJu0Yx+V3QAkP3+rSSgPw0TGNcnzs99mVztVyuoKvdHYjIozcZtT+oH ZBorjWXBWAStCHQIh3q8gfYU8VPnFkPkkBbEUFLW34Rk/FJ6ymhO X-Google-Smtp-Source: AGHT+IHK/wLyV3K/QzXF9pqwZ6J6d0M+0hwoRFoG6aOfCbTX0amPvEOE/Fg6ieIZOTieO+jYYcvm7g== X-Received: by 2002:a05:6a20:6a12:b0:1af:35da:16 with SMTP id p18-20020a056a206a1200b001af35da0016mr3837422pzk.52.1714584108140; Wed, 01 May 2024 10:21:48 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id d20-20020a63d714000000b005dc36761ad1sm22843164pgg.33.2024.05.01.10.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 10:21:47 -0700 (PDT) Date: Wed, 1 May 2024 07:21:46 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/10] writeback: factor out balance_domain_limits to remove repeated code Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-9-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-9-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 51B81C001D X-Stat-Signature: ydjjx35sswexgn664tum9paqc7o3k8c3 X-Rspam-User: X-HE-Tag: 1714584109-718438 X-HE-Meta: U2FsdGVkX1/eMXzt56TI3/4VqNIiTT3Ls3nYdgxbvKcZCevngr9g+L7PJQ+ipNMUdqmfxy933PhVrh+XxgylhhmFr/pGXv+n0M+dGpCfzAqUXtP2eJHyAKNHa7mSs/NOXO1GaxeSQxNAWL2U7G5qCcsDrQv//dIm7nf6SE7gJw0rMqvBu8GxkaBGQ/NN0pEMEarG0DAqng7xzZyNAIJCJiCefgWljTnjPpxBYmlunBJ9WnM5hvkKrJtFb5U9ebJQLdYbFmjIZTxjlAUeTWPtQcoFXKd7UDg6JMxtzEWx2nmAQwbxuBrB7jyhzJ40kCb5Pc9Huwf4CDwXh+xSkTdEZm8qZQdfhCFURAuAJI37i8iiFnC7dfOKWCWacZNL9Fz8cPZsplmoQI5e/yPhIkyMysI+vYFxxHPtdfSFLX4WNXpx6Br0qBF5BAPzNq8LIZLWVhR/+dfr07iPlOvi3WBdyVlAqdE341+DslIibROZNrCvRJcpBIA8Dv8lz4QR8Wx/isCCaBB5A38qfnOBlS2INTwDJLsPQWzm1bTa+Yzh8Urbzu7HuZjLNqg5zZfoFcOx1gnzhJsNpYH21Hc3rkQK4SbzJVL0C4DgM8eGjtAOqdXIY9BRlkJcgQDrlTP9v5D5Dt4UR3Vyji+4vhqy8GDBpOIKXXQCNm9mZOh9YRi4ljJdZuYOxxDb7ZeVU1sJIwxPwcZlOz9MBu2whMuRU+pB2wJCpj/kYGBSgmaB+ZxJFAK8Z9sQ95/RG/jq/X1QoWJQxGzBxVHRsmoXeWuxy6Zonhj89nmKyv/32kfXIiGCShIIpzLOHGYVgyI1LmYeEM5/XAiTdZ4wmwOFtM4VObe/Rc6JeuDu8Cg7vOnqmfANo9Oll2SNZqOdRHzBQBOcDME2Ss2wIBspLOJdA7E46d2JoLz98bzAjJrZIjYjUaE4gvB8JNTAw42t3hJG/9T87mJTrzHuwKaag1niQxtHWMu Vro31beQ X408ONs8Gsl692tzw3cp0HV1u/VgkQLcI4s7mxe7lY86wdqBVUMNkvV6pxGZsmjFw2jV4UfJMm1uLPE0YYal/PkLFVpoHA0wDme0TfysXKtNgzcY89PUII+dalRtUKkzSgcD+X+k2EbSh+v5pmZVYKRB108tkGtqebGdwZRhsVt6A2vBwbsjem7bWq/pomjXsGMM++nlz5SzROwEGldETJbq9e0Cz+NY9wbRkz5v8Ebba0R4rsmJSg/cjS49MbvFj1rmFPX887JuRii+vwPIXuIP9lacLt0toaKv3dtK/Fwsrc0i7sC5IWlc2Pw4wA5RRsZlZXbuapsgIP3XGVLbpaEpsaWQWcVf5JmlQgvudA9Epd34cXZkb3gfQaGZKIF1OvYhs+7h/Q5Ce3dBFly2k8udQV+9kIEf1J81uvVwPvngaS7YogpXkciUmk1Yq6mtiEwHuGmo663mwMrUAHpScdUHcEGvN5FgsfqPwladEXrWQa3BmzC48U1jeTTKXpQA/Nj4ttE9H8hcJ7twX6KyGnU65tilV0yyztkuu0wk0nYBPJPpXEWsCECjYgzE5DhRWUo8jydbmlQVMi0vHLkj7saUBzmdcnMvaJ+h1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > @@ -1809,19 +1817,13 @@ static int balance_dirty_pages(struct bdi_writeback *wb, > > nr_dirty = global_node_page_state(NR_FILE_DIRTY); > > - domain_dirty_avail(gdtc, false); > - domain_dirty_limits(gdtc); > - domain_dirty_freerun(gdtc, strictlimit); > - > - if (mdtc) { > + balance_domain_limits(gdtc, strictlimit); > + if (mdtc) > /* > * If @wb belongs to !root memcg, repeat the same > * basic calculations for the memcg domain. > */ > - domain_dirty_avail(mdtc, false); > - domain_dirty_limits(mdtc); > - domain_dirty_freerun(mdtc, strictlimit); > - } > + balance_domain_limits(mdtc, strictlimit); Please keep the braces with the intervening comment. Other than that, Acked-by: Tejun Heo Thanks. -- tejun