From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAECC4345F for ; Wed, 1 May 2024 16:49:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0642E6B0088; Wed, 1 May 2024 12:49:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 013D96B0089; Wed, 1 May 2024 12:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1D366B008A; Wed, 1 May 2024 12:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C63A46B0088 for ; Wed, 1 May 2024 12:49:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 76F6F1C11C2 for ; Wed, 1 May 2024 16:49:58 +0000 (UTC) X-FDA: 82070414076.09.369AEEF Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf05.hostedemail.com (Postfix) with ESMTP id 998E1100018 for ; Wed, 1 May 2024 16:49:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GE/Saw3m"; spf=pass (imf05.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714582196; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jaeP7dJuldn1Q7npduL4hZfs1TrHxUU/CG5Z08/gr9Y=; b=pdF/hnp4kUoYaruutrmgzWz1f7OqHEDpMkIb8H1U2L8CrqvJxg0yczE9xsLXgNmKQ3BSS3 bKXxnTTfqyGKVG/S4stow/WXO6a85PICKmL/aE5SueRDj7zvxbz9zvEKG+JhNAquEqtd4j 365LiNGRdOArt+WOWXeFyRBkcR3Ny0Q= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GE/Saw3m"; spf=pass (imf05.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714582196; a=rsa-sha256; cv=none; b=wjPq9XmXVFJX830U6jtTM8ROmVmKe+5qDLjc5WUtsDv3BlP+4afL3tRjMKG22huoZEtySP +FYC2REuOqqkYbaWM2ba69R5npwF+LzV4qj5PJFo6vUExlZvQmuRaTpGjBpEoDPTiCBtCb e5NsfQQk3ogVv77VfRWoSNVU2PavPV0= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6edc61d0ff6so6980212b3a.2 for ; Wed, 01 May 2024 09:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714582195; x=1715186995; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=jaeP7dJuldn1Q7npduL4hZfs1TrHxUU/CG5Z08/gr9Y=; b=GE/Saw3m5NlruUlhySGba36Pjt53hBYjjkrHK8jxzNNSTOmwoFlIiHFyQG/JMEg6lo O39/zaZFFXGQwRDv63rJ4FV7qGZh/LVq+8FN2II78Wi/j+qznjkKEz8PiDV9fV4Z7I3v oFgAjuh7lqGaX+p9BxGRoluWJyvA/6DVzi2W4p8HeY0lFFyG88DTOFIG4CAHNHY+ByaO roJ5maj8r4rR6x6tzpzdN1zqPRO+QCAHHHyMN1ekxD4FRAY18Giw6mlDc5H2+Mob2N4g nEoN1QYNkU315ZYiLGMqtoglIxTL6J5q5G4JebCAsFuDpMF4hyvFCzNCzyIxuWcYOzVN lbEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714582195; x=1715186995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jaeP7dJuldn1Q7npduL4hZfs1TrHxUU/CG5Z08/gr9Y=; b=Va3NDmuJ+MCHBO7Rs+u2LpnsnE2sEE7XwVZ6YeaDPG7s/lY+DmByrAxXdj1KJTw9N1 H+0fLvtUTkWE4BePzfHbOF8mvNG4HsyUxwKfs8FawGTEtoUkq3et5mmiGF/jHhWWZ09/ aFnoz6LXvNpJrVqsQZqGlKuoeA9Q23NwVcXsIL2gHrb7sLfLCIjQQS9cAOOemoxrfl9u i4OPUJJBpCNd/fDZvo5qbEmWKvP+caHMjqhVknxKD9fIspLJk7HauADjY+hPQMqUmbBh +7jYF3lV/IdW4SB5yBlu4hrSaLmy7tqCSnlE1tLUo7kuJbFl56KBnVeXNxC+x0NF9haa WsFA== X-Forwarded-Encrypted: i=1; AJvYcCW5DU/eDhhrfUTi+trxRJuUxpOIP2w2gTet7x+g/wzptD5hg9+aHBofxhmzjiuiS/n7DoGOp7BpXyi7o1CSocrD51k= X-Gm-Message-State: AOJu0YxJYh4d76N8dZimpgAxYAvlDaKBdP3r2wAbu2DkiqSrpOcGlhdg ht/NRpgMQpLCoS69qouS539p78Flx2TEX1NDqdaKyaLERmpRxeOE X-Google-Smtp-Source: AGHT+IGeDYT2DJYIbJAa2HO9tmetQM+2yTUtEUc+vob+dYymJ2xDChd7qWmrjrkinux1yJOf1Iyc4w== X-Received: by 2002:a05:6a20:1013:b0:1a7:a86a:113a with SMTP id gs19-20020a056a20101300b001a7a86a113amr2732660pzc.6.1714582195362; Wed, 01 May 2024 09:49:55 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id r23-20020a632057000000b005f41617d80csm22381650pgm.10.2024.05.01.09.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:49:55 -0700 (PDT) Date: Wed, 1 May 2024 06:49:53 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] writeback: add general function domain_dirty_avail to calculate dirty and avail of domain Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-3-shikemeng@huaweicloud.com> X-Stat-Signature: roequqirc9beao99sahd6urmcofaqny8 X-Rspam-User: X-Rspamd-Queue-Id: 998E1100018 X-Rspamd-Server: rspam05 X-HE-Tag: 1714582196-341738 X-HE-Meta: U2FsdGVkX18iPIQGd/A6kH2KiAI+2GsP7Zmsy0/Awi+R/tjENdqHjJlNkchjpyvVClow/LDnkGj0sXD4PcsYiDEDZPGab/6DK4o2tuz6Yd5U+Bb0tt7LVExP61AcgvbYb5aq6/zvsIgdkvgAITtC7ATrMLcP5mownyZpwgVNeUEHSC3wb6pY9CXRRSZGOSp6ST3RWEpTw5ArPr8Rg83r8+Boswd3YwmOTVdgO7Y8Rh3ijV51+2pG4xz3c6okCDjj62tB5NM5QErVFv1IBw+RMvJya+MR1/QhKLIIpj8acFDlEwOs817LmXU81yR4yfse3t6wDz/42IBuWJjCA2uYFccbLzQbuVQFbLmOoClwMIe8C1C26KF61E1T0aoa/TUG5CFGvEMphCOKbYqvqFaP6pFdrrwugbR4DufkgD3mRGFzD2/WBYinRLB2GGU4BYGFALVykyF1O+23IPIcFcygEYaGVRseIkIWHHKM9qJogtiprqUfOlMPlt4zRYNIjppglS00RErkhItNx7U09/0w/PNu9vcyDVg0sD8DDkUcyqqYz25gk61VEYaucCdOvcefE0n8RmFbEyCwEaIOP2/sHh+gi3X60dkmDJBHOL6s0bbXKj6NILFZkvU3jDiodjl60o1ThRcpmm5tCpRGr5DwBUlqvya2N/MCc9z40u7MoaCwTIg2teamuBCsL2u67sCStR5EZATg9HvIKZ2mbtkpOtZz2Hv4umPqIfHAAB9fwF6YzM0mmeirshVGwgCLN+USiKs827JntYXlNsdvvF7J5shkS5nAAQzbegXuC6/oqxuqltLbft3sG2jonBgyhJXBGztgRBluaJPyiC7zExWeHANk2+UDxMziYoXjRX82vwfPdVxjsYzPApOMK+YQ4zX6otFit69oGS65uv3niX/JnoeTQhdnGnWVB/58lgCCdRLe/owV88YV1wSTCYHYcSEUqCZZGZ4b13AXeWA3ZM3 AgJMzz1h Tq3R8O68Tde+FArvNjQXeqeTXttioQzH/nAXNdPnelNizCgNVyv7A8GCBxfB4pnrwzD5fTcAF4TqB+8BwcAEQyTYOKXaHdyfMVLoe7ScO9GWJoiYIf8U3lHmp9zZKLO6tMw70e2UE41m4ydcNaLpEIBd/bgtR5oUokx3uMAXBf3d0kQGYxMvw/ngUJ2Po/amFu8wvtU5vXQdYl2JP+jrvqhky50W+yPGPvxBRYBGSJ811SbHpZq8B97uBi+sPy9wWZhmHAU1Nq7ACjuWJOS6FOx6GH5ezbQXbGyAJ/y5ay28TpALIqrN0L8hcc8BA5hcTomaLsqNjO9Hzqs5cQa4J15QnX2bkGNEqZYa5B5/N9Ve1a/WWcTedC33PVraZBQXTKcoDDcVN1N1JpRG+oL702X8iVmeFj8N7vdPr01OtYk/7Ka5I7AwAs0u0A80qC7RWdy3InkWsEdXJfrzV+FeoiwzPhNYHLKBLnCFTqTqg/JOgsjgGS3PtoqC63NwVbCYeSeW8JnJ5OHELw+y7DLryK8DZRJ+RJJBD0Atp2FDPxNWfAw0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Mon, Apr 29, 2024 at 11:47:30AM +0800, Kemeng Shi wrote: > +/* > + * Dirty background will ignore pages being written as we're trying to > + * decide whether to put more under writeback. > + */ > +static void domain_dirty_avail(struct dirty_throttle_control *dtc, bool bg) I wonder whether it'd be better if the bool arg is flipped to something like `bool include_writeback` so that it's clear what the difference is between the two. Also, do global_domain_dirty_avail() and wb_domain_dirty_avail() have to be separate functions? They seem trivial enough to include into the body of domain_dirty_avail(). Are they used directly elsewhere? > +{ > + struct dirty_throttle_control *gdtc = mdtc_gdtc(dtc); > + > + if (gdtc) I know this test is used elsewhere but it isn't the most intuitive. Would it make sense to add dtc_is_global() (or dtc_is_gdtc()) helper instead? > + wb_domain_dirty_avail(dtc, bg); > + else > + global_domain_dirty_avail(dtc, bg); > +} Thanks. -- tejun