From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA54C4345F for ; Thu, 2 May 2024 23:07:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A988E6B0095; Thu, 2 May 2024 19:07:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A48766B0096; Thu, 2 May 2024 19:07:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EA726B0098; Thu, 2 May 2024 19:07:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6568B6B0095 for ; Thu, 2 May 2024 19:07:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F0C198026A for ; Thu, 2 May 2024 23:07:26 +0000 (UTC) X-FDA: 82074994092.23.665D373 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 85C5F40013 for ; Thu, 2 May 2024 23:07:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Lb7IPdzU; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714691245; a=rsa-sha256; cv=none; b=1fbPrutQcObiGRI5MFskrd/x4d6jMtZHQhbCVE4Yz5CxkhinibepRWnnYrN1vQY5QqD1xJ ID2gMlk52PxfQ23yDaCdzM628veZmxeYG682zlFUYSOvQsVD7HAwwrh1Yjui8ITbB8t//2 8Ebk1HxLoqSrvRztn9oeoqRkQX72wJY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Lb7IPdzU; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714691245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ggldfb+SnGyHf9Y0PSAxHLGif2nJQj+Ec7fEJVGb75o=; b=Y7rPBEXRPMMHgv29lFxu8Ukpf4vuM4LXFKegLo2cbQvo57SnV03DCkHxPH65Y/qpfhVOjS 1cS9C1OLzR6P+9j1m3Sm+V2klMQ0Ur0S6YSF17J7VJtd/RkldE0jv5+IPNB3v6vClcCkd0 p8qi3KeEKifypsCwkgPuJBfzcIQxLxE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ggldfb+SnGyHf9Y0PSAxHLGif2nJQj+Ec7fEJVGb75o=; b=Lb7IPdzUBf5fxuHKvzI9o6uLSf RnddZfhFt7Wuoo+yO08qYqKgdD9hHqwCFkcXYKBIB+4X+0JdnnJtpsqFaMT0wnnv6M9IkA/gRz3dO CfH7Qf8EWypK6L/TUeZ0Du7foM4ykeRc3vnVXR/Q8UVZHuQgHqu0NqfWmBjcCr8SvcyvuW4Mkqc28 xofGGkYwiKsmCUnJHJzx95tE5MA+DQjtoUN9fqejczoSwHyZ+Ikhq12KowJl3pBhgYGyiVQ4bqUvD yp2jYj6J2Re5TMWfN03xgZqm/nkb4xW8EoAJALaAt82gNWBFuA9GWVogzaVAH0hDHMU3YDgdcYW0+ OkmsCkaw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2fW5-0000000ECkp-3WzA; Thu, 02 May 2024 23:07:05 +0000 Date: Thu, 2 May 2024 16:07:05 -0700 From: Luis Chamberlain To: Liviu Dudau Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 00/16] mm: jit/text allocator Message-ID: References: <20240429121620.1186447-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: whew1k6wh8em6kc7pp9ywq6ccnk8u1qa X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 85C5F40013 X-HE-Tag: 1714691244-560054 X-HE-Meta: U2FsdGVkX1/Adyl21Vv+1vtJT6VB4Ce9lPbK4yuMaggF8h2JCxppS7hD6s7MhNzhNueG9pd2L/h42Rc6TKPf+kUh1npGoTg7CoFfWHJDg3XgO/iRxQJiwU3w82VY+Qk3KSDoUJHIYiVgFpx7+0FRx0MY8ywTs/V4tZtr10qZN8/Fwil4BjU7SdIjl7sOPrqoUpAjqR3Vsbe1QOvv0Aecnywb4De6fgxOEayNXTNkuWxw3jyZ085xtyNzSyrFFt7y20Z3o+9Sir61/ojJU2mOE1ojINcg5EabZR/4dPzuAnJK1DhsIe3VvNlk3JcoaeZaZjGny63J4IeXeR3GGyeKbznxXuNBIctlb8aceYU/8Ija4SpCxC+W4m5jI59VliUwNVtvEdyLR5l/eeHbAm3af9qqmiIRnIjaqA/I3wGHmtkpxIEY4/OgEUtkh0EuA9oi1ADzQJ3vL70cEpCj13E9XBImv/ajVd+fGsqrP0CwSN8dSsujwWX0wtFF0CIB5EiBaQGITq6CpCnFTDxTSfbe+G5V+Hg4N4HzH5HpXsGZ5oTIMIjwy3+YJqaAUytOLGGHwDRjvWA0Za8cL5haCCI88G3EewqnOt/2Lp2FKW+3ETXwBD350L6WFMS2+aNtH4k4ulr8UqNgeOQdXAr+b6tK1wOsVSSDK8NFi5QeT8uIgXvcIR9FNYG0OdkuYjuMhoC5aHrkSGIl8YFSNJbRc1M9GzVWoL2f5Fr4sED7xnsBmVMo1fQDpfoYyZwdT1J+X7FMVW0Emp18DCu2mq2RrlmofqSMy9oY8LLLjYpAiL5FVi8ZBumSvwu5vbCUMhkfHbbODCUmWo80ce192vMxQ9P5ISAgI1F1efKBCeGWYrzMX0z+3VP8WMk0CLOjDKCMC3+mnoYT2/BfAN+ng50RltItqPUydMszWHUfYP0wQkZ6s5autUbQFsdntVqIXl3rw6FfjaOB4EcUHZTvt9ZMHR+ NICkTCFN KD2BZtsCdbOsB/Kl6kJPpYYYH0Hlyqa54sETnG8rGeyRophXgMQKmFpYOghcVxvupW6GReKRnhURV6SRingX93/IMwO+xQqTtJppiaD58HkL+XgtzHKk5onHTXlLM6Boq8w/DYGmOtOanDFAyvFw7ILHjBAsEA8VlPEbn31TNbQCCCCK7UUNK6oTOAqkNxZbEx6gAlulWFxkboC7sSrE0ngE7dUZkP3em6msaYNAqAR5+Ph1QUR8Au8RxMriQbxl0yP1NxEWzdM3vIEpd7Iqnkf8rxFVY3578TAqJvWbP13lb1+9lcYRsFTq/H/SBgnQGcFclR5VrejuPT/zDiargOV0DviSjP4wcbyDoKJ/KwjRg6ca7hz3HGaNOXl05lRl6oN1I1AUUoyF/XcnKxuEVLldYtlv4i1gitPhahL3CAWAncwhYPa+XosEqWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 11:50:36PM +0100, Liviu Dudau wrote: > On Mon, Apr 29, 2024 at 09:29:20AM -0700, Luis Chamberlain wrote: > > On Mon, Apr 29, 2024 at 03:16:04PM +0300, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > > > Hi, > > > > > > The patches are also available in git: > > > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=execmem/v7 > > > > > > v7 changes: > > > * define MODULE_{VADDR,END} for riscv32 to fix the build and avoid > > > #ifdefs in a function body > > > * add Acks, thanks everybody > > > > Thanks, I've pushed this to modules-next for further exposure / testing. > > Given the status of testing so far with prior revisions, in that only a > > few issues were found and that those were fixed, and the status of > > reviews, this just might be ripe for v6.10. > > Looks like there is still some work needed. I've picked up next-20240501 > and on arch/mips with CONFIG_MODULE_COMPRESS_XZ=y and CONFIG_MODULE_DECOMPRESS=y > I fail to load any module: > > # modprobe rfkill > [11746.539090] Invalid ELF header magic: != ELF > [11746.587149] execmem: unable to allocate memory > modprobe: can't load module rfkill (kernel/net/rfkill/rfkill.ko.xz): Out of memory > > The (hopefully) relevant parts of my .config: Thanks for the report! Any chance we can get you to try a bisection? I think it should take 2-3 test boots. To help reduce scope you try modules-next: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next Then can you check by resetting your tree to commmit 3fbe6c2f820a76 (mm: introduce execmem_alloc() and execmem_free()"). I suspect that should boot, so your bad commit would be the tip 3c2c250cb3a5fbb ("bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of"). That gives us only a few commits to bisect: git log --oneline 3fbe6c2f820a76bc36d5546bda85832f57c8fce2.. 3c2c250cb3a5 (HEAD -> modules-next, korg/modules-next) bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of 11e8e65cce5c kprobes: remove dependency on CONFIG_MODULES e10cbc38697b powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropriate 4da3d38f24c5 x86/ftrace: enable dynamic ftrace without CONFIG_MODULES 13ae3d74ee70 arch: make execmem setup available regardless of CONFIG_MODULES 460bbbc70a47 powerpc: extend execmem_params for kprobes allocations e1a14069b5b4 arm64: extend execmem_info for generated code allocations 971e181c6585 riscv: extend execmem_params for generated code allocations 0fa276f26721 mm/execmem, arch: convert remaining overrides of module_alloc to execmem 022cef244287 mm/execmem, arch: convert simple overrides of module_alloc to execmem With 2-3 boots we should be to tell which is the bad commit. Luis