From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37C7C4345F for ; Fri, 3 May 2024 06:30:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 159906B0088; Fri, 3 May 2024 02:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E3FF6B0089; Fri, 3 May 2024 02:30:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC5B06B008A; Fri, 3 May 2024 02:30:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C62A16B0088 for ; Fri, 3 May 2024 02:30:11 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8CB1EA0DBD for ; Fri, 3 May 2024 06:30:11 +0000 (UTC) X-FDA: 82076109822.09.04DF623 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id DC0044000B for ; Fri, 3 May 2024 06:30:08 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bwAj/o4z"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714717809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UTurG+Lm/99RDvX2OjW9C995o0u9OHPpgpmehpXTx7I=; b=A87fq7u4jVnBiUaJCIuQcs29nRLC/coWmzwNNc7aWzFl4YJsuBE8Rn2GiKHrc63YXbF/rv o2E/2toHo/5s9f/IG3+mn2qHTmHCqb0j5ZaFPZQTgAlXUZHNE3TSWkk8GkybqkkwnPhRMd dYGnYItgfmP5600wTHhs8gomqn31PvY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714717809; a=rsa-sha256; cv=none; b=GkiQ7V4y7cWYYkKkZ21BCHqGMZ50/ZlsRHQ8ypHWrx0urzvkkp4f70vu28JKHxoTPn8LM/ F+0eu0tDjLIX6oqL6FdvYwqFxrErJ4V6du1dnRRJj3+RDXQ0oWOwtTFRV+adOlD3kE/Ps+ +m45xiiuR8TTEAuBrwVlNQlG4E8UoL8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bwAj/o4z"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9313060C1B; Fri, 3 May 2024 06:30:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D10BEC4AF18; Fri, 3 May 2024 06:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714717806; bh=NSC6FggAGOpolvtOOTtzvsapYt7Z43kurk5+y2tvQkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bwAj/o4z6mxVc4acT1p204cItFIICj4lolnvi6/B+2I69ijFUkW4kL43jJvFF5SNj UmKFV+2tDRa5Q0FuZXLq62NUw0f9R//Mhh7KhGfTfGvwsYTuWAbe8R8gF66PSIjIuK FeqRVhFSGE/4hC/ZWczfyriqj4oj0hhlnmoXy3QJUtLWmPOLtD42M3kP1GFnNA0u1m j7L4KS44qkZKAWDpzX4XROQYHr18P+iqEATDzZbnCq6whosLlxL/Atwq7kVYkiGMwb BfuhaXRN8F5uX61hlrlpunm62OWFEbNCk5y1p4CaZ97gubj5n8xiuGbc1yDd9WEY0K w1DM+OB1PDqTw== Date: Fri, 3 May 2024 09:28:25 +0300 From: Mike Rapoport To: Liviu Dudau Cc: Luis Chamberlain , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 00/16] mm: jit/text allocator Message-ID: References: <20240429121620.1186447-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DC0044000B X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wtizzt3mzjr5o6g8rr4w5u6k469a8mf7 X-HE-Tag: 1714717808-440017 X-HE-Meta: U2FsdGVkX1/lqYAZS1tHVJLxo8iuNVgNISYF7mA+W6MxaluAta2B5vvG0E/ANk3xlhLHvMlY0lQjV6QpJdCPOysSPb2/air7OiprlkspO/aqNevtqw6Ub8gP20REBbx9PCjyFUAVIpqBCEJv2Ru8AXrurEs0qnYN0dgOjMEucnfrpxwe1RhVTP4uxj59S2W64mtr0RT8tWxtLV0MvuJeWWZEWDaMb9kATX8YHWmHZz0PnOGX3UnwzHVk2jb9u7QVt6WRvlli7z5F6cyvVJTG/p2HKEEJ/1HtDVHNZHfHxH4NEheDla/4dVb4cgKFKEpWek1Jn2oypkQFAD/WucM681gRqI9Z/zumSUeFEib5cx1bG/Zm2IIjEJeS+6BAX3+i9OuAPZnIoDLbqSK/Sn57a+Rp19mPIkulbv3Y0kBc0/tpDFpA8ACJBiuYztw1wqRVkwhWv0PJG3WmQHRQ/fKgy30fXybsNclwQEdyVDcvDguwx83AMG191dmSFcb3w4lOK5F92+cLNXToM8SA03Y0z/yRczUevhltTBb1jHNrtwoBKAhMxhZU+aGYI4Jhn4Blqj8aQsmMv3mRkFYd2HfWUCjuUuIEyGCc+cMm3+4f3j2HTBDgZ2GEJNAlLI0ZkY0FDn7J944ZrRMYgcQTcJ+J27ln17bUPvRGzRy1IvSP1JQcgvtyrss5HdkG5dZZBSQ7e6ax/pOv+jnhdV/meMFp0UzL2VuNhiKOMgBB476Sz9NRFBCuooRYZc+ihMJZCX78PUk4p8/j8cgy4GS6y7GhO+W47xcgePfswaLjdBMOohINW4eSe4wj3GWi+2uYbgrnyAAVw12Acw5GWywfhT1VPopA1nt/H+XcVXabkRtlXmXTzNOI2GVMCLqHiknpM6t7erpSqC0BJsiS/7gwTo32hX0MRc/O4GSuVcEK1Uhr+gq1BtOEiV7to33XT3Hz/8ktWBecMq3rXr/B+l7gRzR sLkUsR4g VUdS8DSZWdkIrr/S42WLZYYo9vQUb3BwLQTIg7kDVt7DifhzKnY5+2WjADMTbl0GfNsOUIqJSm1zIA2PO28K0uAIbWdiaw+xMszao5McgrLR2RSARD5p1MBhp/RRSQZTgw4FBie0pkSwOO/WoZQfp8rSVUuWGLr4Q1zUJiEglK/slJ3xwSmM/VHkQzZy9nCFyTyCVpQOvgFld7ET5eN0QFxGE8JATzvDndvMC2t5fKhfczfH920/HoGZkm9PtZDNau8w1WkWt2eTNWhheJ1N3ReNem5zqxkWmxq+c9ZJB6NImSMvNygCq3HZQ4lQvKzFD4YEP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 01:23:30AM +0100, Liviu Dudau wrote: > On Thu, May 02, 2024 at 04:07:05PM -0700, Luis Chamberlain wrote: > > On Thu, May 02, 2024 at 11:50:36PM +0100, Liviu Dudau wrote: > > > On Mon, Apr 29, 2024 at 09:29:20AM -0700, Luis Chamberlain wrote: > > > > On Mon, Apr 29, 2024 at 03:16:04PM +0300, Mike Rapoport wrote: > > > > > From: "Mike Rapoport (IBM)" > > > > > > > > > > Hi, > > > > > > > > > > The patches are also available in git: > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=execmem/v7 > > > > > > > > > > v7 changes: > > > > > * define MODULE_{VADDR,END} for riscv32 to fix the build and avoid > > > > > #ifdefs in a function body > > > > > * add Acks, thanks everybody > > > > > > > > Thanks, I've pushed this to modules-next for further exposure / testing. > > > > Given the status of testing so far with prior revisions, in that only a > > > > few issues were found and that those were fixed, and the status of > > > > reviews, this just might be ripe for v6.10. > > > > > > Looks like there is still some work needed. I've picked up next-20240501 > > > and on arch/mips with CONFIG_MODULE_COMPRESS_XZ=y and CONFIG_MODULE_DECOMPRESS=y > > > I fail to load any module: > > > > > > # modprobe rfkill > > > [11746.539090] Invalid ELF header magic: != ELF > > > [11746.587149] execmem: unable to allocate memory > > > modprobe: can't load module rfkill (kernel/net/rfkill/rfkill.ko.xz): Out of memory > > > > > > The (hopefully) relevant parts of my .config: > > > > Thanks for the report! Any chance we can get you to try a bisection? I > > think it should take 2-3 test boots. To help reduce scope you try modules-next: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next > > > > Then can you check by resetting your tree to commmit 3fbe6c2f820a76 (mm: > > introduce execmem_alloc() and execmem_free()"). I suspect that should > > boot, so your bad commit would be the tip 3c2c250cb3a5fbb ("bpf: remove > > CONFIG_BPF_JIT dependency on CONFIG_MODULES of"). > > > > That gives us only a few commits to bisect: > > > > git log --oneline 3fbe6c2f820a76bc36d5546bda85832f57c8fce2.. > > 3c2c250cb3a5 (HEAD -> modules-next, korg/modules-next) bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of > > 11e8e65cce5c kprobes: remove dependency on CONFIG_MODULES > > e10cbc38697b powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropriate > > 4da3d38f24c5 x86/ftrace: enable dynamic ftrace without CONFIG_MODULES > > 13ae3d74ee70 arch: make execmem setup available regardless of CONFIG_MODULES > > 460bbbc70a47 powerpc: extend execmem_params for kprobes allocations > > e1a14069b5b4 arm64: extend execmem_info for generated code allocations > > 971e181c6585 riscv: extend execmem_params for generated code allocations > > 0fa276f26721 mm/execmem, arch: convert remaining overrides of module_alloc to execmem > > 022cef244287 mm/execmem, arch: convert simple overrides of module_alloc to execmem > > > > With 2-3 boots we should be to tell which is the bad commit. > > Looks like 0fa276f26721 is the first bad commit. > > $ git bisect log > # bad: [3c2c250cb3a5fbbccc4a4ff4c9354c54af91f02c] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of > # good: [3fbe6c2f820a76bc36d5546bda85832f57c8fce2] mm: introduce execmem_alloc() and execmem_free() > git bisect start '3c2c250cb3a5' '3fbe6c2f820a76' > # bad: [460bbbc70a47e929b1936ca68979f3b79f168fc6] powerpc: extend execmem_params for kprobes allocations > git bisect bad 460bbbc70a47e929b1936ca68979f3b79f168fc6 > # bad: [0fa276f26721e0ffc2ae9c7cf67dcc005b43c67e] mm/execmem, arch: convert remaining overrides of module_alloc to execmem > git bisect bad 0fa276f26721e0ffc2ae9c7cf67dcc005b43c67e > # good: [022cef2442870db738a366d3b7a636040c081859] mm/execmem, arch: convert simple overrides of module_alloc to execmem > git bisect good 022cef2442870db738a366d3b7a636040c081859 > # first bad commit: [0fa276f26721e0ffc2ae9c7cf67dcc005b43c67e] mm/execmem, arch: convert remaining overrides of module_alloc to execmem > > Maybe MIPS also needs a ARCH_WANTS_EXECMEM_LATE? I don't think so. It rather seems there's a bug in the initialization of the defaults in execmem. This should fix it: diff --git a/mm/execmem.c b/mm/execmem.c index f6dc3fabc1ca..0c4b36bc6d10 100644 --- a/mm/execmem.c +++ b/mm/execmem.c @@ -118,7 +118,6 @@ static void __init __execmem_init(void) info->ranges[EXECMEM_DEFAULT].end = VMALLOC_END; info->ranges[EXECMEM_DEFAULT].pgprot = PAGE_KERNEL_EXEC; info->ranges[EXECMEM_DEFAULT].alignment = 1; - return; } if (!execmem_validate(info)) > Best regards, > Liviu -- Sincerely yours, Mike.