From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 393F6C25B4F for ; Tue, 7 May 2024 16:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3C9B6B0092; Tue, 7 May 2024 12:00:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEC486B0093; Tue, 7 May 2024 12:00:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B3A16B0095; Tue, 7 May 2024 12:00:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7BC326B0092 for ; Tue, 7 May 2024 12:00:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD7A8160E56 for ; Tue, 7 May 2024 16:00:44 +0000 (UTC) X-FDA: 82092062808.16.507320E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 979D1A0017 for ; Tue, 7 May 2024 16:00:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SpiBK44a; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715097641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ry5qXfj/Y6VuUjlQ1iK9ZLpA72CsG7mprzoo7D4E3bg=; b=QBpbISH9jejMmlnNi3RFKwlABU6vbu/PyDYZiTGiFGFkr6UWDIXZZgq65Z65UPZWcGM9sd cNNpDnpqr6XAJIghC6gJRtC4dQFgZFM+Q54hk/Vz0nqkjQKeOzWXsRZOHuEBNevnEjEpD4 x1aISwFQIDy+tXGgLd1ZlT78CNZ1xzA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SpiBK44a; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715097641; a=rsa-sha256; cv=none; b=kgyr65q7loPjF5yWb7wqY4jxDo0oHJ6QcJYzpMJZvlIXEIuexhAZV51yL8ZCc/FNWioNUZ 2cbQF5bDAo7gmeEM+rs2eRQnwCcuyIJRxwb1py2qbY0rwW65rySGOBvpNh5KUfuwF8Usf9 EaMBxdmGrwszgAzq8Bavhzsr0fVF16A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ry5qXfj/Y6VuUjlQ1iK9ZLpA72CsG7mprzoo7D4E3bg=; b=SpiBK44aWoWuuaBLExkMFMiHu6 59YnYanRygofKHL+QFtmNCWPfEw5RUMULVykGljX/cX6mslfgct4hX/Wmz2hesYaVwBdaPy7U9TET 6af/i+mb+e6B+B0gbG7i4Kzmtaf8SX+ITnr2SEjC7gzbazcSUGiKHfdJKav8LffZ47Gd1/VLK9kgV WrL8V6l3wZUt8T+QH7TCNmp8Hc79tPUppdhsue2bmXiGg+LIOq+/QBSSc+d0xPE2FqVxQt36LSa0Q DIzTOUjF/P7IySbT2YfZUOsWQbZMdNg0BqEerQcLYx8+Xmrw2if9KkAMTAjsg/crFC0494N6pwsRn jxH6214A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4NEy-0000000DYyd-30hx; Tue, 07 May 2024 16:00:28 +0000 Date: Tue, 7 May 2024 17:00:28 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v5 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503095353.3798063-8-mcgrof@kernel.org> X-Rspamd-Queue-Id: 979D1A0017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 691f3ckry5kuni44yr386mk5j8x5xx15 X-HE-Tag: 1715097640-264640 X-HE-Meta: U2FsdGVkX1+CigCGABe8kMKNjiiKxQBKPOy/oNAd1QGsUx/ryyZRTiUySwQRBEpOEOpxrc630WknvokECuWNFCwwuEiZCQK2/Tu4AA7w0zrvghVo5sgo9+bQhlDNBjlURxAW45DMleRlVokR1LRRBl2wjjzVsqrYfYQM4qG8Xs+0C96MMubEHMdWVBkFopJtvCjjLcj6jXtHjHwKdgM3nrttkx8v9NogozS+WjUT5tXWAN8sV1rI+xDVtdJWZ53NNsmBvBDYZl0vVBWZdHIuGjgRQRMQCUZTmo70drDgEc7D5WHhgAM6blrQ+kvGNu7I87l44TC1Q4hTs17w45q/sPFIyAg5YVlduN5XzWBavKsfxLN+/s+Z02j06VpnY856xjOdZlgzGtdnNMf3ya92UZ1XADviixopK/bbD1mi1JRxe1YJW7OSCuw5CsHs4x7EeqokBnYcfgxjm1vHO0uTpgQDdV+/o19jgIz0ZgXhcmn2dMIXlHVYVsh0L3dH35yXdVsKwss0m1UHE8PakSCf3LB9uPPclGGuuN2QUCI8bTRD1eZuHJW0yFtJj2pv0UppdLqHrF1fWBtQS+D2FZjklRloBxJKN+YviM2aXO/gmwne7RXnYETMoYU0+rqP153vxYMZNtuiJ/H6Cn/fHHNe/F6QJUqmLFQ7UJo2uZQOShLibSkmB3MEnZ14RP8P7jhs7eeQJqXL1A+c3xIlnKda6rmw2uqm+FZxnxC376HE7O+ILNnlr5+HLFlKt2Yi4AQjqZdJih6ELXt9ulv/0uF3C0FMP1M8ptJdxkW8Quv6qqn1r9pg2IerCV0mGczHTHaEEYjM7dkatt7zjGbTJvxhR5YE6zeCLOud4BZHpQN32yKiTqdXphjQ/j3SGx0Z3ZX0LjcAHgrSAuPkidLCC1g0aITDHv8DBJbtNaTGG8D9CMUWkzA/AibreOfjFIYg3wF9cFN2zqQfSzYgstOaxjj ruDQvi1U ZaYm56iPm0dNbE/RA20bw8OllGh36cqkR91hXqXqTz4pMR1a/9F6t5z89xJFbtpjMHNjJmTd8SN6B8R90b53xVIJNOQ9aGQF5cIq81HurJptBKs1m3U7LyocOh507fotfeNKiL8VwDG0Hr5LcDUs3BIGvS+xAOJG0Hj1rYMNvnbl+MRGS+cQS0ckWE/70vnIStb61qwi8dqT8OevCsr0QGJFUG8hLC6KUIpAN7GllNk+zhiPUxDE8j/Z9Iw1OIzEejGd9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 02:53:49AM -0700, Luis Chamberlain wrote: > + bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, > + REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, > GFP_KERNEL); > + > bio->bi_iter.bi_sector = iomap_sector(&iter->iomap, pos); > bio->bi_private = dio; > bio->bi_end_io = iomap_dio_bio_end_io; > > - __bio_add_page(bio, page, len, 0); > + while (len) { > + unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); > + > + __bio_add_page(bio, page, io_len, 0); > + len -= io_len; > + } > iomap_dio_submit_bio(iter, dio, bio, pos); If the len is more than PAGE_SIZE * BIO_MAX_VECS, __bio_add_page() will fail silently. I hate this interface. You should be doing something like ... while (len) { unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); while (!bio || bio_add_page() < io_len) { if (bio) iomap_dio_submit_bio(iter, dio, bio, pos); bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, GFP_KERNEL); } }