From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E60EC25B4F for ; Tue, 7 May 2024 16:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 131916B0095; Tue, 7 May 2024 12:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BBC86B0096; Tue, 7 May 2024 12:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC3DE6B0098; Tue, 7 May 2024 12:10:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C24816B0095 for ; Tue, 7 May 2024 12:10:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 705F81A0A3F for ; Tue, 7 May 2024 16:10:25 +0000 (UTC) X-FDA: 82092087210.25.446520C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 3C17440018 for ; Tue, 7 May 2024 16:10:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="tMZM8ZA/"; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+eb9e2cf7ee7434a528f0+7562+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+eb9e2cf7ee7434a528f0+7562+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715098223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KKGmBlgIr6xib0UMQFkFjiQCKra12CQXDOsG2WglJjY=; b=vGosUX83v+aOfyhASlyhIHEMovO6FQBMVIkaifvB1Du7M1gv9KrfVBA1qqj6NeOb320R4A wnjbFsIjOE5XAjaHeJILPWXhfPN86GIxYJPm/D0GpBq9Ia1MiWCF9ZoAJI5X/YJMLvBjlE +0cBG7QrMW9LBpLkvbw57ndUkfg6yPI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="tMZM8ZA/"; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+eb9e2cf7ee7434a528f0+7562+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+eb9e2cf7ee7434a528f0+7562+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715098223; a=rsa-sha256; cv=none; b=TGD81AJTZA1RMKGk6tzwdqzn0rCEJbMblBnuZMJpogkO2FLnnHjqqZ7mC/cnBvfiDQwNzy PGr8uw88B3TpyRlmrDq3x5b5qA+Xgo6QD0HDC8iXfIG0SxhsTgHMzN5UCmEqxwxmwbe8j0 SUrzLsnM841jw4JB8eve4ltW3GH0WVM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KKGmBlgIr6xib0UMQFkFjiQCKra12CQXDOsG2WglJjY=; b=tMZM8ZA/9lKOnq5df7Z+oKqFUm 8wcysCiLx/JxBoGpf4rcUDVlypAjmG98Q2ZxhxI0PBz/vbpAeqyPShrySIBVq8stKX1b/2ioWy698 LyMCK7M0qLjZjjnqjc/PhfliJjfdF5PXQwTQo+A8EdIxWZYRUn+WudCOVKeiG/ePTuzNDzi5q/h+H tww0lMOHyf63V7lxVefKJGeIPt7Sk0kLq9Uq9YFQooxSHeTG03tC03IcgEGSU7N46tgIn3JMfgBBj 4sGjHqsDNaoh1c1h9eFC3PskwchtIdeCf1LgyG/sPN0xxNJwy1cQd18AEbPs6JfpE228cwIJi2nL/ YMSYc2dA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4NOR-0000000BtsQ-2Lvk; Tue, 07 May 2024 16:10:15 +0000 Date: Tue, 7 May 2024 09:10:15 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Luis Chamberlain , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v5 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3C17440018 X-Stat-Signature: juzjzy3545pf9x59eq7xzw4ayyws7it3 X-Rspam-User: X-HE-Tag: 1715098223-349738 X-HE-Meta: U2FsdGVkX1/xb7O3bc/HZiffvoupPy4bFoqDwoCmsHGM8ESXLvD7h9djRNmbAHmyifU3Q2dzYheXghmAslyicK4m3ddPMBbfzNNAunQDwEr6N7PIqrc+Zh3iERqq++x0oT56O/DjvYM4leu67G6PnsBpX2hdTlvpj43Kj/rYMTsxw56bcy76OXsIK7frnZYjpNBy2KTOabY5m6shB15DsuGoo68Pjiqqsd+mneV//KKGQ6KJ5E1TzQdEfDRkO3zZdorQsW6eOzJ+WuLlm/Bfc2EIqJXk17zbOvjHC1UoF0/qFYhULWxjO2iTd+5do5s0fJVqiUPVY3fD+xLa9VtE8itNW9PDyxGWFKMI+BFI4QK2iH3gw79X2TBEqNaDMRqyBuHQ4Xi4pwxwjK2VaKMrwMXtsuQ7HCQWe9ps9eIx1t8hKUEmdjTEOAJPRoXNat5H1DKX9hCIUk2x5TqlFsrf2RKJCrTo+yYBwyCF+i+sdLmSAslqRRA5bhCxiY49xSPR0k+YAIZoo/k1zpBm+wtKKc8lOjww+lQik/qy/OzDZyASjH58h/dcM1D1I74q10lpX+wrRL+dPWtAIuGUm4MBSljJzGWMAmyK37muwTz5OTvCCGqWm8lmBStaWA6bMbM2d9Tej2c8lak63Sn4/Hdi//NHlXQUVwZe8ZFkRdguWyj5ab6YlSS7oXb4c0dxUbOYhQ8O1mZ3KOq7bXSpxUA6GBj532dBVtc4ekoEwRTA+AyTK7UK7toPFyTqVX3x4pzhaY6/9D3euBLLIvuYcEV6Y6xixYUOfTASkq9+AAqND6Wztl5dP5KAeorA/21gmONXS8LOKLUgCTF1wlWFDXObJF1GOY3SX6eT68Zk6v7cHv03qGNnXf2kfRvUKkVsTDEzR8UcGGCOndEoE//N0jMU/fTf9JLZl5sfHFoJVPyFAB4NQ4+NzAlHvfLYEZThkaM2tgWf4LXcG7RLDwon1bP 0B3t0sKh Z+T8OgxTYFwGeLlml0GRHp0FCEbJd9cOJwdnd7mYcpoo5aqhO7hDHHp6Ve1161uiwLUA55a+ZqGCW4upSsvG3aZ/jUMGL9tidc1bm8lZFR/o/ec0m7a9xWxP4tLTKHKTm3ncXSkOazYAaFT9dXz6STbpPhXak6dIj74T1JhzW9yD3n6ORr8NSkmB60/G5a6C9dez146+mWTtO0JSUwbra1Q4Qsa7RGTdXKlzJaCF8B8eOhJH4luB/1hbvSyIumb/wz+KettRRc8pGEPRF2hFXnubSP4ZvZKP/aQhaCtt1yOiz3U24spqU1jpaEz24pv5KTG1nJtGBdY+PApU8JT7QiMiCwgsT4PI/6vVMsaRozTW8YwzpvbR9QViyw7ln8SaCuBxv3tFkheJGz9ZuEmdahi5+J0LAQ7HbfWcLDF05jGzh3O+I2zQ2a+HpJqC8ZQaseGFHs6Tb/AGA1J8K0b1C3hzDULpnzn5JDmEf5mehwCo5lVZNYVmmw2c3TNkunIgkR/Mb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 05:00:28PM +0100, Matthew Wilcox wrote: > If the len is more than PAGE_SIZE * BIO_MAX_VECS, __bio_add_page() > will fail silently. I hate this interface. No, it won't. You can pass an arbitray len to it. > > You should be doing something like ... > > while (len) { > unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); > > while (!bio || bio_add_page() < io_len) { > if (bio) > iomap_dio_submit_bio(iter, dio, bio, pos); > bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, > REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > fscrypt_set_bio_crypt_ctx(bio, inode, > pos >> inode->i_blkbits, GFP_KERNEL); > } > } Wee, no. The right way is: bio = iomap_dio_alloc_bio(iter, dio, 1, REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); __bio_add_page(bio, page, len, 0); fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, GFP_KERNEL); (or even better the folio version)