From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FE8C25B4F for ; Tue, 7 May 2024 16:12:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37C136B0089; Tue, 7 May 2024 12:12:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32D766B008C; Tue, 7 May 2024 12:12:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F4136B0092; Tue, 7 May 2024 12:12:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 005F06B0089 for ; Tue, 7 May 2024 12:12:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 75619C0343 for ; Tue, 7 May 2024 16:12:05 +0000 (UTC) X-FDA: 82092091410.21.5149DF4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id D4F4D4001E for ; Tue, 7 May 2024 16:12:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HQUiArRA; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715098323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WsCCissf8szKJC0YOGfb02GAiXDtjCBGSd20eGfpyFQ=; b=TV2O8HNHK4kHU97k5D3KoHUERUqVOqX+oAXAIxwqrRjHo3SFOOrsLPaBP6OsuMXIQDuf39 6qtfLQFTtZl6X8w4pmISF9ULmlkXsZDyZvmH/gasUnw8CVexEhj2oyLY3GOuhHn9LgvM5s W796h3++P0zdl9+J+UcWq/04LwXnAxI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HQUiArRA; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715098323; a=rsa-sha256; cv=none; b=JOFvbk7UtEtRN+ZbvtF7parCnw2nSGTvenRrnrDZ9kL1XtHAgLe0C0eXmMcZ6Kn2573WCi yQ3QF3X63lwRazn1vySe3+/dfs8daSYR45fGlwWeHjtZEUYxlgP/DFOtVekfT3TyBQDzxR eiQWz/bfsVEm2Ic6yjIhZmTTx97W2/Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WsCCissf8szKJC0YOGfb02GAiXDtjCBGSd20eGfpyFQ=; b=HQUiArRAxQpVcgnY87kkoL/vVH mVNUZPzv3tlcOtZpBrMMNgMnev0FcQCOZPgGRE4HarTjgyECeI97T68rHasPAbF7ojRzJA1PgdG91 D87zQsWXKvH8cOeh0Mf56yB3gh7Pw+DhU27acAmatmIxjy7Jy/mqFY54cbWEK+SifjODYySDfZ8hs +7dvyiLOaiVnIXKvpg0+BdD20CU3U/8gsiRlEhnMPwesB08UlTnTo2Da8EbczxjovXLRwS3al+0Xg qKHk9cBrHB/4DlkkjRR2MzhqK6PvaL8+qV4O00S6Rj+IVfxSuGFOQwNm+9kAQHmagNWp4rUF+81O9 XdQ9nilQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4NQ6-0000000Dafv-1f0L; Tue, 07 May 2024 16:11:58 +0000 Date: Tue, 7 May 2024 17:11:58 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Luis Chamberlain , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v5 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: D4F4D4001E X-Rspamd-Server: rspam06 X-Stat-Signature: 5hgk9mnyjjttfnzbdjfc8c17pa759hmp X-HE-Tag: 1715098323-634828 X-HE-Meta: U2FsdGVkX18DdmuG+BXoypPrGkQDFr1fU4dnuHHTJ08yeTd8hdwCK+2WDj5YXHGDmilzDwcc4E+EfG0LtRgX7q5MaV3v+19Dvk6+dhhpzQpkSm+5lvQgiDnkSpYaVezZ4IDzKfofKQDOEBXeRJBnVJA3QeIVgpy1fePWhSzHXYWkhfKij3W90FV7NdQQVviuQNdmsA/Cc17lpi8x9/xV1G/EBUBlXsYppeD5Ns/1893h6bm/lEoVvCtIVogW3/ru5NY2dc13liaMlUWUY/vGnYvcpv2Rer/1C4V/Il1Nkpxnk2vHVCvc7F95Ja65CY0s6obigO/UVzkxh20DiTNV80J4GSXPTisZqED/NGLMn0B80JYsY3ASOlX+hzAAE9xONSNcupnmkKly05xqpD5FmfiyRi135c5LXnrOOX7YomxWnWFjG06CaW2yEq8iD/5c+ApnJMBwXUD8ctzP2DCDdcfl1ElCN/hyVudJxmDtU1sLWq+zq3cdhhGYjJXCDhER2rW+yboYK8BNMe+j0wbuPDFc7d4cMmwnHqpXbLTbqBwccKVBDqkVq7qoKNkiwoI93dcWEUq/nL6noMI+k5qDkTEQ4NMV9NPJx/BK1k8pI6lfaHwOj3tDcS8BoR/FXQYYeXrLfm/4PYPojpbnfa5ZfJUAIbYpoHoinNuhW5IOaUW+n/GXC2w6xxkhwT/14brfxmA6E9cP6Dj8cjmdh+ShfX+csSiRPd7pOFftCEbg0W/rZiYKU3btTspWPFz3hPacbXi7FNQG5rIutNS4uBoe7SCQaOfnIaLDfWa5xQgHhC/6XlrWafe+G6CsNPDJW69JqCOEKlFulF2HxnS+WfIx9N+Apf4Qb877iqy42HxpvKQJeiCNxPa+m5K1Q9MEcLnz2EodBrvH4YhIdZP4tPBcw64Tz6kJ1DgS/AxQZvQRxyv7e/xI2K665Ejz+xjv76ELH0cZg/IgwMl4IVhceSB kuO9twzP jGZ8T0I9LvnKDpJ77Zg6UjIcGBmpLpxIPsYuhzhL7KDD3GyE8oZfyXo/3Xg41q7pBWT74DxGQqM1VJzmfsznxiUcDFnWFje62/p2mTfGTGmayXo5GTG5UTXiq+Z+Bz95kw5gb88KF50jGzRbWy4Uwofq8a+BFtGlAR+mXcGi7ILrEZjiucH4IqYO4kDeZs6ZsMycQn+Wd6JhUCRDg2UOHOoVi7n5FRzw3iQxxALSnSl0k0ME8jDWTCOtNEqYoUjZLHdva X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 09:10:15AM -0700, Christoph Hellwig wrote: > On Tue, May 07, 2024 at 05:00:28PM +0100, Matthew Wilcox wrote: > > If the len is more than PAGE_SIZE * BIO_MAX_VECS, __bio_add_page() > > will fail silently. I hate this interface. > > No, it won't. You can pass an arbitray len to it. > > > > > You should be doing something like ... > > > > while (len) { > > unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); > > > > while (!bio || bio_add_page() < io_len) { > > if (bio) > > iomap_dio_submit_bio(iter, dio, bio, pos); > > bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, > > REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > > fscrypt_set_bio_crypt_ctx(bio, inode, > > pos >> inode->i_blkbits, GFP_KERNEL); > > } > > } > > Wee, no. The right way is: > > bio = iomap_dio_alloc_bio(iter, dio, 1, > REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); > __bio_add_page(bio, page, len, 0); no? len can be > PAGE_SIZE. and that can be true in the folio version too, because we won't necessarily be able to allocate the THP. > fscrypt_set_bio_crypt_ctx(bio, inode, > pos >> inode->i_blkbits, GFP_KERNEL); > > (or even better the folio version)