From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36486C04FFE for ; Wed, 8 May 2024 04:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D17A6B0085; Wed, 8 May 2024 00:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9814F6B0089; Wed, 8 May 2024 00:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 848FC6B008A; Wed, 8 May 2024 00:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 66E7E6B0085 for ; Wed, 8 May 2024 00:25:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F06BCA1E9A for ; Wed, 8 May 2024 04:25:07 +0000 (UTC) X-FDA: 82093938654.17.0819D58 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 63D2D1C0005 for ; Wed, 8 May 2024 04:25:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s+ACq4eo; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715142306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=84ZtBvQ/khWSnQbEsf+haKoET0najOuq14tZKuu3Imk=; b=jihOUgV4RS6sdDTbx19xX1/thZWcn5+LElzi+sNS4QC7uyySrTCr1OkuncdZuTiWkJUEWt 0mNWLajwHH479ffDYuDenVJOqUxMuB4n9ab5JHIbhpdbpZtZMGbqkMbRERPz5VE1AJGEs/ 9WAmMIrazNpm+zSYAg0XTiPOu1G0Ojg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s+ACq4eo; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715142306; a=rsa-sha256; cv=none; b=FVkuXZOfVzA0gcoMJg6W4oS2tM1q4FUTJqdvRSWUrDV87H0o34DSgZUHgEExiKiTbAGxQ5 inPH0f8qxxp7O/SS80s5mBUkeOK8pzarvc1ulmHptr0fdqW8HJlocnLXh1QnmPEbkwcTGd cR0Jt+u7BuTtCBhm1tmr1HWys8ASbYg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=84ZtBvQ/khWSnQbEsf+haKoET0najOuq14tZKuu3Imk=; b=s+ACq4eozDPnv+dJg0ug0zNJiJ pUo4dOo4SkdW1sY/xWDWEwgbzQFZUVHYBt27fZx8vQTbZPfxwPoR1uBJfGL7d7nkWZR2TYtDWI8wn xJOhrWog/be2TjPlnaz8LPrQiNB56alp4WywKxz1gQc5pEF8d/h3c+GbUATcI+zVPjMCRtdHOL+mp Qz5uGBSbFkmkxrIQVBy7kLsCXLicfFEeidgwehur+2CvLXqPhF+gakpGCXOk/vEoEsbAenOobpNXi 0QG7kA95+LsR81+mAlNxbSxbMcmsRIZolR0lN4u2cZdZEksmwQ49nqymVT6bKO31ONbHcd5GwRpoc ysZpz2eA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4YrN-0000000Eq2c-340Y; Wed, 08 May 2024 04:24:53 +0000 Date: Wed, 8 May 2024 05:24:53 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Luis Chamberlain , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v5 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 63D2D1C0005 X-Stat-Signature: ecixj1jxfijmqt9mdqj7ikdyec73n3zy X-Rspam-User: X-HE-Tag: 1715142305-777950 X-HE-Meta: U2FsdGVkX18E/bIR2Rt4REFBZPXIyRf67F2qSuq0nhJZ0MGAJPr8Xm4kEeyw7rxiuK2rrwekt9LM1QgLLqYPXIkznhKw8RJNbNhrtlJcS2LFf4MtO6Jvo4Eo0DqUgHe8AY1KjKph+c2ZM5AYMioe2w5TOn9B2253WFlYaz27ixXtXkKcFbLPhsWduBVoVP+9OqiQnfUqBXMDs+cln0xRiYO9SeYC1ua4oMNhh0vO//r551OfavhJwxCHxC6Q51zAeK6qVRCmf4mofYjIBbjUgMFxQXwjJh/M73DNbY6atKNooHycIN9CerbB5KvjOZkWW+gkO034dvdWsYsSeYk/xfiTIkYCa0nvV+344An7pSpac/XntfSk3Lw8UTLPT4D3YifF18MKVN+EpEE+P0GROl0JfdY6THRwOLdaK0UdrQwxzxB8yN0Gsl2y4cRpANg8HjcGdhsP8KjVp42lYg7DDqUWQZucqOcolnDHSxWWzShQPZzXMnsOa7evRLuLlasZRF3mPLvd0TVIOhobL97SnSIpM24Go7/DSUZYBZkk4JeM9RnRijNbdvUfDk1Mi389OWCcWliZvPRiH/TLtVNQQM9nD4OCmYpdfh1kD9ilPzecJ/7PIIaEbclhBHpgyr2Q5prZM4N8hRXY+p1AYVXrajfvtH7VYJTcpOitAUIkRcIm+IHe29s65850lYHgdGHl7Nmj+yxGMXwHOlHkiTsJOX+i/bbcZ7RjyMkTNXHxTzPj1nDrKL+X2oPu/EhDrPTjNdDxTalF1Md7IUkv0AtF6rQmXchA3IWIJzdzvP/KyeITXnOYP/DCsH/VxD3Pyw3t0Z10ZQNMIIAb6hhFuxhj/KF1OQySPtNl/1fP4EieoqkMsmfZoKiCuvL5nnHu55a/wa9d5ZnOeeP3BA/pLO3wgdFV6+FDvxjwJTOv4ZiCQ3JfHjsiW2mziXB/ppBx+o94XyICts+fNJzSaXLnSjs 43VZEnEx ukwsyBGkSBXrU5RIBlwwsJXn0H0cONlAXnr6M414teXxwDFFbnncUQcfBpfkv4pajOLDn/gOO2hTJ178aVmrY0vSxjU2rTr0TlywLjOdjATqsLwcjNdDwtW0U2DYazVT4XUkPmvOGUuXtLGj8IhvY/rzvcGuyihiWJL6siq2AQLy+t/TNTijkWD1PpHrkJYU/GUB8OmhDJEwpnYG2bP5hNlMP3Q1dT6xy6ZI8tY4qbjnOaFkD1eniVoUffc3uFn87/Wd8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 09:13:17AM -0700, Christoph Hellwig wrote: > On Tue, May 07, 2024 at 05:11:58PM +0100, Matthew Wilcox wrote: > > > __bio_add_page(bio, page, len, 0); > > > > no? len can be > PAGE_SIZE. > > Yes. So what? the zero_page is only PAGE_SIZE bytes long. so you'd be writing from the page that's after the zero page, whatever contents that has.