From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8AA4C04FFE for ; Thu, 9 May 2024 00:07:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49C7D6B0088; Wed, 8 May 2024 20:07:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 425936B0089; Wed, 8 May 2024 20:07:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29EA36B008A; Wed, 8 May 2024 20:07:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 08A826B0088 for ; Wed, 8 May 2024 20:07:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A7D51A0D84 for ; Thu, 9 May 2024 00:07:38 +0000 (UTC) X-FDA: 82096918596.22.90A5A38 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf02.hostedemail.com (Postfix) with ESMTP id ABCDB80012 for ; Thu, 9 May 2024 00:07:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=2gvCgHKt; spf=pass (imf02.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715213256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6412VEZicQnkZugSEnbJnR1wa1jdzb6p/Jx7cOdB8xk=; b=57Qba2hgQFTpFMstBXTalOP/7T1KE8HcMd3Vovr/3K+j07FzBemxtLP+0sbWZiw0Zt3pXb onbjEXcpiTSN6+E6LY/4m64OIfXXyWu51bE0NC4BYujdv/EgMZhCvg2Z4Rs5Zli2Z/Htg6 h1QzDtEAOQkiMQnQ57YQRJmrkGz1pfU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=2gvCgHKt; spf=pass (imf02.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715213256; a=rsa-sha256; cv=none; b=SJeHQZNPpp2H9DpcCkNf2ik2wCRYN6Hq+X+9iOrh6B2u85OANGYjv3BIvLz6N88+0Kl7BH FLHt9ETEeJNc4cPGJ8Gd0SUfr//mYyLoebwoKOVImfho3V2B866M/VQiXz0HbPeKyqkXrq Z7RS+KKEcS8pC8kbpygVVjRCFAFfUj8= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6ee13f19e7eso343720b3a.1 for ; Wed, 08 May 2024 17:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715213255; x=1715818055; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6412VEZicQnkZugSEnbJnR1wa1jdzb6p/Jx7cOdB8xk=; b=2gvCgHKtReoTCLgB14ZgHjyu+xWOnETveXEvHd/D2SH3eA63bVYv9d77KypBnKFQcY HORdSj4Zum+U8hP3C6dH/9BdR/gxy5d0yhyMi3qnrrm2MPgeZLD/0uqIPiObw1UqrsLU mnC6YvMXRATOS/0G//oFzn1gllDEs9H4qVy1k4uCg7lcb3g5Hhgr2tmiDrV/jrY/hij2 WacefOaimmND3nLQB8o5NULVuyHXarUt216LxEA/013AyRwts2AiA/eHdITqmY8f4R5u o+QktmWKXfJnrDdUXpg2fbTIFUqtwM5xMo8EEgMr6aNGXmrXurScWRnkql+AHW7MnfPN NkGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715213255; x=1715818055; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6412VEZicQnkZugSEnbJnR1wa1jdzb6p/Jx7cOdB8xk=; b=sdPY7j8H+3FVXfMtqgn8Jx9mpckXA/QzIfBysgnMfIa1qWJTF8MjhUJvnnT28GMJS+ pR/1Zsh5YRFC5VqVMuSOLR3Z61ORnhmO4zIe5nq8FnCWpUU9fgcypAoaLsNf+r+zvL2n YZh0zQ38Ny3/nKhgd4A/8IiEvyHA2HoDHVMGVyhx690Yc2qhHUftbvzi8P++R+eOX0ld 2bUoloUa7g16ECqN7HAIyJ2ejC/XELO/pzJAjCLFwix3EsQGT7uLNzKqWGaxiLMqf0z/ +TQpbLVWXNNNTbUhcRyRYHABLMCB0pDHXVaV3YRJ4UPtKSeMP6ZrNDRp5mW6WL+8PxVy Mx9g== X-Forwarded-Encrypted: i=1; AJvYcCUS5OTBW+d2xtn4OMnGXg/1pz39G9rLmjR/9PABY04nCoj2iXSaO3JNxMLl67lwGpW7Vq2n8+fWor6WEQ/GkdDlS5M= X-Gm-Message-State: AOJu0Yyyn7PBVmV5uSbWz0witd6iO19Su24xchSy0XUpFBIfLGIgELpt dPxOfLgb5JWFEHt6cc2AcZ+eYvlxdSjyxE2RHZYvIESjiXlgRezXNtlSE8hx3zo= X-Google-Smtp-Source: AGHT+IFn88bAR8FRppjVpxx4Li1DASVwJ1zF7Yvk7MQzB0h8bmxFN5sOCIHGIBoohUfrAWiBfqn16Q== X-Received: by 2002:aa7:8b11:0:b0:6f0:be31:8577 with SMTP id d2e1a72fcca58-6f49c280ad8mr4602857b3a.22.1715213255357; Wed, 08 May 2024 17:07:35 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:4144:6911:574f:fec1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2b2fe07sm137325b3a.216.2024.05.08.17.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 17:07:34 -0700 (PDT) Date: Wed, 8 May 2024 17:07:30 -0700 From: Charlie Jenkins To: Andy Chiu Cc: Deepak Gupta , paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH v3 05/29] riscv: zicfiss / zicfilp enumeration Message-ID: References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-6-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: bczp45jqgefp9wgkp9fqmhjimbxigaym X-Rspamd-Queue-Id: ABCDB80012 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715213256-399025 X-HE-Meta: U2FsdGVkX18y4fNNKyHo/2Mm/hXKBEN1q829gdsiMhuxuCAfFjfdZ7asP4clRCLoW6HZMe/iQp2E9dMpslPjx6HdsGnno+UQrVjyB/UHYKlOZPiMVlM1n6Hgpj2Mw/nRWAm96whZlI/IVQZXRjlwe4w/RY3QedkrTup4j1b67MKXUMIez9GcGRomfjsQVY307GaJq8U3UROalDGQWd6QUgejZky4lcRabCrbysb+wNQt33z5e5u86SHlOge+cr36cchWBNCQNES6WqqLD1SJo5Pr3La4MbvZu/ZPtfXMf2wqx8Hn0gQBtVlM08YnfIHTk/CQVfUudEqFVERMzF+cj0f9tYaUAplV7lGTVyQXfJlZ6Sr8dIxnYtZ+qKsjpFO4IgkXwr1Sy/0mpBhgb7BNekXvG0tRVvOlam4OXj7YH9WC0GkXgQaMAg3xby6R+yjN9ZFFq5akIeHkcEu/pkpwhvMVajK5+/xT4bFtzvM9uGviw5VFJekdxWzI7UfH/rI9w9oanJRFbIKa6QzZAnSUKJ8lzN2p2jlV51RB9S3lZrK6PBzXZgIoCQe1Q4cweKWrFff4lWnCaq5s3CRODiB1s4Ra7VDtNGFWZdnm7C1GbPkO2gkOJx9foIJm/M9jA4uDreEEIQSIopKfaA2C3xPSW1GsW7w873GfOhvu5um9Fx3Hjiox4tAU1rulhsxZNuIe8fJFv9LQadOn1hPHjW62mghMnBxeM3nut3YSiUcMlplTtkgDUFzWNqwF9jeRIN0QA+0+mdFQVgltS9VGNHEIiSTmFXBu77NVQNJ7Ut/p61j253+VErCJXUeSsjJ6lUz2Ngv2SsUiAvaZKWin/QjFdF6tsxtRK9AvYJAG8eAWGJQq7iSqyRAnYV16g0HIQXl3e064BUgpQeuWIE7E6HHUsFAYkTt5dSY8syQXqkLseLUlkX+ii50CKbc8dUkohXJNUI0k2Zz4HX7tvuTJA8x u63Swlos hIEPbIMPefULhAK46hcc5GIRimFr0S28hEveXu3kEpu5TVJWAZrB+QxbGguRQvYfwlYaPjvXns/F5MghcT14++cVKATYI+K2lR4uXJwkEoWS5VdfYnAS5PG2sJEy54PzCBDhLltW7R20CWr6AFGs5gCLShB0VKOM7Yd3NO7xetToscq1pUGWXSVDzljFBG0OTRyGpGssnBoIbc3Em4CEGmOtYsPwkAr100ctHwrFo5w5k2xA0xi2d96Q3Swzx5UYvkDTgxgdsaUZgOAoBwbigYU7m8oJVOAvWAoGHY9yEuKJaS2EJt2oYRJhP6iHfha+B6NwfCxIzDENARFz1y8zrYrqAbqa9h+GB5xb5V/YacxbPweGlxI9uj71Cvy+oWqZLOY53SB+BaW2255n9dq+nz2PowrFtiMs+eC++5m9cdUjLVzoIXgLjCiExq3W1b5HHcKqRSlFR+8SUSVJ7kSMEMLEHhivqt3Wr3/yhtSW1iiidIxgIh5BOVpB8y5aEVKtjQAb/SantzecRI58lisLG3+L1nWSCzgz9KVNG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 08:00:00AM +0800, Andy Chiu wrote: > Hi Deepak, > > On Thu, Apr 4, 2024 at 7:41 AM Deepak Gupta wrote: > > > > This patch adds support for detecting zicfiss and zicfilp. zicfiss and > > zicfilp stands for unprivleged integer spec extension for shadow stack > > and branch tracking on indirect branches, respectively. > > > > This patch looks for zicfiss and zicfilp in device tree and accordinlgy > > lights up bit in cpu feature bitmap. Furthermore this patch adds detection > > utility functions to return whether shadow stack or landing pads are > > supported by cpu. > > > > Signed-off-by: Deepak Gupta > > --- > > arch/riscv/include/asm/cpufeature.h | 13 +++++++++++++ > > arch/riscv/include/asm/hwcap.h | 2 ++ > > arch/riscv/include/asm/processor.h | 1 + > > arch/riscv/kernel/cpufeature.c | 2 ++ > > 4 files changed, 18 insertions(+) > > > > diff --git a/arch/riscv/include/asm/cpufeature.h b/arch/riscv/include/asm/cpufeature.h > > index 0bd11862b760..f0fb8d8ae273 100644 > > --- a/arch/riscv/include/asm/cpufeature.h > > +++ b/arch/riscv/include/asm/cpufeature.h > > @@ -8,6 +8,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -137,4 +138,16 @@ static __always_inline bool riscv_cpu_has_extension_unlikely(int cpu, const unsi > > > > DECLARE_STATIC_KEY_FALSE(fast_misaligned_access_speed_key); > > > > +static inline bool cpu_supports_shadow_stack(void) > > +{ > > + return (IS_ENABLED(CONFIG_RISCV_USER_CFI) && > > + riscv_cpu_has_extension_unlikely(smp_processor_id(), RISCV_ISA_EXT_ZICFISS)); > > +} > > + > > +static inline bool cpu_supports_indirect_br_lp_instr(void) > > +{ > > + return (IS_ENABLED(CONFIG_RISCV_USER_CFI) && > > + riscv_cpu_has_extension_unlikely(smp_processor_id(), RISCV_ISA_EXT_ZICFILP)); > > +} > > + > > #endif > > diff --git a/arch/riscv/include/asm/hwcap.h b/arch/riscv/include/asm/hwcap.h > > index 1f2d2599c655..74b6c727f545 100644 > > --- a/arch/riscv/include/asm/hwcap.h > > +++ b/arch/riscv/include/asm/hwcap.h > > @@ -80,6 +80,8 @@ > > #define RISCV_ISA_EXT_ZFA 71 > > #define RISCV_ISA_EXT_ZTSO 72 > > #define RISCV_ISA_EXT_ZACAS 73 > nit: two tabs for alignment > Deepak, I think you might be using tabs with a display size of 4 spaces that causes a couple of places to have incorrect alignment but would look correct with 4 spaces. Linux uses 8 spaces for tabs. - Charlie > > > +#define RISCV_ISA_EXT_ZICFILP 74 > > +#define RISCV_ISA_EXT_ZICFISS 75 > > > > #define RISCV_ISA_EXT_XLINUXENVCFG 127 > > > > diff --git a/arch/riscv/include/asm/processor.h b/arch/riscv/include/asm/processor.h > > index a8509cc31ab2..6c5b3d928b12 100644 > > --- a/arch/riscv/include/asm/processor.h > > +++ b/arch/riscv/include/asm/processor.h > > @@ -13,6 +13,7 @@ > > #include > > > > #include > > +#include > > > > #ifdef CONFIG_64BIT > > #define DEFAULT_MAP_WINDOW (UL(1) << (MMAP_VA_BITS - 1)) > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > index 79a5a35fab96..d052cad5b82f 100644 > > --- a/arch/riscv/kernel/cpufeature.c > > +++ b/arch/riscv/kernel/cpufeature.c > > @@ -263,6 +263,8 @@ const struct riscv_isa_ext_data riscv_isa_ext[] = { > > __RISCV_ISA_EXT_DATA(h, RISCV_ISA_EXT_h), > > __RISCV_ISA_EXT_SUPERSET(zicbom, RISCV_ISA_EXT_ZICBOM, riscv_xlinuxenvcfg_exts), > > __RISCV_ISA_EXT_SUPERSET(zicboz, RISCV_ISA_EXT_ZICBOZ, riscv_xlinuxenvcfg_exts), > > + __RISCV_ISA_EXT_SUPERSET(zicfilp, RISCV_ISA_EXT_ZICFILP, riscv_xlinuxenvcfg_exts), > > + __RISCV_ISA_EXT_SUPERSET(zicfiss, RISCV_ISA_EXT_ZICFISS, riscv_xlinuxenvcfg_exts), > > __RISCV_ISA_EXT_DATA(zicntr, RISCV_ISA_EXT_ZICNTR), > > __RISCV_ISA_EXT_DATA(zicond, RISCV_ISA_EXT_ZICOND), > > __RISCV_ISA_EXT_DATA(zicsr, RISCV_ISA_EXT_ZICSR), > > -- > > 2.43.2 > > > > Thanks, > Andy