From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900E0C10F1A for ; Thu, 9 May 2024 12:40:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 026AD6B0083; Thu, 9 May 2024 08:40:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F19176B0085; Thu, 9 May 2024 08:40:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE0996B0089; Thu, 9 May 2024 08:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C04476B0083 for ; Thu, 9 May 2024 08:40:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5DABC1A1523 for ; Thu, 9 May 2024 12:40:11 +0000 (UTC) X-FDA: 82098815022.02.3F5C996 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 9EE32C0026 for ; Thu, 9 May 2024 12:40:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Ee/2otxe"; spf=none (imf28.hostedemail.com: domain of BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715258409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P/Yh6fmWOx0S3hHFDnR/3XNxSMU0c5O7DQ9VhEI3qZ4=; b=FMsvrDkn7UIQnZwaL5Ec+5G9+PC3k3KVliNjMGdQfs/458ptFDkBXT35JPl8x+4Et/rJQt Io80uRZH4lfl5+yioGxXi+UsOdEdGm+2VcLInPjDs9i1BN+ctHvB2/SinFf3xnlWqpIoWn hFssbfrQ3N+liwS83w3Kce8oQKNYImY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Ee/2otxe"; spf=none (imf28.hostedemail.com: domain of BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715258409; a=rsa-sha256; cv=none; b=YI+8+PnF5EvAX8kfB4aI1QSiMN7/4f/Ss40VPoo6CzvwJr0Oh3gO1dohgkzPlFhBLU9vkD fyGCLPkNFnc75Qvw+zW5WVYFAmo4YuqPGV0h5vRROGMdLmRizkxflIp2NUZzD5nLS9syHP mq6fV23xbIhM7lW/tKK/P9mn2SXz4XU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P/Yh6fmWOx0S3hHFDnR/3XNxSMU0c5O7DQ9VhEI3qZ4=; b=Ee/2otxepDaoDyWBcWwFyiIctq nqoj0uR7R7rKU2RVLehLlBSEbFOIzg3Ei49vP9t0eZfHXbnK7Clo4ViqVb2Eja8jvDoFoOTO7KzS2 mx0+KGb840gHS36HB/TO+kOV3kAi9xSNAap53ofcOVYJn54tWWpd/4UJL62TiOyvKVqCS9AMgY1H1 E8R41KbrN0wd6lmELud0Aer8PlF9GNud2sqoOAkxfMREoWS8Fpdn+2hR+mRQyF706nSm7HCCNFC7P sKuzRooBCw5ovFR3K20jpikuGw2ivt218HNx5m6JJwCgrgrc3OArj4I8OPVW2Pp+0bUA1SLr+L/1P 3czW+isA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5343-00000001STi-2Jqg; Thu, 09 May 2024 12:39:59 +0000 Date: Thu, 9 May 2024 05:39:59 -0700 From: Christoph Hellwig To: "zhaoyang.huang" Cc: Andrew Morton , Matthew Wilcox , Jens Axboe , Tejun Heo , Josef Bacik , Baolin Wang , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [RFC PATCH 2/2] mm: introduce budgt control in readahead Message-ID: References: <20240509023937.1090421-1-zhaoyang.huang@unisoc.com> <20240509023937.1090421-3-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240509023937.1090421-3-zhaoyang.huang@unisoc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 9EE32C0026 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: grhpq7idhb1nqspkn55cbb4zo6kh9jxb X-HE-Tag: 1715258407-313569 X-HE-Meta: U2FsdGVkX1+f/rE6Aa6P3suI5jENsfVXLUqqHF+sQorqzWyIPgFfJT9l2lC9b4/pvmQZsUwqRm5uyF/KqyDHKWzbbj9IqknSeWO9T9c3pfxwuY7HCvLc7CGyWTBj+RTJ20drYxcYMAJZKbdaZA9M2H1G10FnDIUrvKqTUdxf3Bq8z5f0n25NXxvFt6P4SW8P9VBJmTAbaHpKGqJgerrSoMpRZhXbail9bRPOx3DwI6zKPEXohieZ+NvK3hdg2dIQTWWaCqEp28SMWq4bAf7seAEAHUVIzvJMqJpC6vuDjhx1vWuZNJmSnZYt4o/8qWJqM3UWTIM3xGATKPJpjuRwT2sN9Dc8CXnvZMlLEdafeU32Y8jfmRIlOGX2vJHVNV8nwBFdUr/41GQFRglZOMFlwpkZ6udZjmEwMvNw17Nkfs/goNcM6c5nmhShSvwk2DoHawcelCvBcpgo7yrM1KOtTwRGz0vHbRdxMbV6tLLNyctkhq68uWoqZgAKMDkjXyeQsezTpLC0Bxc8YPAWl7+7uvsR4Q53DLJB1DJIG/UIlc6G3FA2hm/J44gtxLeh/L6uoD8I0LE++5wVLlEHJCPwLLUw9cOI0cLrG7haHrx8iQU9yzdyA4fQELwGk+ITnE1bJ3ZVy5gBtii1s2oGvFhrt8kx28EGiNGOWn1q1BfOZq9HmmNmHu9lWWOSuSvZCIBj5EKHPz8mNjhewuNxT061ZatBMM2WeVM+W4g8R3EyyEMUK/kWsc423vQN2ghTzRbiMaZFzFwN6fen27jlkxUqXRvfVs8y/hYEhN8E1/G02hu6ruemNvyx1PRPhzgIzUiHs72akg6U3oO/KBAyrnDi0VNIylYR00eMcxLHaG9BmusWviTKFHmZs1iRm1Konbpu2yS8dk8FJWUQgJqm8IK9qkZmaE8oVDyen8OMdcJGRZUSFDl2e08W/M95X6rDQdFqfafgrTUprjfiMCYpENY i62aMKRM Pmkc97QMEH1eB4QhCScGKlf2NAhe0Jo6KYI6idByD6WES1p03cbU+Vm9akGXX3YVjfS5EV1IVSDL4lfBR7JtS0InLD6svYze09L/LeBmEfiHFk8PadfHvLjsiQnGmNb9LtuSRU36g01irLCze+VYViLuxg9GlzmLatPbi1+ReAR2cTEb2ebmLlku7xrUbqR72mcAL4yTxqo38UM83ENd+Pq3+02l8AJRFyNli/TRXGQpTDxyDNmRVysUhfAHPYIeWY8ERbi6e1SxwRb9xwR+aXljw05R9/mp0VwO3UFDxjUTGb1++Dyncv2rnNxS9toeuSXBCBYiCBhj1sGkpaheWLDJez/4Bep07TZIBywBYWM3mOQb/WEcfSf/kaiuvFVs2cywWaVmA1jhl3yA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + unsigned long budgt = inode->i_sb->s_bdev ? > + blk_throttle_budgt(inode->i_sb->s_bdev) : 0; The readahead code is used for all file systems, you can't just call into block layer code here.