From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3D0C04FFE for ; Tue, 14 May 2024 20:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EDF86B02FF; Tue, 14 May 2024 16:32:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49F5A6B0300; Tue, 14 May 2024 16:32:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33EDA6B0301; Tue, 14 May 2024 16:32:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 162696B02FF for ; Tue, 14 May 2024 16:32:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 93C791C0B1C for ; Tue, 14 May 2024 20:32:53 +0000 (UTC) X-FDA: 82118150226.20.FA5B8E8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 502E9C001B for ; Tue, 14 May 2024 20:32:51 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LukJ1p5P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0I+MOdkt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LukJ1p5P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0I+MOdkt; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715718771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kk3PUJn0ZHUnCyV3wo0S0YEaGX6X5EGmXK7wEUx20rU=; b=0ohxEG8rWUoTRazrpxGFNgICU2AySUG1Xq8iM21zpe191XmnAhrlrocVQJD/UeRJW7Nwcm dXYcwpMNVH/ZpPf7fXF07BPpPmzsT4zC5L6FbuOPtJwcFi92ihMThSsCXtXzUcwvQ2QG1G MoSAlH6h6ozdlwpDoHMsHhdHWAdEjIk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LukJ1p5P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0I+MOdkt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LukJ1p5P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0I+MOdkt; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715718771; a=rsa-sha256; cv=none; b=1VsTe52J0Xp4mTXD385ryd2DTgzKVHLuugHydznhal6iNeGPdCfTsyZl/BACEBLS/k+SD3 F5agc9dsM6m7hXXu/JzURvTjjKnG6gKpYfsMecBHl33ARQhaUbTgNqsTv5+kKY1Be1ZZ7D eDQygpC2oCOX+k8xxWnSVOE0NMUaapQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 948CB1F911; Tue, 14 May 2024 20:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715718769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kk3PUJn0ZHUnCyV3wo0S0YEaGX6X5EGmXK7wEUx20rU=; b=LukJ1p5PWWbiu3qKRQ/sdBVZjjoR0JzQ24HSt7G0MajKuuOYVYByXM20LDzK5JbQMo4ziE z56/SLJzivpZcOuRUZw98Ki+vjMIlh040AIgK3vCWPnae6g4phKWqb4LsXlpLf2oKOt2ie kBrnRmDUjemc4Kg1FQe04AfOtXVmfyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715718769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kk3PUJn0ZHUnCyV3wo0S0YEaGX6X5EGmXK7wEUx20rU=; b=0I+MOdkt9NAN1JNbZ+9l7B9kHwT3WJVbIfpIfdTQse7f9nh8EeVYBmLj1d8T55ebexCPns 3m0Q9+x/wNs3lhDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715718769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kk3PUJn0ZHUnCyV3wo0S0YEaGX6X5EGmXK7wEUx20rU=; b=LukJ1p5PWWbiu3qKRQ/sdBVZjjoR0JzQ24HSt7G0MajKuuOYVYByXM20LDzK5JbQMo4ziE z56/SLJzivpZcOuRUZw98Ki+vjMIlh040AIgK3vCWPnae6g4phKWqb4LsXlpLf2oKOt2ie kBrnRmDUjemc4Kg1FQe04AfOtXVmfyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715718769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kk3PUJn0ZHUnCyV3wo0S0YEaGX6X5EGmXK7wEUx20rU=; b=0I+MOdkt9NAN1JNbZ+9l7B9kHwT3WJVbIfpIfdTQse7f9nh8EeVYBmLj1d8T55ebexCPns 3m0Q9+x/wNs3lhDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 90A4B1372E; Tue, 14 May 2024 20:32:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kE0NIHDKQ2aOIAAAD6G6ig (envelope-from ); Tue, 14 May 2024 20:32:48 +0000 Date: Tue, 14 May 2024 22:32:43 +0200 From: Oscar Salvador To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Alexandre Ghiti , Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 2/8] riscv: mm: Change attribute from __init to __meminit for page functions Message-ID: References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-3-bjorn@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240514140446.538622-3-bjorn@kernel.org> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 502E9C001B X-Stat-Signature: 1k7bd6c58jwy6mnuc6pmzgpiesczir14 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715718771-505905 X-HE-Meta: U2FsdGVkX18vof2Djr1EqYz309jiJ3nts2OpYVriAJGAqv9stuFswOFKbwFotqyiJg8Z6RufpyZKmlpf7QbGKXRCg5qZtrxq8+ifP5CmX2lw1jsrzqX9VpBm0fvkjmZ3zAjxRNEJsMx0RuX/uZfY6F/+NyCWhN1EO5ggh+wKtmVzg5PTiWsHPbo3H5SJW+oFasW+yyK0iAZFCFbfvPbkAcyLd6V64QTUWL2Zd+gV28KA+YMc1rD02eDRsPQhQ1tbqQPg91XB+KckZBHMBwzC1PwxEmtzwlBpHugMCpTtOY3FupZhXfVpcjpUT5RYG4KIly35QRFFWAA8LUj5itb8LIfDE4dpgKmU51N5uy6YCJDtfPehY6YtK6nGXb2fXVa4DdtXCDmLNqSPjaF0UBM7WGMnAS7VYAvh3f74ARrFhboitEnHECrmSvgLU7a/MYEjv8vJ42IzGZSYKuw1SSQwPSmQOrnQwFNMA3w+7Sb5doY2SK0ZqpGRj49zxnVEEKorlVhJtJ1K/SHigi/8kfK/VTH1GV4Kh3foRyRf7HjIQ4CFfnrt7UpQ3C70wgYtJ6bbrN+qoMymkEElU9zk+jF/sc+jhBGJ9JwLGtzsS1tBKwz69sLIqfg0i44RkcYlp3SA8gpkZvQ6hKFDftQgcdR/jBf1KlQkGH1Ae8bfQ6UHT2xKW2bnGBjGtyG/fNm4ad41YU3vkhnaRC6bWPyktQX2MEFLCYZ7ttH2LjzsBY6MUvXeVho9+2sD61LXD6fZojCerWEuOqTFKWf/ZaVwNnrTUOdtX6qNEEvpmX+01nljmeHNqtYPgjBV9RtI48mB8xeoP+MlkQyGFM3kMnPY1D8UGOT7CG67Wec6kZD7Sq1nr9M4gVq6FLHvryg0ZR1dlKAfxFPcO+gB9/mnM2QLTsVVKSNQQiOiW8IhjiYSALstLoxSbBt0cH32GW/4Sn0PtK4aL6W1iSCzV4flS/aBxNp U8ovBqK4 Akj2/6OgyDPLCUpx2BS79/LZC0gfXLARjqpGbM+2QszedJStHcKYlPf4bvB2BGWAy6w21mIRFPG/EudQ6JUTIoaDQsFeg4ErSYkJFWek3V2YWu6NmcOrpKTc2I+UBLqGcqpumzSVTq4zE9ffTMUF0U060Fi2A0Iu+FJw67JvFberpG7Aj78Uu2+AVbjW6tEDsDNf40kd4vdZsv8hPEAL3JBaAS7h1LQ02xu4yGxeuBl6bCWDS1XzqKPKiXN018ajDnusqVBFQhTNc6DoHgIHAE+JxXPz9Y/dDpQWxfwpvjthe4sKZPcSSroNf+bUvq3CUS968PFVuFAneoDtpzSIENk9Meg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 04:04:40PM +0200, Björn Töpel wrote: > From: Björn Töpel > > Prepare for memory hotplugging support by changing from __init to > __meminit for the page table functions that are used by the upcoming > architecture specific callbacks. > > Changing the __init attribute to __meminit, avoids that the functions > are removed after init. The __meminit attribute makes sure the > functions are kept in the kernel text post init, but only if memory > hotplugging is enabled for the build. > > Also, make sure that the altmap parameter is properly passed on to > vmemmap_populate_hugepages(). > > Signed-off-by: Björn Töpel Reviewed-by: Oscar Salvador > +static void __meminit create_linear_mapping_range(phys_addr_t start, phys_addr_t end, > + uintptr_t fixed_map_size) > { > phys_addr_t pa; > uintptr_t va, map_size; > @@ -1435,7 +1429,7 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, > * memory hotplug, we are not able to update all the page tables with > * the new PMDs. > */ > - return vmemmap_populate_hugepages(start, end, node, NULL); > + return vmemmap_populate_hugepages(start, end, node, altmap); I would have put this into a separate patch. -- Oscar Salvador SUSE Labs