From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D1A5C04FFE for ; Tue, 14 May 2024 20:37:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8F896B037A; Tue, 14 May 2024 16:37:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E40096B037B; Tue, 14 May 2024 16:37:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0026B037C; Tue, 14 May 2024 16:37:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B16F66B037A for ; Tue, 14 May 2024 16:37:40 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 66CF6A2189 for ; Tue, 14 May 2024 20:37:40 +0000 (UTC) X-FDA: 82118162280.23.37D715C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id 20AF3C0013 for ; Tue, 14 May 2024 20:37:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZpObK2ca; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UVARiUEa; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZpObK2ca; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UVARiUEa; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715719058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VYsW9Vv80A6GLzgjCSYellhzJczA30skEMWWKeZBbJk=; b=T9VH7lp4cTNIeaUgr5JBFLjlk/sNpBz0Rc0+Xv6Bp8rvcyJiHVMtogOl/zmS76obGYxGM0 YcT/5jhiAQuPx1sZPSMXmN0lwWWDVW037KatvIVuoarew/eXt/yj6ZPosM4vy+2rgMLvfs lVgX2x2m4xoLqchJgI9qFYXQjlvPTMs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZpObK2ca; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UVARiUEa; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZpObK2ca; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UVARiUEa; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715719058; a=rsa-sha256; cv=none; b=rcQy1EA7WlXYONQ0uD47FP+E7D5n5v1oTkioGAEGPZvwY0j9FjPuEztf6An2uIMaDusEvg oWjFNSv6AUAM4eTUpMn8gCK+7sTehlqHBjlYMj7WCZfkO8exaZl948nwn8AzsLga9ddLyb n6/ZkKedI848VFb0h7AwExmZWGaQaxQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6E0E01FB48; Tue, 14 May 2024 20:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715719056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VYsW9Vv80A6GLzgjCSYellhzJczA30skEMWWKeZBbJk=; b=ZpObK2cayBrGFB+P30B4ta0PrzL46RFr44vUY5OO1vAowzek8thfNxxeOGE4BRsC7fIwDq +7eTpVOAzgxb7RFh6pnv6Q8JBVIOkawpsPDcTa2ObSEicYd8rCm0YADkPKTN8xOT7XG4tp dPHkjGGM+KVPvwqMxmeWz35c4ilgZQ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715719056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VYsW9Vv80A6GLzgjCSYellhzJczA30skEMWWKeZBbJk=; b=UVARiUEao8bnM3tGOX6fumiBKcLPbudeKiBmMYfi0BLZlApPyZMjtuUZjjsrk5V1d0PyxV o55zuYS0CbLs8iBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715719056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VYsW9Vv80A6GLzgjCSYellhzJczA30skEMWWKeZBbJk=; b=ZpObK2cayBrGFB+P30B4ta0PrzL46RFr44vUY5OO1vAowzek8thfNxxeOGE4BRsC7fIwDq +7eTpVOAzgxb7RFh6pnv6Q8JBVIOkawpsPDcTa2ObSEicYd8rCm0YADkPKTN8xOT7XG4tp dPHkjGGM+KVPvwqMxmeWz35c4ilgZQ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715719056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VYsW9Vv80A6GLzgjCSYellhzJczA30skEMWWKeZBbJk=; b=UVARiUEao8bnM3tGOX6fumiBKcLPbudeKiBmMYfi0BLZlApPyZMjtuUZjjsrk5V1d0PyxV o55zuYS0CbLs8iBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8341B1372E; Tue, 14 May 2024 20:37:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IqYEHY/LQ2aHIQAAD6G6ig (envelope-from ); Tue, 14 May 2024 20:37:35 +0000 Date: Tue, 14 May 2024 22:37:30 +0200 From: Oscar Salvador To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Alexandre Ghiti , Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 3/8] riscv: mm: Refactor create_linear_mapping_range() for memory hot add Message-ID: References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-4-bjorn@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240514140446.538622-4-bjorn@kernel.org> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 20AF3C0013 X-Stat-Signature: utr8znp9ba9yc7offqbnxbwrhtp66wao X-HE-Tag: 1715719057-471021 X-HE-Meta: U2FsdGVkX1/xg7aqFAWVwMo0zZaMY6Ycmz14FWSeDZISwC3PYc4+223EV2ClhcMgtDNJBT3vfWZo2Vce+hF1QRh9hVK7jvOzz5GKfWY+Olwle1dvzs286PytIrrPSOAjYDCwU+ikinE1NjoXjFWKgFJwtdy8HnqHw6z3X/HI7K1p5IbhSQv5zuXL3A2IOIS3N1lgb8VSbIg2ZyV/+qUhTEOKPlMY17l8TvQegoRaCZPQKZDzCCCZyEGiobZ4g7wvY6/cQfjIluRwlUrhzKpn4bXcdWv8jaS8P0/B/nzhVgZQSLJ9x9IzUEJ3dcoXRXLewOc9//4Q5bqGRClp276fwCm3u4UJ64xFNba8UwxKDQJaUAJ+zP+q4MGYtyTnpRu7XgDQAfrRyVuFllIen7sBIqFRgBkfXxOFY8vlVxRVCuOKwLcYv7/Me1unwXQh/1QDjDuJ6Y0akkjsXyPz000SLBmUnEcphVTpxwstGUnU1JxBFedrCE1PvzLjkPwqMJsllxdT1MxhJgbmY0uAVEjCxm9eFqcIGqYaYf62c8Hs1XJZjXQy6QCWjRqAYHDn7Otoj9gWrxPRnv1nerzqF0ET5UT/A7z6vneV0xIS51TnCXXKBsjeRUVkUmjF1Gj8D0l7GCR/d6kvoOnu1zeMzpPGPKZOagm335R4znR/tM6lfrah90BXckV9AebBnsOtzgGWSzjP3Cyh+ykZjDdVNjqWrzVw3G1tioBA7AcNMrP9J7U4MFSk83SdLYOS7JQoxvVnVyafR1CGWDx2g86CvBx9qeesevZDCOjD6tQW2PvYsp2u78iki1GuIym76WTCHpKDb9GCbLnPdavnPtVMp8I9H25bBpmcsScADdFQ7ne032igxZpcxPJUi0gOSXIkvU18KaXurLyIwzombY26GwuK1Ymvf2dPutfkEcA1Z/H0tP8aH+vkrPke1RczCg+ChSrWNdZ8cwhQmwJ7MJvUwa5 zqTHcdam eqkJpvI4VmAyR21raLVyJbrj4yPcuRtBwTfJNx4h399458e6q7XT2muna+eRpMoDZZ2vPH0nxi/Ho4Y5eC12Zvl5uqrFEctMre3nJeEjN7Shepz5guWNrXNQnp0hB2z/wN2JyKXnGY6kXjtkkTc5fzG2SPFhwGtuztxetnEXXlC1SSwXWhvZFMutN10eP/HC91ilf4uYoqvMtt/mTS6/XX2he/6TI0jB0Gt2G676mVo5jhfQP42qfSDOSoqRo7Z0RQW3zPawjhPDBsGbILRUAkt4ezKXU3rdbOXnkyE28M9knBbnH7sQUteWcTiucrbV1jrwKwK9Iz5Bb+ba5os9olMQ3HQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 04:04:41PM +0200, Björn Töpel wrote: > From: Björn Töpel > > Add a parameter to the direct map setup function, so it can be used in > arch_add_memory() later. > > Signed-off-by: Björn Töpel Reviewed-by: Oscar Salvador > --- > arch/riscv/mm/init.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index c969427eab88..6f72b0b2b854 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -1227,7 +1227,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa) > } > > static void __meminit create_linear_mapping_range(phys_addr_t start, phys_addr_t end, > - uintptr_t fixed_map_size) > + uintptr_t fixed_map_size, const pgprot_t *pgprot) > { > phys_addr_t pa; > uintptr_t va, map_size; > @@ -1238,7 +1238,7 @@ static void __meminit create_linear_mapping_range(phys_addr_t start, phys_addr_t > best_map_size(pa, va, end - pa); > > create_pgd_mapping(swapper_pg_dir, va, pa, map_size, > - pgprot_from_va(va)); > + pgprot ? *pgprot : pgprot_from_va(va)); > } > } > > @@ -1282,22 +1282,19 @@ static void __init create_linear_mapping_page_table(void) > if (end >= __pa(PAGE_OFFSET) + memory_limit) > end = __pa(PAGE_OFFSET) + memory_limit; > > - create_linear_mapping_range(start, end, 0); > + create_linear_mapping_range(start, end, 0, NULL); > } > > #ifdef CONFIG_STRICT_KERNEL_RWX > - create_linear_mapping_range(ktext_start, ktext_start + ktext_size, 0); > - create_linear_mapping_range(krodata_start, > - krodata_start + krodata_size, 0); > + create_linear_mapping_range(ktext_start, ktext_start + ktext_size, 0, NULL); > + create_linear_mapping_range(krodata_start, krodata_start + krodata_size, 0, NULL); > > memblock_clear_nomap(ktext_start, ktext_size); > memblock_clear_nomap(krodata_start, krodata_size); > #endif > > #ifdef CONFIG_KFENCE > - create_linear_mapping_range(kfence_pool, > - kfence_pool + KFENCE_POOL_SIZE, > - PAGE_SIZE); > + create_linear_mapping_range(kfence_pool, kfence_pool + KFENCE_POOL_SIZE, PAGE_SIZE, NULL); > > memblock_clear_nomap(kfence_pool, KFENCE_POOL_SIZE); > #endif > -- > 2.40.1 > -- Oscar Salvador SUSE Labs