From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CEAC04FFE for ; Tue, 14 May 2024 21:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 657308D0051; Tue, 14 May 2024 17:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 602448D004F; Tue, 14 May 2024 17:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A2A78D0051; Tue, 14 May 2024 17:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2BC968D004F for ; Tue, 14 May 2024 17:28:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A73D2411F6 for ; Tue, 14 May 2024 21:28:33 +0000 (UTC) X-FDA: 82118290506.23.F840C45 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 7AE811C000D for ; Tue, 14 May 2024 21:28:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r+ym+12D; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715722112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=18MZUUawb/h4MdJ2B0MrgZRDL4PYAEDgDX9KON4i6lc=; b=jH5/GIh3BxkkAcSU//pYihC1HzJrQ+UFmBVP58JPW/LMdlMZnjUOxsP7MvwE1vwzv6vAMf dWHbXUZPoRK60C8j5f0ZCOL2suq/GdMDPUjhi0w/tJV9OK/h2Ho4tMWMhpqoGRAnZkdykf 44BumjRs2LuZfGFM7XnCuLLe5xhWnZs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=r+ym+12D; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715722112; a=rsa-sha256; cv=none; b=FbHAIJ+UHtCU24PZU8PB7nlb2lXNbSa0i5x5H/xvEgLI5HJ9gnHFwCplq/gOiAqiS3/69F u3iaB/SHb1mHRBmRNUWr6eX+j9Ex76kji6KeSvi+t3fGhzvzxGzuTGtcXS2WkpbTKJdSyj wIlp9vZ3N1iTh998MHbXeeNiqUGWvWw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=18MZUUawb/h4MdJ2B0MrgZRDL4PYAEDgDX9KON4i6lc=; b=r+ym+12DadmXIqEpLKf2643jfL vyQHT+0RozPUfuV+RVz0aW6W8NuvhWmjpAgP7GeFcXlmaVBgCz/9eW6kfqGkGbXPF2QhtH3+J08rY ydmGCoc/qzLKre6U7YSK6rkO1m/SmtV0REeYhGVbZwgPeu8a1j2M680C+hed2l2cD6g8Wy22mKPvN qhPd9bzVX5ZScN/8atD34ZEXC4GDUKFEJ8jo4w73HhFLzfm3tkTBHbKpeoK8ggAgFS9bwvHEdaso9 nziKaHoELR3qKSgWGMgI5TNPaWcpkGJXCcX+/SZM9qtVMubjtpzZG9Dk6cyvwIbDa1uZRbflV893d c/oZ/jxA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6zh3-00000009WDa-3cXA; Tue, 14 May 2024 21:28:18 +0000 Date: Tue, 14 May 2024 22:28:17 +0100 From: Matthew Wilcox To: Jonathan Corbet Cc: Andrew Morton , jeffxu@chromium.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Subject: Re: [PATCH v10 0/5] Introduce mseal Message-ID: References: <20240415163527.626541-1-jeffxu@chromium.org> <20240514104646.e6af4292f19b834777ec1e32@linux-foundation.org> <871q646rea.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871q646rea.fsf@meer.lwn.net> X-Rspamd-Queue-Id: 7AE811C000D X-Stat-Signature: bd7khr4zdho3qia3zmt9pijj1ebqkjgw X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1715722111-326528 X-HE-Meta: U2FsdGVkX1+d1R6LF1CXIEYMDle/oSelqr+qnDAD7BCJUo2Fg71dupzKwAKKVfxxqxvZwNjZgpcaKLzxL5a5I6VCnX5YCgueYdvjP1nFk5KLumnGKk4wrYcJYccAz6mE87oMxVmlAbY/FrY3oqzEUlYRVWH8nplcTFwS1ebNFVBqB4bLalz90ZGAcnLHAxuRtH8Lp6Uz/GSp3fB9G2He0plSlaq+pt2+/e0OHYuImt/J1GCgrxkyg0a60foPKAAsag5jfg66sLi+vULPSGvmLpqBuy+6aQvechfhcNkrCjdsEeDNu4nYD47Ap2mXNYZ2PomduPNilH9wQlRaBmrUaQGokQ7gDXxmF7lxn4+HraQmTVliE6JKIpTLGlG2Vxt5iO/HJUltw6LlZ4B14JzFyjAIvvprcQcZQDo1NnqECfqlyFrmWWpT4sG8n3hT+eOfj66okAt2SBWIhbowVmp5n5X0xYPFULD9fR9YYdUOhOhX+pRzkGVvCjxhi/mhuqxggkcGqiaffgHKU2o91gDucCELk86ZAdADBJgjPlOpXZpH3MzYSWkhWAKfvpUIc+oJEFRD9PKp1OSdjF+E2zcRy0914zFECFp19tWIPLzuVoM9tETzbkn+84y0zTqMuynCsvkVpH1uuySnjBC6/7NIW1OFkFP6p8nPgzL97CsqlWlF9SluTWjD//fGlo/FXCaBGaKdR8LtY+EzhIYvkgtI2vpLAdWA9zYln0zuWV4EFne9Eo3uH73uiyrlff6Jx/S1bYhjeULW541v27HCjz9w1i7G+1Hv4NjTfVzbJjWFXknBtT0PaWG86aLUiiA4cl9f7wJHm9gvrzidbTAn80J8yuRUV4nzkvzmO/sVuy5Ecvdmn42/zjKN5yr6WnTX/XeRLpYyeu/2XM3iVS502J2D24/wMKoa7HxIGLp6lylDju9tfEINEV7YmeYYb5Uz4WxZ3zS50JTUAbBZq/5peKF MaAaQJXu xx7f+F52Rkn+SWqzX8ZH4Tw3bJtZZ7y5bPfKpILvAgCIdLUo7KHXGigo486iAYALl1rTbkfRE1G5t0Z2I9OA+FbFid65oJzGYaH3TD/fSWjcFSloOHvwK070own1SmX+uf/qWH3cVnScQ32nbFKRg/BQ/UZ+ht5wBUiJv8bjpJJr6RWqOUuwweEN1hlQ/lp93J4SxXAbmFuw/wLCU28aZlWrRl05e3yT+rlUC13XYha4xxMtUvnknRtNKMSQEg1dYSLDCr9Kw+y+YmiHmQPU8l7yw7wvuAVCl2caHfXIqDVHMJ3BQiyqCd41k0n9UF5oeSpiIKAbIAF2gkbJROfA4jPp27o2pd33ojJ4I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 02:59:57PM -0600, Jonathan Corbet wrote: > Andrew Morton writes: > > > On Mon, 15 Apr 2024 16:35:19 +0000 jeffxu@chromium.org wrote: > > > >> This patchset proposes a new mseal() syscall for the Linux kernel. > > > > I have not moved this into mm-stable for a 6.10 merge. Mainly because > > of the total lack of Reviewed-by:s and Acked-by:s. > > > > The code appears to be stable enough for a merge. > > > > It's awkward that we're in conference this week, but I ask people to > > give consideration to the desirability of moving mseal() into mainline > > sometime over the next week, please. > > I hate to be obnoxious, but I *was* copied ... :) > > Not taking a position on merging, but I have to ask: are we convinced at > this point that mseal() isn't a chrome-only system call? Did we ever > see the glibc patches that were promised? I think _this_ version of mseal() is OpenBSD's mimmutable() with a basically unused extra 'flags' argument. As such, we have an existance proof that it's useful beyond Chrome. I think Liam still had concerns around the walk-the-vmas-twice-to-error-out-early part of the implementation? Although we can always fix the implementation later; changing the API is hard.