From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23588C25B75 for ; Wed, 15 May 2024 15:32:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 445066B03B5; Wed, 15 May 2024 11:32:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CDE76B03B6; Wed, 15 May 2024 11:32:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26E796B03B8; Wed, 15 May 2024 11:32:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07FBF6B03B5 for ; Wed, 15 May 2024 11:32:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B04D9140464 for ; Wed, 15 May 2024 15:32:48 +0000 (UTC) X-FDA: 82121022816.13.4E14586 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 75854C0024 for ; Wed, 15 May 2024 15:32:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GNj+3l13; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715787167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eHwfVCsafGWvDE2TzhnqZg+hhQAlEsxHQ1ZY8ZtSmbY=; b=Y7wRWt2PtcqeXWbsMW9WzD2kHeKXlji0jaoVOK10fwMi7+dNNgECbUduYWAvOXIHEMAZGY sAKLN/5iESm2fxfWr3XPbbk0uIcvBH08q5Bgqe9ixPMaTiRNLRwRftc16EatzK6I4+ErPR 31YaUG2ZGKXWAHXMDPKekeTyNmHCbI4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GNj+3l13; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715787167; a=rsa-sha256; cv=none; b=fgrFyFzCkMG5gsklECvklPZRwUFo5MT1H2I/sSzxiPzF7VPZcrmZFzsVa0kgit7EZFmsKT CEnygzBF7TXzeXhxToYDSOfHsq6dR5SqZpxLGrRzdb0sDEVRNMXXDOPQiCN2D0n1TN26Fk pnGkBC9pv5eTfMyE335ZCwP8i5iQhOk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eHwfVCsafGWvDE2TzhnqZg+hhQAlEsxHQ1ZY8ZtSmbY=; b=GNj+3l13CuwiMRDMw3zv0BrxQF v31PKlvcnCFAzhv0Ka9pkJo6IS4saac/L9JyyvIETVT8oeuzU9V7xXNFyaW7OcjDgIrRR29+0QLsG sy002gR8DfLW2b3W7t600g3i5FXw4v5QeY08x5oyXJut9o6CVxRFotgBDzbm/J1Fk36nF9Cmbg96z gnbUu3Frc90Od/IdaRRM8R/t/Zh1tAC59LwDojYZ36vQ3ZeTN06WWyeE7Q93Ew5kdBm1IeWAioVST yas1kZb5oF9Tp2u9lqGw6Q71mCe4Rkf+DZ10XIzdM308xo4mDkBMvR6IBpz30t+nUFMvAbWDufbtU jDd8bkew==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7GcO-0000000Ab1Q-0wAA; Wed, 15 May 2024 15:32:36 +0000 Date: Wed, 15 May 2024 16:32:36 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v5 05/11] mm: split a folio in minimum folio order chunks Message-ID: References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503095353.3798063-6-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 75854C0024 X-Stat-Signature: hjxheumr33yhcz58rnwhki9knd51f3kk X-HE-Tag: 1715787166-190922 X-HE-Meta: U2FsdGVkX18xjEv6An0kKGDsa2Wyg8eKodGKBXP5dzA6nYssda8/ConTP5zbLvfT1iTPYU9yJHLExo+yGJElvuKfSe+Y774njXuYdLFR/zREMraw/EX/ra5e9J7PeU1Y1VlbXCVub7QJTIZdJ1tjTShml0YBxOKA5+10Ypsibg61HPYxm3dAWV7HmcCt4Pad/xlCQuBUzEz0EOtP/+cdS+OD9mfxLNkYcqpOG5mk2lihZAZdcdxmXeKUvNLwZIuQ8NMqYV99McLLp4M/zRxLgq2dn6kxgifqAxd71wjYOOUlpnXIwjVISJLusVJd4diq+cDhAhxfeYzp4bIisTAlTrjwf1eH10lsspFt75dUaGfUUwL2qz6s3E78lBLvJ+xx3n7D2MvsUJM19ZftP+ZGqGaD5VxW93tZV23Ne5O/arfno1jbzZJ7so2WlCJ/UnDPdytSQFeZ4qnETEPgG99ax9+T5JrPwbMUhzQKoQtFjas2VsLHZZSNcq7DsURLgnB/os7eM1rKUHsA12+C9Owq6x8AfPPQ89wiGxtP55Q1zNLXRp70TKt2SdG2wMMw+6FKxP+wiBpU/Fmo6NjE2MXly2z8wYBnx4esVonwmT7HQdS9P5tfBtucMPjss/SSLGMJ/IE1h9MIQ8HB/1dgCul4fsJHwWkjwia6POQLdh8nmGQUSMEdTvCYwTHqF9cXdDwqb70RbQ6T/oaAtEtSvlN6YHQ716SNRkgAg+QVtEgPYhqa2rjpoj3o4p+ASzN+pRDmYB5E7iWhQsESdiemYLyJEGI709TxR1+BpsHIlT0Qfzzf9XjadZJYSM7eXbAdu59qLDTKSwzUXlfmeaYh0mCYllUK6l5O0wrnysGVl5mtkg0pe5BxXVfGUWWHN1rHUY+e32RyYHrimV1MI5g1be37gkD1xKSIp5S0j3utoAdp4TaZcP/+wHOHKxlJodHAdMSo+rzNDUfVf2nTPLEd48A 0Ctf97vW 6UAccvLtaVRRdRS6AXdQCqfli8Kwtw7ZhYabdD0vLxGYfaaXn1uqdfNZppBe/tNtxefbTzhae/rp61SGb5veDo8Xdg47ye8VC4Pd+hFZb3DxmxAM2zC2Bk4Z4KI19o1cqsV2MPYzJJ0k5IMPadcJ+Cl48nEE1s9gmeXgJdXu7HjGlNhazdH525Jpm2V2eNakV7CfOgf6s646XGIo9zi/2Zv9u4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 02:53:47AM -0700, Luis Chamberlain wrote: > +int split_folio_to_list(struct folio *folio, struct list_head *list); ... > +static inline int split_folio_to_list(struct page *page, struct list_head *list) > +{ Type mismatch. Surprised the build bots didn't whine yet. > > + min_order = mapping_min_folio_order(folio->mapping); > + if (new_order < min_order) { > + VM_WARN_ONCE(1, "Cannot split mapped folio below min-order: %u", > + min_order); > + ret = -EINVAL; > + goto out; > + } Wouldn't we prefer this as: if (VM_WARN_ONCE(new_order < min_order, "Cannot split mapped folio below min-order: %u", min_order) { ret = -EINVAL; goto out; }