From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E408DC25B74 for ; Thu, 16 May 2024 09:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DB996B0098; Thu, 16 May 2024 05:07:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58AF46B009C; Thu, 16 May 2024 05:07:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4046E6B00B8; Thu, 16 May 2024 05:07:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 201A66B0098 for ; Thu, 16 May 2024 05:07:16 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 451BC121655 for ; Thu, 16 May 2024 09:07:15 +0000 (UTC) X-FDA: 82123680030.09.D2FF910 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 125FE8000E for ; Thu, 16 May 2024 09:07:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gaF1jYvA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2zl8rMy+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gaF1jYvA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2zl8rMy+; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715850432; a=rsa-sha256; cv=none; b=q1xTskzInfy1JK9C/ng/eu6LjYDRka9SBlUpBKaTEdhBMqDfSlb310VE4VmcSwc5o47H9t 4Cnqonn/qsHaUwQCfTXvD0Ya0SMuJzL3rVwwqiwZWwgHUeOIJf/fVWk7O/2IQBOB1EWLLp +Yq78OVhgDW6biKkns8L0KvuFDBMGgI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gaF1jYvA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2zl8rMy+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gaF1jYvA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2zl8rMy+; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715850432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XLeTIM45ewjev4DQ6PoqdCo+wq0wfEIEwRwtJcI36LI=; b=0RQWrbpzFCwTGJdLemSuTJCRGrc6p3Fi/JmMwn6fW5nUzmv1ZLNZCGxp2fOV7f7BA9mFeH 1oQYl+r1ovn5vzspNSkOEMaohvxc631itEOWaiOZ9L/auU0R8PIvQzlujedEBxkYZS8j6w IZ9Z7KAU3b71cNJwioHuV3RGVmH5f1A= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7DEBC346ED; Thu, 16 May 2024 09:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715850430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XLeTIM45ewjev4DQ6PoqdCo+wq0wfEIEwRwtJcI36LI=; b=gaF1jYvAzi0ecbsxKz4M//m5K4Zr1t/VaydIphUgvFveCyRKe9bsawBXYmn3Tpc/IlJqpy ZyNSz6Bplw3H3I/PFYIUvDagiQrLlWv8vp3L7TAvD2WTBtKEsjokE808qAIsoZF2MaJtDi Qxgw8DjU4Kkxxd+On1lCcDIdBnWykHs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715850430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XLeTIM45ewjev4DQ6PoqdCo+wq0wfEIEwRwtJcI36LI=; b=2zl8rMy+xcbx4jcJu9sQai10RG3tH8Ob/Q95lvfFo6zAZBNVv7cGMiR8hzpgl84xMG+nbf j+/tV4nfe0MdKeBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715850430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XLeTIM45ewjev4DQ6PoqdCo+wq0wfEIEwRwtJcI36LI=; b=gaF1jYvAzi0ecbsxKz4M//m5K4Zr1t/VaydIphUgvFveCyRKe9bsawBXYmn3Tpc/IlJqpy ZyNSz6Bplw3H3I/PFYIUvDagiQrLlWv8vp3L7TAvD2WTBtKEsjokE808qAIsoZF2MaJtDi Qxgw8DjU4Kkxxd+On1lCcDIdBnWykHs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715850430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XLeTIM45ewjev4DQ6PoqdCo+wq0wfEIEwRwtJcI36LI=; b=2zl8rMy+xcbx4jcJu9sQai10RG3tH8Ob/Q95lvfFo6zAZBNVv7cGMiR8hzpgl84xMG+nbf j+/tV4nfe0MdKeBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EBA54137C3; Thu, 16 May 2024 09:07:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qYHNNr3MRWaUCwAAD6G6ig (envelope-from ); Thu, 16 May 2024 09:07:09 +0000 Date: Thu, 16 May 2024 11:07:04 +0200 From: Oscar Salvador To: Miaohe Lin Cc: David Hildenbrand , akpm@linux-foundation.org, shy828301@gmail.com, nao.horiguchi@gmail.com, xuyu@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/huge_memory: don't unpoison huge_zero_folio Message-ID: References: <20240515023607.870022-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 125FE8000E X-Stat-Signature: o15hb539h57wzaz7qh8g9q3zpetf9jib X-HE-Tag: 1715850431-310115 X-HE-Meta: U2FsdGVkX18XYG2U/ZK7mFYYat2OC+YQCPmNDB27R/wf9BHlvE/92DWW+fUSWcIuquqCJXERcC1Bci8BXOw7Bbj7KCAdhgDSRfCgtCY4E1FYt0mXVygp1UKopgfG+N7fZybX+UKCNhejtW4eFmPxc8wQ5aP1bWIGZR/LxLVKJKx/iHj6B9nWVyUENKtEAKhd7i3qBjwYB5BCRehsSsxu/xUH3XzA7bWDKRPaS5TjwDZAku7cnT9lV6X2hebf6pQx+pLfHBPyv7JxJ77FWmyuzI3I6iFAiFdKMkGfJz/K0PB3hdHMrrWNGckRa3X0Gmc7lhl3bRgCM+wmPU2amd0WJedAoDFrznD0L9OuUNxkz8sAF0MhphjHsTT//ytgHDGfzVYC6h8COBMLEB1AKxGXj/wANqNoalTiPh7QrhDA/KrKTNWNujW9dlm9bQ0kQlGsXQe7kqNuhpUElOTkZg2aNLjiL1tw3cXgvn2FRBCxqCg1yj3oz4U1lOuUOjNHde7GqwbQ9ppIvHRKxQwH9PG7LV7Kfi1gaLU6Z831Q8IsGySw7DWOY9oHlPbwS3v5AI9qAv2Le2DJw3etw+ugtEyhctuICz82x8Qyl16h68GTTlmzbfnyWBmGCs915m0FIuJUKLx+6l+MPP5bRBa5wo34zcGMeEJR8mBSvShQLhxH2M/KSilKH3knwn9UToWajpZPUGQI364AGen424Ta6G0aXMBSDqPUenVMe8Q6s3KPmdrkPic9xNohdvNJjKUCEgXLWRFi7nEjRQMnEcYMK7aBDmNiQqHscf5beIrD4qpm/vcIPjMqAI/gRXhJa7a6lD0vGlJhW0WWi4qCXDvjU37/yeha86eaMTtSHhN73fLin9VxgvdmQmo6XiFdDYI8uURtU1N7bSkew29ROT0WY/J8AN7ytecQovRbKXEL/CjqslsNyu+Qw711aoYaolGy/IIhr361h8NeXN9OOvT1Vix CJO67bKB yoSiFfLhNt4CNac0xVnEtmtAVOD5fVEzadBcm9XlYRPcO33tprMZzEjiBsH1URbZI7/bGpvsDDKqE/uG6aBbebv+ouSnIEFSDoZgCU4qHmLhDEoU2RmiwG2eIRp0IDLL3a1JRMudka2mEQhVfwTGVMQl0KsSf0LRtov9PwbBBSx1eEPOvmfX9svupJrmX+BLBsf5sBS8gpis4V1Fp2xTu8id8dlAc0slrT3HfJQ5+brETG7sq8k7045IoaIoHqoUmqw06WfJ1WEmNC8Aq9WVKGeqaL/7bSooG7v7dGsHt9cGUs7Mb8zmdJ6ylzjGcLbBsaN8g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 16, 2024 at 04:45:22PM +0800, Miaohe Lin wrote: > Thanks for your comment. Do you mean something like below? > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 16ada4fb02b7..a9fe9eda593f 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2546,6 +2546,13 @@ int unpoison_memory(unsigned long pfn) > goto unlock_mutex; > } > > + if (is_huge_zero_folio(folio)) { > + unpoison_pr_info("Unpoison: huge zero page is not supported %#lx\n", > + pfn, &unpoison_rs); > + ret = -EOPNOTSUPP; > + goto unlock_mutex; > + } > + > if (!PageHWPoison(p)) { > unpoison_pr_info("Unpoison: Page was already unpoisoned %#lx\n", > pfn, &unpoison_rs); Yes, something like that makes much more sense to me. Thanks -- Oscar Salvador SUSE Labs