From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 737E1C25B74 for ; Thu, 16 May 2024 10:11:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E936B6B014B; Thu, 16 May 2024 06:11:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E41E16B0154; Thu, 16 May 2024 06:11:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE40C6B0160; Thu, 16 May 2024 06:11:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AD8A36B014B for ; Thu, 16 May 2024 06:11:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C449808FA for ; Thu, 16 May 2024 10:11:16 +0000 (UTC) X-FDA: 82123841352.26.BAB484A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id EE162C001B for ; Thu, 16 May 2024 10:11:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zABhOF3G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=grh52sRt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zABhOF3G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=grh52sRt; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715854274; a=rsa-sha256; cv=none; b=ga2G24Rk8VqGo6DMCUcFcN2Zmqc8hyntZANykaSjNjIumuvNCqTZNZI03gD982lVBLaHp7 A+c8E3FEO6iS0l4njlsg77fn99MAmoru76/McJgudAh8BomcXUaR0xnq8+Ug3J6C6ppzIB p34hqcx0BKlPivbtTtzwPkir/t1bTCU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zABhOF3G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=grh52sRt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zABhOF3G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=grh52sRt; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715854274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W4NkbSv/WPWfVquDX8K+L4Ufl8jYQbOt3YU2BEJVMIc=; b=0H2IHx2LPnZZxtUrpR0Lx+dbl44GXSoDR7oqHHqeKH67O6b+oDRrmhx+yA5VfQtjQzPo8t jPx2Ac3LSXVBKHUc3uwYxm6fNdcAXuu6xq04HczjuWsaCwzOtey1WC1zcRLy3/khXMXcUP PF9+CDy9racqRcvEil4I8p0/zglp62k= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1950134790; Thu, 16 May 2024 10:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715854272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4NkbSv/WPWfVquDX8K+L4Ufl8jYQbOt3YU2BEJVMIc=; b=zABhOF3GpZaSm6yvSDAIM6fEip/RWQj89LDo6L4h4e+QzZ32SICr6hahL4vnyEr8qHBbvO iGCZ2nbEMs72XXsCCqunJuW1N8u0WK5qqKn6wocTQl2hYqQtUKoffFbATddslYAqE5lhLT PPi01jrfcUmZgI6L6a4M1gRsDeoaNCU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715854272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4NkbSv/WPWfVquDX8K+L4Ufl8jYQbOt3YU2BEJVMIc=; b=grh52sRt4oi3gZ70C9CYIIOIMq6uwX+EMCg1yZb12xdqfWIrmdSddiVUDvQ9ZNoo/+sFoI SRCuJ9H3XRyuZECQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715854272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4NkbSv/WPWfVquDX8K+L4Ufl8jYQbOt3YU2BEJVMIc=; b=zABhOF3GpZaSm6yvSDAIM6fEip/RWQj89LDo6L4h4e+QzZ32SICr6hahL4vnyEr8qHBbvO iGCZ2nbEMs72XXsCCqunJuW1N8u0WK5qqKn6wocTQl2hYqQtUKoffFbATddslYAqE5lhLT PPi01jrfcUmZgI6L6a4M1gRsDeoaNCU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715854272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4NkbSv/WPWfVquDX8K+L4Ufl8jYQbOt3YU2BEJVMIc=; b=grh52sRt4oi3gZ70C9CYIIOIMq6uwX+EMCg1yZb12xdqfWIrmdSddiVUDvQ9ZNoo/+sFoI SRCuJ9H3XRyuZECQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AF08F13991; Thu, 16 May 2024 10:11:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sDQ6KL/bRWYuSAAAD6G6ig (envelope-from ); Thu, 16 May 2024 10:11:11 +0000 Date: Thu, 16 May 2024 12:11:06 +0200 From: Oscar Salvador To: Jane Chu Cc: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] mm/memory-failure: move hwpoison_filter() higher up Message-ID: References: <20240510062602.901510-1-jane.chu@oracle.com> <20240510062602.901510-5-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510062602.901510-5-jane.chu@oracle.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EE162C001B X-Stat-Signature: wgnofkygghjwp3pycijrqb1jyep3i4mp X-HE-Tag: 1715854273-279981 X-HE-Meta: U2FsdGVkX1/ldjiyaR9QInOkPTE5uyGvAPCldb2q7vsL+Ru0hdCaGLH0ysQFBSLYfF4ne02nKtM5kvBcOD/yOdM2WAJjuW2xhsKXUxiexvC0fO7iw3oQrwsJG8686vKBGA6ZUmEiWZlbYJOmUtyE51JO4/26MzFxI/SAaQl44VP+nekGY4504LUYmokyep+GYvOra7k9IMJkK8DbxFMhc0LZI1EY54omovNGAeAVn7fV+liGA3ftCHF1GBzefc8F1UcKzIrw6k72iIOz8P+Q8WI6NkiSeCFqDWK6Ff1XYQyHNOQgKaHBCVGneM4zUHVDDcevDMnbJ/ocQnP0qeYwHytPgPy1nNycpcw2NB9SA0tGHOPQW1s0GD+x9INQv6KjPl7f+U1UmFmip2nX0hKUC7xeZRmY+3o5atfTQzlO2oN5BoWvShZstngVUe/qnqhcc0qQK0xMgNC9kOTiE3J45xroDRN+FJUy8TCRQT+WrEriJ5VnzDTjdbTnYhls4z56/vomCfgC+1E6bhOlsqJFvjXW8pY+aPTTsNXR7E4FoTA4WsxKmPYhpvWXI499Ojau/Wnc/EQ7zgB8qU5cwL8QBHD5LN0V+GBSf7vQIxV1muZQQyeKS5+JdMfbgGNE5ABWMYXlUpGdW3T5ozSMEQ7tjRdtzOcGwkMexyoDJwicazEEc3cS57OfKjKnCEFlCJlcm94JG0EesqH638LRzbpUIMFZB1bkH52BMiWudPfTXMXSo87EwH5MUpPs0QVZQWJoEvwBn5fnq2J0SEDzrpPSiDU/5l5g2On6/dU5nK2SR7x3PxvOQv1Ys0/zZXVHU5AubISSJEjO9BXHa7CxUo+7vVyC9oyTwXierY/ATR8AA3oAX3Ze2JuZOBfWMwtYXTOs3uS5bjcRv50Jyz/Yq9Yib9JtrlityGfS4bnbp0l0kqTq5JUA9oMrFrIYkhjNzqQUSvWao+P4BH4z1OCU+UR X4vI77KF KuTcXUtnrx0YLve4Gw+qg1gAnAXlFMc7YV1QMLlFqD5+C3Y53O4Yzc0kMtebdHndJRgzBYx8PbvE7XdfvmCBR8SxWm9nnz6m4IEJvnLmIk60g4+ZzWqXmM75DVEXu267yPc8ZuxFLbIqhSTMoywJJm4jVOtAJ1fggKZdnm63QsC8xTCJAbrvHgjWB+l095V6hUqrqLEA7IV1W13rPFdlH2j33PvANR0Nj8GzcSSCeoxU+rWr2onJzr7WRiLsU8KPs+qeo7hwUGriIGqoENOfxezwi5ba8Lod8ydGFerA+dUILqoH/fo5h53uCT+LGDmG32PagD1O8Tn4fzVwsRSrfLyQahA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 10, 2024 at 12:26:01AM -0600, Jane Chu wrote: > Move hwpoison_filter() higher up as there is no need to spend a lot > cycles only to find out later that the page is supposed to be skipped > for hwpoison handling. > > Signed-off-by: Jane Chu > --- > mm/memory-failure.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 62133c10fb51..2fa884d8b5a3 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2236,6 +2236,13 @@ int memory_failure(unsigned long pfn, int flags) > goto unlock_mutex; > } > > + if (hwpoison_filter(p)) { > + if (flags & MF_COUNT_INCREASED) > + put_page(p); > + res = -EOPNOTSUPP; > + goto unlock_mutex; > + } Now, it is true that doing this might not be optimal for the reasons explained by Miaohe, but the whole hwpoison_filter() thing is only used by the hwpoison-inject code AFAICS, which is just for testing purposes, so I do not think there is any harm in lifting the check. But no real strong opinion here. -- Oscar Salvador SUSE Labs