From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2D5C2BBCA for ; Fri, 28 Jun 2024 06:35:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FE2F6B009D; Fri, 28 Jun 2024 02:35:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 585A16B009E; Fri, 28 Jun 2024 02:35:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 426B96B009F; Fri, 28 Jun 2024 02:35:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23B506B009D for ; Fri, 28 Jun 2024 02:35:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BEC97A168D for ; Fri, 28 Jun 2024 06:35:08 +0000 (UTC) X-FDA: 82279335096.30.030F2E9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 3327D140005 for ; Fri, 28 Jun 2024 06:35:06 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RyEUpc8g; spf=none (imf23.hostedemail.com: domain of BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719556488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MwNI65z26hXlFy+OIdCDf7Sa2Aso/XRCklEBUbwFvB4=; b=mkAa+Fx2COA3stSu8qmrziGYukLAWtipPkDJS+rK/HXsHk+CIquzCilKcY8qlN40RDvDIH Ur6VJf4m9yZCLTmrzpq7YnGlPH4Rs/5BCOqJVQyWksORhSocW4/HdZoI4tq7R9llCE/K/Y C+MtKFyxisp0j+yn3r7p14LtWb5Yqj0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719556488; a=rsa-sha256; cv=none; b=mH80Xwe6sOWFjT3yoXO3Mz4IJ80wmTBaYNaT7AdJFktgJ1FNOwK71Lo/fSU4O207CRMrVE RQco+Ju6nKjUgaXfOdUfc9r4u8JAUoSkzCQe+pP76qrorYwI7FSj8yMEig3TwVDrEMUGEu neTSDyFUbteQNJSnUrXnM385JHjZcro= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RyEUpc8g; spf=none (imf23.hostedemail.com: domain of BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2a28956e1c239fda9caa+7614+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MwNI65z26hXlFy+OIdCDf7Sa2Aso/XRCklEBUbwFvB4=; b=RyEUpc8gQpSYQKjpaexcSEGw/v XzLp5Ajau1d9GVG28Z/ICBVyHsKlrNol4Qeqv2D1YprwnCXW4McPb/grZerR4cCNucFa774EJcLXV rhf8t2Ona4bkIOLvlGxezf5SOXtuTMZ9efGtg/k1oJ7+GHaoEuPphNRNqgVJfN5/kfFJDQXnV5ZsK zop4UFnl++iNEewNJUJ6kf+4QZiisImjt1+UcEyqwCIeShPs96L6fcZB8Ofmqxn44kfKh5+LDhjzJ 2REh9vnJuyL0oawT9o+Zna4vXUQIlMX2qUxBMjmSfP3TxQbWqNCK1LKHDxWqFr6uXhmFNGCsDRmBn O9HgFJZw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN5CK-0000000CmIb-1BG1; Fri, 28 Jun 2024 06:35:04 +0000 Date: Thu, 27 Jun 2024 23:35:04 -0700 From: Christoph Hellwig To: Yang Shi Cc: peterx@redhat.com, yangge1116@126.com, david@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [v2 PATCH] mm: gup: do not call try_grab_folio() in slow path Message-ID: References: <20240627221413.671680-1-yang@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627221413.671680-1-yang@os.amperecomputing.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3327D140005 X-Stat-Signature: 91eb4gojqyz9o9cpgtqzbin593nygs63 X-HE-Tag: 1719556506-204085 X-HE-Meta: U2FsdGVkX1/+SAp7OzdveE7jflvyjZJpHlkVqoB3lfIosUS0dtIKSJ0c88WXcTxLv7Xdpz0B3n+Hsapip4yVM32HTirfSCH8I71hV96Htf9QxHXZFfmPE9cmHEsbrp5jr09Cjjofim51ge0Fz8h7HtQNfHL5cVZtzjx7sbt3I+ENXGMvRmWhW+JzcRfGMhbjCqbSaZNdo4WQjzvAE+c3HGW/dO7bT/GPy/yYyBGzEdy0x0LjN3qHPeouHw28YiYqtiD3JzUSqRgq3nyKazjDCPh/i4WllQxf60xxW4ClzRQ9B66qyATnkF3M//oJdsKihRJXXIpLXjs14XNZLLDvdX/uvW2d5ZS9J+ljyOhBu2UYuFdo9KO3oVm3jLrwYcLY2/dmZpQ275x3dqaoRSUevl79A0VHMRjOZ3A3W/n6CkHVU4/7LlcQfV5xceujzf+KfuiXCNfckk3FZj0C7YgBLJkS9d+bdfQs1btdaJJTffuE+6zITbuJFAo7L5+n1+moEus0ZxL6yj3xUTeF1kvm/76KuFgyQAWnEo1z7GK8/vgyTKDflPFaE9hJFh4q4LlU3BcAW1v2zqahRdRkqZbsZFbZeBFYG/HPPTzbaHYKKwQ6gZiLIKbzjOQMXOYHAeYpxNg5fjV0oI6nRJiZUQSf+kRLB+eeDTM2CqeLNmu0xEEaoLnXuWhXxoiHcSwPlDbZvjcvEu1wiC6mASuPN6UyXYKGZI6jmKQ2Uu5jvSEl+IeXAVDdEynKeEyUxGhfaAks+cXMFuGFw6dF0sspWxTFsqBPPpZ+WswSM0nYb5l3mfEw8NU4rAzsoLXkvTMTadbn+dH8b5y0dtsLYGJsdjEDbTdp58lkgU7WGHqhm/YGWHM6oSaTyry0Xh4NRrbG6ywcml6Sy3Pqilc5FjmT3qs2DHNan1KE2BUvU3sTWMEIKiuNvT+BJVesIs8fxwtboSUNrWcItc1pjrYBlaSrTND yjSJQcmy JRum6W/jBWQnrg4ZyC8qsspDreh2s1S4Mi5BbSUbtLL7YB88fA+RFXEe2nXrj8vxC6z1pWQ2qcOfYo7vwc8M9snAQXCzly/gABnnA8oTuFWzFERujqxlAlBFNZzbpGKg0ymo0EcmWEr7hQb61TQcpjwNXV5zjAefszzMnshwqAA+sWecGohEXGLmtIExbfPnyhwaqdj6+bXhLSrqyF8r+2SDlv2RxVFu5hHITCOc2wiieBnDb/q9cJmYAhyuU04bm6ulZbnShA+FcVHYDhVjz/SUOe6QMg2XX5F7YDfdmzULr0IOAc8gW21uFLz7HizEKh0qhmUDb0OSGzkoKrPQ+Je7VQNDiC/n23wlTgPJNZAcGL139Qvda0YZ6HAX+H8ORTvyPNMUZuNDeQWegkv4rOxet/xUAC4yJd8Xow9Grz5LLuwXerm4RCZybR1KBY8CGhnpsxrDa6H/rWNe6VzIR4BvhL/C9v57szOR/FJYeVxfR/pVCzUTGe7/b8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +int __must_check try_grab_folio(struct folio *folio, int refs, unsigned int flags) Overly long line (same for the external declaration) > + struct page *page = &folio->page; Page is only used for is_pci_p2pdma_page and is_zero_page, and for the latter a is_zero_folio already exist. Maybe remove the local variable, use is_zero_folio and just open code the dereference in the is_pci_p2pdma_page call? > + ret = gup_hugepte(vma, ptep, sz, addr, end, flags, pages, nr, fast); Overly lone line. > + folio_ref_add(folio, > + refs * (GUP_PIN_COUNTING_BIAS - 1)); Nit: this easily fits onto a single line. > if (gup_hugepd(NULL, __hugepd(pmd_val(pmd)), addr, > - PMD_SHIFT, next, flags, pages, nr) != 1) > + PMD_SHIFT, next, flags, pages, nr, true) != 1) Overly long lin (same in the similar calls below)