From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93E8C2BBCA for ; Fri, 28 Jun 2024 08:15:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 313786B00A9; Fri, 28 Jun 2024 04:15:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C32F6B00AA; Fri, 28 Jun 2024 04:15:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18AA16B00AB; Fri, 28 Jun 2024 04:15:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EEF416B00A9 for ; Fri, 28 Jun 2024 04:15:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 92E991A0A8B for ; Fri, 28 Jun 2024 08:15:05 +0000 (UTC) X-FDA: 82279586970.07.6479ABC Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf15.hostedemail.com (Postfix) with ESMTP id 9A406A0004 for ; Fri, 28 Jun 2024 08:15:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=M+6fU8G3; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719562494; a=rsa-sha256; cv=none; b=pev4BoQRd64eUPMoD8g2BhE8vI90ZVKzvLHXly3IuHaywQgFsGzhGFdgdj9KDcO5CHcxVn NMK9oV5a/x0CuM2DlNDQOpwpFrbCPSqoPlPjN6Q0qRWGgy4FCH6RJMBF+QLmFxrTrN6ozU FGbNkmiy+KzDZD6IAJN2/0Bf3IX2VjM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=M+6fU8G3; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719562494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nqLlOcQQA1EIzNXkhLBuQWSjSlMYijdUt29humv/fBI=; b=tHsxBR3OiYeiIsFs7eZWCtN7ceFX+eUDkf6hLVj4bdikCl3Ogsu5DxtHIu1JH90LJq2Fe9 bk0zzdQErKoL4vlY7/UzPIcsZaZ0qbAyQI5aA1m425Jm+QDqbx/PbPBWVtiqvO4E3xtoYp 6r9GxlJbyxJ70ZK4gDucwIBZbFIra2g= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a6265d3ba8fso39943466b.0 for ; Fri, 28 Jun 2024 01:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719562502; x=1720167302; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nqLlOcQQA1EIzNXkhLBuQWSjSlMYijdUt29humv/fBI=; b=M+6fU8G3k4yYtpUYz7vQ54X0DetUWT4mtVQTeAK9QkAdw7/0aGhLxxbZBg3oCjTMK8 gbIdsNvCqxTToynvyarwxZpZ9TOh4Gw4WFo7YwLiNVno4MpHQuKrQ4+nRQzjUIHKGkLG GbLf5iHvDcTWcmZ1CTgd0gJHwnOBx9GysAjaGUdnRlyjzqz6dIPod/yeT+qTz/w2fvWl fP+0wS2LuzRbh0u1ywgmL99do4V0B4+LgstisLFsGXZyJXanxmGVsMFB1kgzoCpIAAGp Qs+RjmwflSsHt3PFOE+8PeWJTY2154e8bSos3FqkpWzI+50CkaU0lLUbfKsNq4amwuUF XvSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719562502; x=1720167302; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nqLlOcQQA1EIzNXkhLBuQWSjSlMYijdUt29humv/fBI=; b=MoxeMr/z/Mlvc5LZeMJ8I7V7kKQIOv1GEETqmyTGQeWxfPe8VpfInxQ2DotQsqSd3B HBLgKpude2K5qHh0DGJpOaDey+6yeLfmOAS4nVX3BE0oeb8mUjwYDLLTFEN5tT/ES1yK Q/3QHsVHcKwVy8AaSIgANwfvin163W8ukYtA2fw3qVKMKsDdIOQoOhhuYXlzXGYubRr6 AAxBWaozw3xHmnAahjBcttnthUwI3uIuHCth9gORPqM7KGoq2PPay0lv7E95GQOH6t4o akuumvmyAnJwasB3op8FOqZpgPr5nqwDRbnbfUXrz1eSrh/3iXrHn/DC2b/csf3H3dDP BReA== X-Forwarded-Encrypted: i=1; AJvYcCUb8Ykjdriz7QjAHseywIBiei4HE6R4gg+BH+VKGexBmqK+6I9Qwe+AbWQAakdllfhpkfSzlftHrNvk66qf62tYY78= X-Gm-Message-State: AOJu0Yzl/o0CEd3ZCAexzacf56v8yDREnk8uZu8jkP70y/PuA1mpXjKf ilsuUkgIVYX4dK/SaMxhymUXrpz3Y3YgJxUX+rKuaJchh+xzxSt02BwprsvUkZ0= X-Google-Smtp-Source: AGHT+IFtrZNHvkM+1D5Qqnw97MEaBSYKkXSf4YD5eSBkUIwju0hMYrI/Lg+SsBts/4RTOO7DdYI2Jg== X-Received: by 2002:a17:906:6a85:b0:a6f:9ded:3200 with SMTP id a640c23a62f3a-a7242c4e28cmr878310466b.3.1719562501987; Fri, 28 Jun 2024 01:15:01 -0700 (PDT) Received: from localhost (109-81-86-16.rct.o2.cz. [109.81.86.16]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab065241sm52910366b.108.2024.06.28.01.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 01:15:01 -0700 (PDT) Date: Fri, 28 Jun 2024 10:15:00 +0200 From: Michal Hocko To: xiujianfeng Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: memcg: adjust the warning when seq_buf overflows Message-ID: References: <20240628072333.2496527-1-xiujianfeng@huawei.com> <0e44be2c-7039-710b-202f-c452bfc3f1ad@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e44be2c-7039-710b-202f-c452bfc3f1ad@huawei.com> X-Stat-Signature: fsrcy9iqbnt7dhy9cyp7xx3aezxkehhx X-Rspamd-Queue-Id: 9A406A0004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719562503-643364 X-HE-Meta: U2FsdGVkX1/s0oni15OIAlkIBn997bAwFYXpzosEFND7T9r8CTmedLCwuWuJVT1qetpr7Edd9LmzATP+Uaeuz5rEashq5uCtsQnTE85fVdz1925MSjwpCn6koQrlRlnve3SuzSCeKf3cRSYFPJ8fTbPXE5xs5hacuWDCRODbr0f89PxqUO99FZmZ90vEOo2juRtqAKHm6hJpebYrx0WBQ3KpaBH/aPKyGUrWrc52M1y5VaEAFzKbpu20qSx5Wjwmqd0cyyzhSphVnQhLx1tZB0UbuszoH6zxBjthozu4qrg6BG20m5TDPatFi2b+hifrBHW0jjNuy+PNuSHNy6as/LGmfV6hr2f4DhO1YP8aOXg4aKemyGHmOCk47PgFTfbounwWr1UUeXVOmfhhPgltLZpmwEQXCbxjaVR4EvcLhWGMwbjNZXmm4qgbtORYgmSbRlU+qB9ysusF+3FvaMyPga1NKZHwYERE9zxiG0mq+dFlMLEPerHhiyYnOOKSe06khybwxnZC/vxKLna4smlsYfyJmLFo+oxz61ZMxFjBx90J6LUa7jlV/xJPzNkW6OhdPmS2UiYjoT4bQlpuY5Ln+zHG4z3Ajam4Wsfdu2mfzwsmj+Oam6yic306gyQRz/DOmTiGBY3Tpl//EdfBUAPKgzDnMuBkyzQMiIm2DqlEw2G9RYv049k8D89O9uc8cFuqitTi8tAjaZy2v5ooOUBjheX8SHJufCFwd9EEUQacc2GYTDoFLhs+sQYPWpLcAEy67DJqH7LFpnoVfV7xPGCArO7tPtXdaMQ52ev0QJU1czIpUf3GXEDHVUsxgXdwQRt/wr7mKz/edeOXVB0jcHwkZ3SvIzmgKAx0lo1ppTC1gx1SxLcFzsDddR5kwyS1V1OspmhwsYft3ialO6m3DwpwFkG8yMyeiknU6q6tFFSCgDrJhwcZ/OQiNaYZ5wbEV/fOwMmBHiXMGR7eLX0ptBd fAt9B2Fn 4QmWZQA91ZgDoVK6KWIx3K9SJgI0dB4dHKgPNBUzUDu96hBQSSdHZmm5uo3EHbRzXTcZljyMYdCQiXeyk43F0fsMremG5Q9dG7AQdEHSz4qqlmWdaOaZgLmt/IC6GYKKmhNbWPNscJpJalrZ1ff82rHU/VI/jlHvoi/QHdxpQGzvUO+tGosj5p4mjJV8Wwzu+A0dtXPMFTuIwys4Iz9p0gNPxyPQd39uhlCgBzqTXGE57hhMqCCkiwqR5v4O2KUlg++Rsi34hC59keQiKA4vzww6GY1BF7rsx9LTQ+MvUFD3esO9znnKioWfbN3TPlDjvMWLQ1fzNULCI/G6D+MInUvbju4LdW+WpuEbtm0ZsjY4afKIHSxg4Ey4JYNKQCYMwHZc/ys0BnRExyTpdTMgkfa8VRSL7oLUJ5dPD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 28-06-24 16:09:02, xiujianfeng wrote: > > > On 2024/6/28 15:45, Michal Hocko wrote: > > On Fri 28-06-24 07:23:33, Xiu Jianfeng wrote: > >> Currently it uses WARN_ON_ONCE() if seq_buf overflows when user reads > >> memory.stat, the only advantage of WARN_ON_ONCE is that the splat is > >> so verbose that it gets noticed. And also it panics the system if > >> panic_on_warn is enabled. It seems like the warning is just an over > >> reaction and a simple pr_warn should just achieve the similar effect. > >> > >> Suggested-by: Michal Hocko > >> Signed-off-by: Xiu Jianfeng > > > > Acked-by: Michal Hocko > > > > I would just squash this with other patch removing it from > > memcg_stat_format. But this is up to you. > > Sorry, I might have misunderstood, if you can squash them, it looks good > to me, thanks. Andrew usually can do that even when the patch is in his tree. But as I've said having 2 patches is ok as well. -- Michal Hocko SUSE Labs