From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CEEC27C79 for ; Wed, 19 Jun 2024 16:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BA688D0086; Wed, 19 Jun 2024 12:45:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8427E8D0066; Wed, 19 Jun 2024 12:45:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E3D78D0086; Wed, 19 Jun 2024 12:45:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4EF2D8D0066 for ; Wed, 19 Jun 2024 12:45:41 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1038A1C0911 for ; Wed, 19 Jun 2024 16:45:41 +0000 (UTC) X-FDA: 82248214482.27.710D784 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 6960E100013 for ; Wed, 19 Jun 2024 16:45:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718815535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=io5bXnZ0+4cO+Yj2eKHI97URzu4xpO8672wXKNO54BU=; b=if9xHQGysiZo+tGuGSEHqRQI1j8FHucoGPRJ0FJSUUGmIcd/Mu2AxBEOw0H6WX1od+iGKN RrALdPcvzUIJxOqRpLZzAYPx0ZcX2tDqSVfm6g5l0yAWqvBb8tacNUaH84pja1mQukNM0N hcd3YkAvJT1GPZ/LZSlCYaf7GsuyvGU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718815535; a=rsa-sha256; cv=none; b=YaxkcSMsSbFdpgvpYFtbGaRRkPpMeR5jQolig4wJWmC0/6hRUlwFZInnCofSRzrOq6hKJU 7V/Pm3+mXjSTQQWrie7Y+mIvpAcgo7EjQ6DMqVbAMNH1SH6OD4KzcT2a8sl2RwprLLkYxa AygPOgEPHxgNZv1mRNSeerHD4PEz5mQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4E2BF61EAE; Wed, 19 Jun 2024 16:45:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47094C2BBFC; Wed, 19 Jun 2024 16:45:32 +0000 (UTC) Date: Wed, 19 Jun 2024 17:45:29 +0100 From: Catalin Marinas To: Amit Daniel Kachhap Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 13/29] arm64: convert protection key into vm_flags and pgprot values Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-14-joey.gouly@arm.com> <4f7d8691-fe19-4e8a-95e5-9f7680c82021@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f7d8691-fe19-4e8a-95e5-9f7680c82021@arm.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6960E100013 X-Stat-Signature: ti5h5ubm8camp5acw9sfcnz9zqt6o13t X-HE-Tag: 1718815538-813500 X-HE-Meta: U2FsdGVkX1/oj1BRaRgGpS1a7aoOCbBfU+dThuQqDspLT3Nf1iHvrG5RTSigwZ56mFi29mAv76yf21QZNCLVktRabqt0qBCtocSCMO2XYQ5cBegDL655ZpgfF0QnNbj/uR6DM+ybEA8SCoeoW5+JlRRkfpvmWn/JQ1B1AbfpJovPPWcSrqhMYCCqtjS/Sn48Oo4RccMKb0yobxyGdS70FbwL/ah5NsCjQ8lpACtMPwIDt94qcF+3a+Up26iuyVu+XqEcHFt1hIK98kN8LAniypjsKV7be4mf/n8l9BO8Raj02l2F3f+Fh4m8JutP5cCkRWoLI8n2RIuaKPTuws/BgpokUDb2SxuNnN2DgHaN0f8amrPkPoJ6i79nGGygzgXC37/vGmS8MUvZbdtxatPJn0KorkJnW7u7WnZ+cDE3i+zjrB7+iGrqvPP8ZupqnNdDNLsnzRj4nfferULs+PA6bmhXpA8l0sN4aTKgRw/CRIEtVbpfbpbraSAZVM8jV+aYZR37wNZm8YRDdhdYGEHNDpxGTVhIsisTjmwVIVrcueMAnCB19csgzb7xxaoMi7CHMwgrJRYgDoDMVERypvvYXSf1hk3lfS7GX3250BWYnSxxCbcbB6NnLSXtKWmz4Pe4EbLlC2km1CSlXnmT7mE7FQJpbQs4tVkdZv91skapAruLnpuC2wVkcAe8riSpXgQ9r3rB+E82k/n6SalZY50GByaZJpaEkiBJ/nbxl/1LrrJ/l9gMrWyMOqdUWMdfLRg8K7qB/QbiE/vjvr3NmqDhQILdRuVoFRtGnRx421ohyBKYl+rl4NlhAFs675Q2grkkuF+LJx3EtAYryU6ibbdR1vZsj7pDgdaagRH9QQXrybxtUFrrwvumD9mqmkA99wR1opRnp1L/n4mcFdU5qqnMlsVzhfW66MEcIcJiRemwz0lvI+NkM0P8cFfv6YRJFtnwu7/SUkVVRc+Dq4I5S42 wOAckQCz bE9TuUc6Bym0JRkpGJbB3j/3jxBlWGEoHlsKicu/OhGsdQezqxoehsym2VdpaXeB3uurjkT/7wWgEn5025uEN4k3J6IxnTGRRz1sCuctHQbDALXl1R7nD/jMq2jCrfIMLYwPP2nw6v3MAmYM8h/L8gHrM54I0Mtt8QS1nSBbrPgyslA5MHpuI0CwnvKwP+ZurfKl8XTBrUNF6iAVvzSpgFH/y7qQtFKEu3+DU/selZs4BHreRI9TVpT+NkbIP4AEr+MnSumwSTht70VBhO5fGkJ59ZlKnYGXzX5r8Aeht89mV1hGlaJmCmJfub8ifSjqASZ+vXnhTXEGVIwAsY5ALNyNBfZfxRgvsnuWKLqt9vcHF/cTX9//kyT1Be90wDb82fs+4mzNLIBeJQ34= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 12:24:57PM +0530, Amit Daniel Kachhap wrote: > On 5/3/24 18:31, Joey Gouly wrote: > > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > > index 5966ee4a6154..ecb2d18dc4d7 100644 > > --- a/arch/arm64/include/asm/mman.h > > +++ b/arch/arm64/include/asm/mman.h > > @@ -7,7 +7,7 @@ > > #include > > static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > > - unsigned long pkey __always_unused) > > + unsigned long pkey) > > { > > unsigned long ret = 0; > > @@ -17,6 +17,12 @@ static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > > if (system_supports_mte() && (prot & PROT_MTE)) > > ret |= VM_MTE; > > +#if defined(CONFIG_ARCH_HAS_PKEYS) > > Should there be system_supports_poe() check like above? I think it should, otherwise we end up with these bits in the pte even when POE is not supported. > > + ret |= pkey & 0x1 ? VM_PKEY_BIT0 : 0; > > + ret |= pkey & 0x2 ? VM_PKEY_BIT1 : 0; > > + ret |= pkey & 0x4 ? VM_PKEY_BIT2 : 0; > > +#endif > > + > > return ret; > > } > > #define arch_calc_vm_prot_bits(prot, pkey) arch_calc_vm_prot_bits(prot, pkey) -- Catalin