From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5655CC27C4F for ; Sun, 23 Jun 2024 07:51:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56C646B0504; Sun, 23 Jun 2024 03:51:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51C456B0505; Sun, 23 Jun 2024 03:51:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E4136B0506; Sun, 23 Jun 2024 03:51:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D9586B0504 for ; Sun, 23 Jun 2024 03:51:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B85F12047E for ; Sun, 23 Jun 2024 07:51:21 +0000 (UTC) X-FDA: 82261383162.15.6824B78 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id A15C21C0004 for ; Sun, 23 Jun 2024 07:51:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HsWi4Zgy; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719129066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oFyAU6B03Nv++6Tl+VLKiRnArTMdISRhP4SgJ5dWMtY=; b=aiDKy+SsmcT4DwV/Iy+LeKflPcwJYky+ZNbEjkdAkv2vnzlA0abXxjYaPPPeSNVi7Yb7wo 0JPmc5M7SHMXastaZBBnEE0MBt7/IeBKCVjAfKoJ5XBOFOaHOXs7oJZhGi4LmkOHBuavhf beFwy1ndFcWvgpxOi3QjscN7KKiRnMI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719129066; a=rsa-sha256; cv=none; b=BFqvyZnGFKb75xJU1xaWZA2Ae5SwJJ80uBe7jDR9I+2+fHPHZ22G9ALtVfGI5c14IR0gKH /0rFMO5YF+W9he27b4sZ7f5VW8Gmg9a8oIOxgN6tyaQxylb2h8nReMMiyGmsJY4ZlOjng+ 2ZBpwNguNWym8BJH1EWvahO36KiEf0c= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HsWi4Zgy; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3A36DCE0976; Sun, 23 Jun 2024 07:51:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F61FC2BD10; Sun, 23 Jun 2024 07:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719129073; bh=fDdtqEilnFeBJrpYZIhdwx05cPXxID9k4tOjpaJfO+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HsWi4ZgyDmEcGrzW8V6UJycZx3aBDPdqrWH3NqciA9nTMlYTX3zUFavi91zHRKWka z+Gbn4bedZsoNSfLfUdsc9M8uXBu1eV3vUPc112d8REciNkS96mkL1bdfiuI+AvEY+ tr+JzTH5qcp7ozSLjp3lIt/tOBUirHS64IWQxUxp9BFZHMP+9xJF0Y4zD8tOJdPB+c maZh0LqbKjCamu927ScB6NWm5R0Ewo5tizPPmyXQ13TGhB/NM9NcbKM/7a7HdNL3Dk A3ZwmrzYGNp/ZX0jImc5iyveprC2Wpk+z2B5P92WN1BaF2B0cmU3yAxNM2UvFuU47q XkwpRXqyaottg== Date: Sun, 23 Jun 2024 10:48:52 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH 2/4] mm/mm_init.c: move build check on MAX_ZONELISTS out of ifdef Message-ID: References: <20240619010612.20740-1-richard.weiyang@gmail.com> <20240619010612.20740-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240619010612.20740-2-richard.weiyang@gmail.com> X-Stat-Signature: 3cspoicywen8jjir1zx3e58mt74cncdw X-Rspamd-Queue-Id: A15C21C0004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719129078-220129 X-HE-Meta: U2FsdGVkX18UctymZ/6C07+KW4NZUTZ+W4znNJv0lI3/OHGsF0Qd/CJzjxStUKxNBJf6p1eZW/3Zc856uzQ5MbEwxp15zghefxk19AFW292r/UX/VTAUp+7nh9OcjhPmdGNL/EakRkRQNaUSe+j+UE2zFbuaVKS/v4UIUoNYrS4kg5t055+MVo5rlAThZLkkjR9dp48cWInzV4Z9egvSlLiRAJjY2XYp/7WWdNwzAnHVxqLBYbNbHP55rdd6O8/0ytQMjnr5Zj1Th7WmYjOzyVtjHd524Ph5U/9YmC/2cBm2V2FjeB+q13dTGbFpv1z3LVV8mQ2mKPPKxMIv6AZZDSyYSGDOcPg4uT3xg+SKJeaJygbFNEJk1Tr6rqu6nZpTSS7xqyxpamdinocfA7+e5BOSaUKoXWkRBMVvLWECQXeBfMFtV5JMOGMIG3kPOhN8TmRmi2Iss/nFBN2W4g0DoQu9BqzexvKwQiRdKDke7pU58gKWPl9RfGsORhMd9hjDJVsB+t/C8lhR5Owgcd6x+hrzrzFjCsjtEZm4KniqABFkiMFpN+rVzl/wvfGUw+Sl0z4+ypV0N+cG3gQAvgwGjhVK4CRdDDGn7S0fkartqcTW+MzYd5/x5Bys/83QyaX7J4KOSXF1Px4HFE4BjG3QbUZ5ZND/IijfZNmmf4AWLQsJ8CL7Z7DmhuyT9DYn5tzDrDQpwELhj9it14X6I9oEorTfLOquGRTCS/JcEEyCKJpQN0IfIU3afS2gFSBZsUPRfi4+BRv6YtaKhiAybqFeGZpHZhes8dBTiN/xRtBlbap+lmuEGSFrU1n9fRQwMNGF7qG0acPkGOXYsAOogOiB+uvMMahJDD8bd2laggme3Vey5+Ddceb3+X+II8iLDeohxzfUUs0gQG0IVctfvR6Ch2UMC8vQuwyPh0elQBPlBCMEEH+j1eiVbV6GwV9Li3TRTmm7klW0i5E8A2AeU2h CfXTdkpB R+w/7lzSuvf2DSdiwruYEIPAQVglJMTA18oCpQ/Ua70IuNh63mTJstvbyNbFKDnzlnCgWUk91pXMJlw80bNFL1X2ZCoWIpVLNUsJTydjgtlpYy5w8E+PcSA8yWUDX5QmnhMGNBzSnfqSQZkfCcyvua/a5Nazd2V7Bjr0SnylkmQ0H8S1cTOKDwc2MDsI4XPLMFF6SfIjY/oYyUOkT3oH76dMzYXSoyA9COq5J8dLqhKLadMIYR8SeAHMddrqCa5IG3nFmf+vQJWolaoq2n6pznDx2yYyBOigZzmLaGOlmMVUcnsNFue3dr+1rv/l8YiIMVNaoeJj4HGwylf8qlE7wGMSqeaPNaUi47inIrAFETkvCGne09l2+vdWY7H1rTL7fCwTj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 01:06:10AM +0000, Wei Yang wrote: > Current check on MAX_ZONELISTS is wrapped in CONFIG_DEBUG_MEMORY_INIT, > which may not be triggered all the time. > > Let's move it out to a more general place. > > Signed-off-by: Wei Yang > CC: Mike Rapoport (IBM) Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 31ebb3cd53ac..4991cb5c5436 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -53,7 +53,6 @@ void __init mminit_verify_zonelist(void) > struct zonelist *zonelist; > int i, listid, zoneid; > > - BUILD_BUG_ON(MAX_ZONELISTS > 2); > for (i = 0; i < MAX_ZONELISTS * MAX_NR_ZONES; i++) { > > /* Identify the zone and nodelist */ > @@ -2668,6 +2667,7 @@ static void __init mem_init_print_info(void) > void __init mm_core_init(void) > { > /* Initializations relying on SMP setup */ > + BUILD_BUG_ON(MAX_ZONELISTS > 2); > build_all_zonelists(NULL); > page_alloc_init_cpuhp(); > > -- > 2.34.1 > -- Sincerely yours, Mike.