From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E66C2BBCA for ; Tue, 25 Jun 2024 15:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 386BB8D0006; Tue, 25 Jun 2024 11:52:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3360C8D0002; Tue, 25 Jun 2024 11:52:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE5F8D0006; Tue, 25 Jun 2024 11:52:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F2C618D0002 for ; Tue, 25 Jun 2024 11:52:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8274D12028F for ; Tue, 25 Jun 2024 15:52:15 +0000 (UTC) X-FDA: 82269852630.03.EBB5789 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 20892180015 for ; Tue, 25 Jun 2024 15:52:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="dsY/v5Sq"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719330718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YLsgCo5mZCWyV+0LgwK8z9FDMC5L3Jf20O6mHZiQ8gQ=; b=AcUvhAmGnokfPrDL7g8Ny99tJM+xzmmj5rfzoXOMPSsBgZY5hJHG/la9AhGDITwrhJeAgp fPRwmB8hFIq2Wozy9vwNL2vR8z0BeTyu+U0t+A27t7PvkFlOEu7/dC0sKWGtLkbZPjg8B9 prYGOG1iojbK4weVswt1rur7/4nX7hc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719330718; a=rsa-sha256; cv=none; b=AHIScejzcCqOPo7ZsfpKT4jzz3ncXQaYr8ZlDQKr1Rxwxrf6QSOmgLlbM4gLVMBkr+weFR o1imqfhMi8/JRN6yi2MFklJNQdTFzVRWoM8onDKr0BNdUZgjGQiIeUbpGrhlUFWEISmyGD HgJG5V2ln1SGfwncGnBOUGD+/65Mnbc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="dsY/v5Sq"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YLsgCo5mZCWyV+0LgwK8z9FDMC5L3Jf20O6mHZiQ8gQ=; b=dsY/v5Sq61qwbM7R6F+sukc/5F s4pfkym86Ioii1ii/qPd5ZqDZkuY9WsN7UoMvQY4lfJ1lcZzBtW6itoMxdSn5Ub+HH/tx4xHNov6m QGudwmzCdubFhgmb0f+BNB+nLfijhUGE5CX9l0G0wAK70y7f8/1WWveqep28w5Zu3ew/qt4OkvZC/ 4T56yO2ivoaK2M419qqC/0vYp92diIr1H9nkDDhhBPQo0X9k2rwoFy02miSlQOzFYWPPtE+rgfVnm 0kIQUAZN8kOkQq6vmukUW0D/p13DhJ/Bzgwe3O0+9o65RwpCOeNUI6CI/y0C25q4GL0h9fJPjXjbO OVf9HL6Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM8Si-0000000BHaO-06Hw; Tue, 25 Jun 2024 15:52:04 +0000 Date: Tue, 25 Jun 2024 16:52:03 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 02/10] filemap: allocate mapping_min_order folios in the page cache Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-3-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625114420.719014-3-kernel@pankajraghav.com> X-Stat-Signature: bbnppdqbum9ngeo3m4qkr9tzokfmi5ks X-Rspamd-Queue-Id: 20892180015 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719330732-28973 X-HE-Meta: U2FsdGVkX1+VXF2OYKHo3iCZoDGhOU4qV3UfsfS4SpZUrzVLqKk2EYPCFNt/AOuszSSTlzysyUTXF/Uszhh2Ix5aDcFe3pchNYzJdnkpyefzsoTVIy8rn+t3+ZzCuCczs0Ca9gPcYR2np8FookfFct+vhD0IoethP4eMrx7946o9czJELuIQumd3U8/jAipTfahv86LTKEF4NEYNZlwIz76K9juBAnL0PYbXvUvoylyBNeD8qrHIlGFvzrJKeUNlGtqy1vOrIIj/n7SiLCVCcmJFm7mpE4Wkssckh1qjvl1bDOi5O0EJcGCkKypy/bliGwckrgkROpKj4MpNd6AJqPC32yyFVg8QW1eEoUzhH1liWZ2pTJUO7Nsn0hCe/43DJ+6d4vEdsRmv0qreOdNxlmLCPOs1yV1sHr8wNYSK6Pe7tXcn1KLwdu2B2HwP06o0gKmNOyPjL4iI+na+a691F3l95BAqlDFsgGdsgNarKHrQzjGosS8NK3aNKsQdtJ/3waf0xkh7Xe1z5VlQDB3O4nHX2IyQtCd7GGaCgjZ2dsdnZUujFYi4cMASlK2oLfHS+WhncfnBaTKOEvDFf0mlPxRJNdzLsC1Oz+sVSc0a0qrUd7ZRbUda3XQhQVTjibHGbXnQ3lzzLqbD4OP/wD++u77qAwEQqt49o5DRa+dM4vAxPBew7HPAlo/H1mdxfgD/uDQpxYZRTcC5OixOTufGIvnbNEM6NjeHJxhOWU/CEaGcU7BkGmRyg+/ec2wTNtvt9MW2t380fsXFwKbp+ujOzd43xX5lYQ/syAnSOVi0Y28rWGWftaSFRciDFpVkw41Tr/g1nQ49Urq6MpVCb0eOTg2ULSwBIZaCZJVoXIwWR1ENpoHgafgGsuI2KgzMCEL6JH740wMQj/TpUf+AEiAvtMJ1BnIGgdGTgQuQb/aZioQ9HTGfvY2JkcSfIvXin2WH1ygKsnO7wKk2oyDo54C z3v8r5RX KkAH0m5oPYcrRbRZqJhbVF21TjEWB4Q8vaSrA5p8W4bS0eNquE180seTvnwNRLO29MDYfnVBTbMxH5QZep8e46vpYIcvo/7jjcpwzF3AfkQwN/5FMJMA3CTOwJT95EFE92QtWA83d+yfRFgH1UphkfioIekVhsCJTgGyM84867r/NR9s8pzg+AvngPojkTBrMN2TwLa9jDFtjmz1JqSzXwqS8ADYCkLtUtVHypuAwa8FwZvGpa5x2CLsp+ZszVJ+YAJ4FLcM+Ea1aXgZGZhcpCMalx2GX/jbs4H5bAnBHY5de/RD88HKpmkss5kZCWw9wRRQOFMa2Mfdz+7ewCx11IwUjMuf3isBGHkKPBo5LJakse/muqVO6ZZxLqqiC3zbeyi8WC2llQWZsjWk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 11:44:12AM +0000, Pankaj Raghav (Samsung) wrote: > Co-developed-by: Luis Chamberlain > Signed-off-by: Luis Chamberlain > Signed-off-by: Pankaj Raghav > Reviewed-by: Hannes Reinecke > Reviewed-by: Darrick J. Wong Reviewed-by: Matthew Wilcox (Oracle) after fixing the nits below > +/** > + * mapping_align_index() - Align index based on the min > + * folio order of the page cache. + * mapping_align_index - Align index for this mapping. > @@ -1165,7 +1186,7 @@ static inline vm_fault_t folio_lock_or_retry(struct folio *folio, > void folio_wait_bit(struct folio *folio, int bit_nr); > int folio_wait_bit_killable(struct folio *folio, int bit_nr); > > -/* > +/* > * Wait for a folio to be unlocked. > * > * This must be called with the caller "holding" the folio, Unnecessary whitespace change