From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535DFC27C4F for ; Wed, 26 Jun 2024 05:05:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D5756B0095; Wed, 26 Jun 2024 01:05:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5853A6B0096; Wed, 26 Jun 2024 01:05:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 473E66B0098; Wed, 26 Jun 2024 01:05:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 294196B0095 for ; Wed, 26 Jun 2024 01:05:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D998F1A09CF for ; Wed, 26 Jun 2024 05:05:14 +0000 (UTC) X-FDA: 82271850948.18.91F22F2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id CEAB11C0012 for ; Wed, 26 Jun 2024 05:05:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="t9QIlV0/"; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719378305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=19jYqQqOCPHnitc5C2BgzekXEnfYkgClaBX2VbO29fE=; b=7SQdKqhaZeffXx1S1sIJXEv/7/zpUDyzqQOBbKwSq6qMW+tVOJaeMG01t1nQQNLWQAgCdd SXZTneq8RiyqQ5Pd/+d8kKUX8JNmnjphWCZmUj/C2tibxOZiJAPLz4WILPQNIYTrD5lIRE XcJ3aRunckvgF2kJ/IlcnC7BxCgBAh0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="t9QIlV0/"; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719378305; a=rsa-sha256; cv=none; b=Eec7Qy5LGtoyG9jhC4Br9/czGju3DQwhTbtr5USQwM2qP7BIdZJsev4An+n8eYjt0gGyyR XQm3i3JCtpIxDYPxCk4KY2GZuJ0/+qNSGUJhDHR3KxrTjs7e0G3OcTe94HWF1TkAyx9GI3 wgmJlPNcSw73le4HZ6A40WMDj0glVrk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 653E0CE1F77; Wed, 26 Jun 2024 05:05:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26E53C2BD10; Wed, 26 Jun 2024 05:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719378308; bh=ZgawbklMa0mTB5ICZcmT/KCFPnybBd1Xaek6KxkvUbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t9QIlV0/SC7HxMudJw6Ky0kIVQSVXvyKMQjeg2ZwMYeym6As/VTEnofLKm/Q+gGWv Mqa9qwGs5iBk/RLOIclzSkeLL4j4U4OcOQcPutH1hKjMcKeFd3bXeUNTckccLTeFfH h81j0xm2ONnSt9F4d8HvoajM66BIharie8NS8Sj3FNyHhTLeVCoIdeX2KUIS0EwPxO a5dKCk87HBXQ/Q+gESk6dyiBTDsCbKxOTPDqABWREcihu331rYNRmgR/uF3CZ5y8NJ 2nk2d5fjxqLM/Dros0WrDYEhqKILl9J4PRni5Na3Lod5pk05XPwqdsTFH6mqhd4eM5 z+I6V9OJVmULQ== Date: Wed, 26 Jun 2024 08:02:41 +0300 From: Mike Rapoport To: Guanshun Liu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memblock: export memblock_free() to free reserved memory. Message-ID: References: <20240625121652.1189095-1-lgs156412@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625121652.1189095-1-lgs156412@gmail.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CEAB11C0012 X-Stat-Signature: wpbnfpuj4nm6ccwc6nzgk5ejtbyuaa1k X-HE-Tag: 1719378312-828574 X-HE-Meta: U2FsdGVkX1/qE9UUF8Mgts0jWVQtmZIGjYLlfu35wnoIdSTvcaNKsx9IDb913jQ93KJIMS0lHcsoOF6q9goD1NrvTRUq/nzeQYg4tqAVFSPTXxUXlk4qsuynqZFmtNZCmEhngixWLC4jixTykpWiGFquL0sQcimFf90z9+T3K6p+S7aA7N+T4pk/L+DVzs/ZAFeFK4Neac4Fuu8M2XEUhaXH6koZRqKp7jLD3D2GKpnYzehXU+fHS1IvdmwPKZUskKlXnTJtYeHGySgkZ1cW97iGySDc3p/T4Pw14U/t0jVlItIuQW1LpU0BqjI1VvHcwzP1Fx6hD6NtZehvthoTHa5vgILWo2qmAi3EBR41lkRGwbFnQQDF65Nu8TiIJluH4eCIkmTg08CX9hIsX5v74jYZF5kS92yqswUogr79ZwIoz5XBEnQOGlrRwUrH5pkJndFGooLaaiSpiKZHiIR3mYnmwQEC/kF9r+GMqn7gHK+R52s1IwL7d9mLRy51PhxBEW/VciT/xBfb3n4W6PVSo66215QmIAgbpZLB2LEPJNm4pSm9e72lMLC+b+jWWs9BzIkvXtcrbXuGskJpNjVoEBuJLXdp1MpMH6eutfKe0JyBKu/He+oVQuK13SZQS9nBJb5kUnYQ2Kjkqx38LMBq9fCimuwRY47nhPci0zKSuf1DBjSP8zC3D/WfcIavIjl5CkV7P2a+A3YEfbRh6kTY7pEPv2+D56BmL74nA0wModc3NAEC1U5RgDBAJtSlOL9qF9/293c4tcetVC9W1AVRXnCmRInjD0ZT5rg2qLmrbB4y0l2oXGDolh0qNb3RkjuQpUwD3ZT/GmuNzBHqOGRafoLQyhHJ09dgYNPtadO3BE5QWjDALToYtf9yp7Mr+AwloDyH7hTdm9v4z02bEVuh5AJ5b38/ZHbBu+8ud20+1TXAKwIoespeDdpDLDoAPdLZOBuSi/VS1rLkOeH23Cy IKcTgsdZ UkCdN/7FOeWR0x2ihcRSZVamIIG6Nl1gCA40XK8S3PUrHl0Ry8NZ63ElaLScdQMhU58l9uT4jUGcSIa6V+Zyrm5EhlwXP9Mr/P5EvuG+AdnERjXGlpD1KnoaVACDckIgQu23WIu3QG4FvEG+JnU46ZiNTLLZVQrQCbUjp1Bd1ueDjDpoBrYNg6Nqci1Nv87OBck/5ClTQGWziimUeWRCSo1IhFXTm7IuCqq14b8/92Yd/hRkTeHEsBes3MPCEVurp6XSCqcj743cOvC7/1RnlTlIRBu7N8uJZS/Kc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 08:16:52PM +0800, Guanshun Liu wrote: > On architectures that support the preservation of memblock metadata > after __init, allow drivers to call memblock_free() to free a > reservation configured in dts. This is a hack to support the "This is a hack" implies that it's not a proper solution, right? And anyway, memblock_free() will not actually free the memory after __init. > freeing of bootsplash reservations passed to Linux by the bootloader. > > Signed-off-by: Guanshun Liu > --- > mm/memblock.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 6d18485571b4..20e7f81fc076 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -848,6 +848,9 @@ void __init_memblock memblock_free(void *ptr, size_t size) > if (ptr) > memblock_phys_free(__pa(ptr), size); > } > +#ifdef CONFIG_ARCH_KEEP_MEMBLOCK > +EXPORT_SYMBOL_GPL(memblock_free); > +#endif > > /** > * memblock_phys_free - free boot memory block > -- > 2.25.1 > -- Sincerely yours, Mike.