From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79AFFC3DA41 for ; Tue, 9 Jul 2024 15:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B25786B0083; Tue, 9 Jul 2024 11:56:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD5BE6B0092; Tue, 9 Jul 2024 11:56:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99D456B0095; Tue, 9 Jul 2024 11:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7BEBA6B0083 for ; Tue, 9 Jul 2024 11:56:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F3C43A5001 for ; Tue, 9 Jul 2024 15:56:36 +0000 (UTC) X-FDA: 82320666792.06.5395510 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id CF886180035 for ; Tue, 9 Jul 2024 15:56:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vc9rNAUg; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720540554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xk2zHQ/YE20jgxtFEdO755E5YwPG0ZQdb2j69TcOV+0=; b=jPodnQHhb4lvpbWmR3f77YxPazEaWBg9OUsx8+gTuxGe8Qm3iy+z9NqRjRHavxy2R9qN0s nCXUFS6FT/AV2cCKzQU16b2oFIc4HFCVYW5k3oEUZCsQzxPhbn3i231ISwk2scPO7kfKXD 4jV1jJ/rZi3zSfst7sRu2a9MHeYDzSU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vc9rNAUg; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720540554; a=rsa-sha256; cv=none; b=ZaUMkfQrU4lqgeRlzLJLzsGy5xFazHbAPDKxDsl6ji7FoJlQIqnGgeMigtSWyDK6zkBezf c2dbmXaTTTOvt+2eHQTyPi5kaNaFzXWPsE1E7R1DxngnwVYu+2gLYc/ad8bOrCGyL2IGP5 VnA/yDBKnY6friHjIURWePP/0IGtxns= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720540594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xk2zHQ/YE20jgxtFEdO755E5YwPG0ZQdb2j69TcOV+0=; b=Vc9rNAUglBxuSTPB8otLc6juo9tXhfZRN2sLH1XM1cBgJ//37SBNUM/sghllp66ks4eeHm WlqdEHnmdaTZwh+Vns6HRdsLXjtSV6p8l7uZ//xTjNYZmydzkDyC7gfqsayVolkz2yiirA IveGW0fzMqtX8kPsEFTgumYMy9sZJaU= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-CLgPXVDoOUCpoKyuXog1pw-1; Tue, 09 Jul 2024 11:56:33 -0400 X-MC-Unique: CLgPXVDoOUCpoKyuXog1pw-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3d92574d224so51381b6e.3 for ; Tue, 09 Jul 2024 08:56:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720540592; x=1721145392; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xk2zHQ/YE20jgxtFEdO755E5YwPG0ZQdb2j69TcOV+0=; b=s7mqmresmJcDYJ7P86PRbhQUPImno680AN3ajwSsYVKwQUBMLDp5NizkxE1056lc9v SO412vwuxu4tCq/OyoFUdudN7NKiSQx2w9oaaVWf1P+NdO9z63gccTk1abNRzx3/8YBo kQXPqPdlkcmM65tX6NiYoA0VOvv3ouSG+tr4kVNVu386uOu8wbrdDadv2h53Jcku49Y+ KHuIbyQPsRjgNkdqPKXfJrYj97kSqP9XpeuuRecAZIVAGkP++NAVkDk40OGpFWCMg8FO Uqi+USZrO3Pk3rJzk5J3X3oOVXO8vwijm6It1LK1C7FEEJFnNqpzVLACFe9Ir10iDbtH XYSA== X-Forwarded-Encrypted: i=1; AJvYcCWdEuKNmhGFTfPlcuenBJPO6S2dUc0+AsYpKuVixBwLKLaV9fLaTZr0qQzsCabsztL1pYvgtXWpl6EhUZajYvu31E0= X-Gm-Message-State: AOJu0YxxQAR7TQSQn8OljaV3hesXuxQcgYKWtmceu+Rcb/2C4wi0v+G5 Tm385GvBgCYj2jMDGtBiLxuQ8QYCWQsXDUnR96zoqUFEX5UKG97pbDGL1KeY0pM0xR1baZLHGTD 9us2kd66qhCUR2d6x2Qw7gVE6vLUzkWZLyKtaRSrTos5kHW9d X-Received: by 2002:a05:6808:148b:b0:3d9:2e1d:2543 with SMTP id 5614622812f47-3d93c0fe45amr2848539b6e.5.1720540590684; Tue, 09 Jul 2024 08:56:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1Ma1rQrmj4Xg5pyldsO8p97ImEEKrUWOUqeogODHc73Oz0DxK2TC+nXJTsvBMv1FTSng1jg== X-Received: by 2002:a05:6808:148b:b0:3d9:2e1d:2543 with SMTP id 5614622812f47-3d93c0fe45amr2848435b6e.5.1720540589482; Tue, 09 Jul 2024 08:56:29 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9b26f7bsm11708091cf.6.2024.07.09.08.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 08:56:29 -0700 (PDT) Date: Tue, 9 Jul 2024 11:56:25 -0400 From: Peter Xu To: Alistair Popple Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, Alex Williamson Subject: Re: [PATCH 11/13] huge_memory: Remove dead vmf_insert_pXd code Message-ID: References: <400a4584f6f628998a7093aee49d9f86c592754b.1719386613.git-series.apopple@nvidia.com> <87zfqrw69i.fsf@nvdebian.thelocal> MIME-Version: 1.0 In-Reply-To: <87zfqrw69i.fsf@nvdebian.thelocal> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CF886180035 X-Stat-Signature: 9dtdeg9j8eai51jithr63j3m9t7o7hhq X-Rspam-User: X-HE-Tag: 1720540594-981851 X-HE-Meta: U2FsdGVkX18HJcZwzmJDhfolnD5uxByyX21WpClBnn4WFdMIxBONDdI/TNwmKIlhVDOAc25GwfmHxds7mGtY+V8knZ1sZyjKU7XQvwPbNzTcMTzgyes9kSjqYE/sg3rlccKtTJbv+We/3e7q1gux79xIo9oRGfOA9acCs5M9sxc2ie+D8EbbybVGbfcJSQ+YojtQRWeo+GUhrnyaVToIFi5xvgYglguM+ETQnk6Mlj6U5W9MLuQrdb0p84K2XatpiwNJP8KhtRKyHExmNSMIr/ytBhxtQ8sZgi/b6xOUzvgxNjo4TyUrFFbJJuxJH64rXZE5Y15aj5/oistvG61+aojFfwh0jTKHQN7qWk1w04ux9abk8oVmrGhIxWloLKQnNEH3qAqpPhsIGrjB2n+l1weYRLa2L7ZP7JemvP3bk9WetE31m84335gfvJnZMG/ZNvA5bon6KiS46uOLit6jT67wUQoyMr0lNX1VUgWYONqmddFkvmKVfU7beL1iL4IkMSuigO1IOBxEeBdP59KBV9BVVLetLVQq5osBNAvY9tgLfQLSd/3eBtw6NYvOuibTSuOn+cRwuFiqQ15N2RtDFq1yy0SVWZdT4JihZLDzj2NEOIKZQPY/3OtONAWJI/K9loory0FvldqTwEkYWjTT6+/FoxhxTZHHELBwoSsJ1mWR0cyJiQxIY/fiKa4VEChRoyfSG+MhT40tMH9LkOxW1vn83SfAgnzg/WxLzYFB39T/0+/GRqMjEV+OsNVTs7FOY21+ZVraBM82ji/BIfCzuzfn5YfQBoK+WY+mjMWSCz5sekNPF8Gy9rv0pcs5M6ksId9EOxY2KIaLt0yajrrOFdOjmWCzSFg9EYzACVcpAvuUHDMkE+3A3S2sJnMvYEKmpjmRMZyHxLXH+pSlhp0KG8s3/BqPhaOK/pTchv1hL079WApwEqxa9ESKlB+DOnqNOPjURfZi4CJkFS2cYhk atpT1mTN Fy7N+pYHo6aJQIVGRqH1l7St+3iGeBmd9BPDbWhyQfBj/LQalfzyH4+CMO4xOaAgaJgz35IkeFI8ZOlUqNiSiywxYxC8VRm2MhZ+UU4z9AKUls+7foXeVRHGSNp4F4O+hj/NkOZE0up6O7OkLr9lRDDY9eGKTQM+xqUb0Qb/hgg3PgaofzFKmFqUGFsC7wXM8ibfK6MYW4ZxZ3n4zDAwnrAj8Lvs7XCelkYGntX9vlrM7OENhmO2wfp4cJhthM7Oq6Wkxu4prcTAtZ1UAXPckLj87z8/LJa+ZT8qWNsyLcV8Wy3NkjMYSi+1zd1ryVZsCfpqzJwaZJeePFD+yqblMxfKKOdva9F907kUgiFWBVncdDo7XxhmoVOdu3vYjE2KxNFU/t9c5dTXXL1PFa1J0l+LAuSTDHojA0IJ4nblMEqUAkFJzaAy8fyZIc5MJ96NV1vCP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 02:07:31PM +1000, Alistair Popple wrote: > > Peter Xu writes: > > > Hi, Alistair, > > > > On Thu, Jun 27, 2024 at 10:54:26AM +1000, Alistair Popple wrote: > >> Now that DAX is managing page reference counts the same as normal > >> pages there are no callers for vmf_insert_pXd functions so remove > >> them. > >> > >> Signed-off-by: Alistair Popple > >> --- > >> include/linux/huge_mm.h | 2 +- > >> mm/huge_memory.c | 165 +----------------------------------------- > >> 2 files changed, 167 deletions(-) > >> > >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > >> index 9207d8e..0fb6bff 100644 > >> --- a/include/linux/huge_mm.h > >> +++ b/include/linux/huge_mm.h > >> @@ -37,8 +37,6 @@ int change_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > >> pmd_t *pmd, unsigned long addr, pgprot_t newprot, > >> unsigned long cp_flags); > >> > >> -vm_fault_t vmf_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write); > >> -vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, bool write); > >> vm_fault_t dax_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write); > >> vm_fault_t dax_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, bool write); > > > > There's a plan to support huge pfnmaps in VFIO, which may still make good > > use of these functions. I think it's fine to remove them but it may mean > > we'll need to add them back when supporting pfnmaps with no memmap. > > I'm ok with that. If we need them back in future it shouldn't be too > hard to add them back again. I just couldn't find any callers of them > once DAX stopped using them and the usual policy is to remove unused > functions. True. Currently the pmd/pud helpers are only used in dax. > > > Is it still possible to make the old API generic to both service the new > > dax refcount plan, but at the meantime working for pfn injections when > > there's no page struct? > > I don't think so - this new dax refcount plan relies on having a struct > page to take references on so I don't think it makes much sense to > combine it with something that doesn't have a struct page. It sounds > like the situation is the analogue of vm_insert_page() > vs. vmf_insert_pfn() - it's possible for both to exist but there's not > really anything that can be shared between the two APIs as one has a > page and the other is just a raw PFN. I still think most of the codes should be shared on e.g. most of sanity checks, pgtable injections, pgtable deposits (for pmd) and so on. To be explicit, I wonder whether something like below diff would be applicable on top of the patch "huge_memory: Allow mappings of PMD sized pages" in this series, which introduced dax_insert_pfn_pmd() for dax: $ diff origin new 1c1 < vm_fault_t dax_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write) --- > vm_fault_t vmf_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write) 55,58c55,60 < folio = page_folio(page); < folio_get(folio); < folio_add_file_rmap_pmd(folio, page, vma); < add_mm_counter(mm, mm_counter_file(folio), HPAGE_PMD_NR); --- > if (page) { > folio = page_folio(page); > folio_get(folio); > folio_add_file_rmap_pmd(folio, page, vma); > add_mm_counter(mm, mm_counter_file(folio), HPAGE_PMD_NR); > } As most of the rest look very similar to what pfn injections would need.. and in the PoC of ours we're using vmf_insert_pfn_pmd/pud(). That also reminds me on whether it'll be easier to implement the new dax support for page struct on top of vmf_insert_pfn_pmd/pud, rather than removing the 1st then adding the new one. Maybe it'll reduce code churns, and would that also make reviews easier? It's also possible I missed something important so the old function must be removed. Thanks, -- Peter Xu