From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91A8C3DA41 for ; Tue, 9 Jul 2024 16:38:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46B246B009C; Tue, 9 Jul 2024 12:38:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F4036B009D; Tue, 9 Jul 2024 12:38:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 295256B009E; Tue, 9 Jul 2024 12:38:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0A5F06B009C for ; Tue, 9 Jul 2024 12:38:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A95AEC18B8 for ; Tue, 9 Jul 2024 16:38:26 +0000 (UTC) X-FDA: 82320772212.02.AF41376 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 709572001B for ; Tue, 9 Jul 2024 16:38:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WpytXus4; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720543089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u4kPF+jVZYaqYv+3DJpB7H4K1qcZD5HFQiZJHlOGeGY=; b=cnwDTPEE4BwvR7pN3C3o6SjOIjFDRINLEbt/iea+R6ZbZKdCJnWSs0pFOaRnz5V59kYsO/ w9y6NM3VRX3VJoTGmkTuv1E75yuDeNrz4A50xhvvoXZF8j847ETr3EKmfbz00d3XOD7PIY 56aS1KnapmqH4EbPh1Dukt4w9GPoCvY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WpytXus4; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720543089; a=rsa-sha256; cv=none; b=RryQiZ7EEIcB5Mj2M7Apni+Fbu1QmuK9FG1YnuUibOCMYVWFD2YIw0TEIfPFnRFQ9OCjSA pyI09hOP2Awwx8cZ7IMFHazQ0frcUzPq+Z/p8PM8DfF1E7zpFAiCJoR0pi25sWRFAk3f6C cTqPYBACQREhjQhdCpMCBqna7Qlv31g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u4kPF+jVZYaqYv+3DJpB7H4K1qcZD5HFQiZJHlOGeGY=; b=WpytXus4/67LYHQxKyVq8IgmMj vwWPyhQhfVWQl5R2oXGMEWzXoGz7UdJZIxulJAGqCcXKPw1r/YJCy+y36vi8dKPYs7oDljCZ3ZfSc UvWnO8qpOKMhEO3WAlesMn1ai2HgM8hQCQ+zBGjIAwPm08pwsXsP8HI4vcDylx3MFCwsmBMVFA0b0 q9el4xa9mBvtiTt0+g9qUPaNyP66OD09LVC+5bSOVufROy/PCMVzRNHYH4CpYWY+uXLxKc3yfQmFb uKJAIJ1NMAxISmUhq1IbkZMfagOzmD7KFAH7Og7GP1fnizOKJilzcIQA4J+D/qF7M2r0izlNS2UzP hBKtDr+A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRDr6-000000084d9-3wYB; Tue, 09 Jul 2024 16:38:16 +0000 Date: Tue, 9 Jul 2024 17:38:16 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, ryan.roberts@arm.com, djwong@kernel.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan , akpm@linux-foundation.org, chandan.babu@oracle.com Subject: Re: [PATCH v8 01/10] fs: Allow fine-grained control of folio sizes Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-2-kernel@pankajraghav.com> <20240709162907.gsd5nf33teoss5ir@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240709162907.gsd5nf33teoss5ir@quentin> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 709572001B X-Stat-Signature: 53budj988w8s7jzq115qhffjp3f61ifm X-Rspam-User: X-HE-Tag: 1720543104-130448 X-HE-Meta: U2FsdGVkX1+JSiiKkhLYs7LRKgMpabqKkE4ZDwV5tXFTUn6OCrmwiUPnRY7qSow0SY6Ig8QjHYf22pkG/zQDnb2s8q6jj8V13XlwV9R4twx/y92++BqDZvMFuz8ENGVwQ/DHZGigK4YCkkXqrIal62kj9r5fBxwaBSeC+HFn812vcopA4jbcplNVfDba/QREv5BXed9dJ1uDnx3OStoZlss+Gg69l6ymGchp/lTYLP3qEEzUoVa94uFZBpvgqlZ7g7nS2ktWToVXCZqFneB9/Kb3D1sl9EgAwGT2rY0tQQqg0hrFfPjupR9uH+oEbyS40Mkss2XOqHBdQ1huL6adbs/upHrcO4A0ymFahxvaVhB4npBtYBotqFUtcPdv6b4/9T7j4EEewfpL7LjbpTln+z9o95R9NbK6K2cdX+Zc+nl1KDVlYgPm3q5rAN4UJGTA+fJgUWaBQxwwpc3MW2Hi1X9WsJ0m9iBQHQUR6YFIIWYGxBjqZrYM4DbGqm06HYwCxFxtTEnjFx6dqr72R7v2BTsGdPWhXICgZiEJmO9ux4tjIKRUK7XhmRdodmUB1gZvoNN84DFYCD926VXV0q0Fw1yKEMyVlqqpHK0QRw4jSWspV3O/mbqXUnoprBbj0cSjHwnum6LeUDy0JjH3kSLFcS2xlu9CJBaP5CXnowAJ/nkWLf1Nc2T+vyRXfI+PovurUdjs1d6X3BYyrwyrej9AT+yA1KkHB7c6TVkogGqYu//VJnWrbc1FVNnCdtnuGSjby/SZw4uC6oVQ1PA8E0F54PPEkwpTuftoe++MK4wFCytsjYjQK8ubwOEoEqW0LJmvND1WLSnp2ogs6YbPAmClqtSWLb9QUaekG0nCML3BXl0tT1MSiQstNqMC5ayPamfyWHR5ZJoa3LNlcbwsbdt0vPvVd+lvmac7wuvrD9upQSGBav5ln9t6bpG9Q5wzz0/MrUj3sEMzlXS0WDZfXAa 2UZTYs6o A356gwrKoAUU5j7x+HZAjWzHl34+jzPnTHg/ZfwaTKUjLlp2+B8C3BSKwb6sdjz8MldUhlyuE1/DDdI37AAQF/BCEdIX55y2tUNe3izc7PJzAmjSBxGMQLSL6zBIplNmnQkPf3QT5gelu/vRONIHk25G6vtclFYebp28RczxZRidc8imfHzUJw+7/QnfMLgXkKkCO3xR8Wg2bBM4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 04:29:07PM +0000, Pankaj Raghav (Samsung) wrote: > +++ b/include/linux/pagemap.h > @@ -394,13 +394,24 @@ static inline void mapping_set_folio_order_range(struct address_space *mapping, > unsigned int min, > unsigned int max) > { > - if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > + VM_WARN_ONCE(1, > + "THP needs to be enabled to support mapping folio order range"); > return; > + } No. Filesystems call mapping_set_folio_order_range() without it being conditional on CONFIG_TRANSPARENT_HUGEPAGE. Usually that takes the form of an unconditional call to mapping_set_large_folios().