From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D701BC3064D for ; Sun, 30 Jun 2024 05:54:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E78FB6B0083; Sun, 30 Jun 2024 01:54:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E28186B0088; Sun, 30 Jun 2024 01:54:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEF6F6B0089; Sun, 30 Jun 2024 01:54:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B18E56B0083 for ; Sun, 30 Jun 2024 01:54:30 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1ECD7413EA for ; Sun, 30 Jun 2024 05:54:30 +0000 (UTC) X-FDA: 82286490300.03.301FC62 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id E01F14000B for ; Sun, 30 Jun 2024 05:54:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=pAw9B0ZN; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+5039b999cce98fb49ebf+7616+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5039b999cce98fb49ebf+7616+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719726853; a=rsa-sha256; cv=none; b=uSf0cghKYV+4tF10EVSHpPIAQ8PegPbAXk+d9Geaut84mj3lCoO5Ora1aJ5i3cHh9/bYFi 7yX6YBZyBuyntaOJ4hUzTb23VeR8mo6B1+PyAz/HbhbYUQqkmI0lKHudHAuLXLmTaR8Nbf CyAO7I1asXYHj9Bt47QAdhxdohtterM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=pAw9B0ZN; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+5039b999cce98fb49ebf+7616+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5039b999cce98fb49ebf+7616+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719726853; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MDg59NLD8mUHhsfqYDYe3xfqVav3nveSTGnE40tHyWc=; b=WKh8iOKz4FrjaRCrq3mDqkmAbp4UEgrK9nm1xYFOahWuz/gFEo44QE6vpK9G/nkTL4cQOt t5Ih/kroV0oIIRNd5IujEZZhHwZM+yZDvEtSk0rSXWoKzQryMxi59z80EsdVEVwpi9DsQu hJuUhS6P89AeKyttC958jCqgLbxEjKU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MDg59NLD8mUHhsfqYDYe3xfqVav3nveSTGnE40tHyWc=; b=pAw9B0ZNJZLkNlWApMjk1qFNk9 YdiUmqu3vga+oR9gDG6Iy30X5Wg0zVdLSmMa5dvEURHSVf5hV2UlMyUL8TKd8EOQOhV+DcT2Gznxx +XgUDLD5BOmiTCHyjUrUf5WB+hR2+GvNQR+IO9P0N+iJmI7TdpElBdclA7sGCEdr7JyZZI9CPsTvr xJ7sH6QSZQP5jhRer1WE1yjzqYSidlYjy+Ah3DfM5OWxbcIOPguI+HfEp2c2JQfBJZwIMHGItIYN4 mvv2+QDJI4cB4xLyDVCQMZ1Ccz/494RfTfxzhcqowMAP8hhTDuMfI1SS+rHiveLnSbyxzfLeZHEJB sZtG7Yvw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNnW0-0000000HRiR-03o2; Sun, 30 Jun 2024 05:54:20 +0000 Date: Sat, 29 Jun 2024 22:54:19 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: Christoph Hellwig , martin.petersen@oracle.com, ebiggers@google.com, p.raghav@samsung.com, hare@suse.de, kbusch@kernel.org, david@fromorbit.com, neilb@suse.de, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-mm@kvack.org, patches@lists.linux.dev Subject: Re: [RFC] bdev: use bdev_io_min() for statx DIO min IO Message-ID: References: <20240628212350.3577766-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: E01F14000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: et1acqbcfm4tyga98r7afxeh73kmbaf8 X-HE-Tag: 1719726866-751821 X-HE-Meta: U2FsdGVkX19c6FuTHXFWcY6M20CkzlU8smsz1fB1UMUylK0NdIXEc5VulmAr/ul55pe8vT5WBc9Gmi/ptnEb6cfmOEipeVnlSjYHjqG4P93yfKdM7ttHaQBNs453gCUDc5k5hh2v9QTgjZGOZ1P5xOxYPm1NijqGwgLcq/evE+qcpE7kOwHPE2UvuQFaVyi33dGIvWNRFTABkW0T5EdbTnkEJGEnl9dMGYmLK5o2xx8ejj8NxuX8kLbYEvBLzZGbupPRxU+1VhDZtjLvBKoE+3dbjYWPu2NSmL4WF0O8ExJImmMrYoQhT1E2gbg4V0RuX0kde0AHDxzTxRbUIUnMxrR1sveceD100XQOEEsL2BjwmY8BgHAwhwRWgKSFERAz61AYqJE09FjLCDj5YX/gkOr54XK11W6Kr+Cdtsgz8X7CD06IpdwZltyAjsqJumgVs438Tjgjnoik/rcIwQoaMfr9w6ufeg56RoUp+YscnFqOPl+f9GZrjL7eq6+gAJzOUJm0KUjHVhXbUx5Ro0HQEdbXxvxNrmVTJpGL+h2EyswtsVvr62JAuaxxdGi5CTjt1gFhHYUifL8Zj0RFYALIKUIbUY/YE6ZFa1c8fomdvli/hZmUxPjHcEVNeHfZly72yvVOEZyMKn5RMK0IjMYy/0SiE1LzYdNp7ckJBYEqpz/q9B9caTWmyQEBz/ENaJg2KBE3yzH8qFvENlcICm77uJvJKFZ967Bd1rpcVeFx36/RXo5V+7xZYTtxSWFvB2HjjxNGt1u5pno6vfpR6PujtCJkIQ0x8dTLHvKU+gzeNvgfRGRBZ4IB9+MbxyUHOLb5nd+r+X0C0u0qR5U2ADi8uCBM+eXPIrE1kVGvFQy4U+JUZW+NW87/b46kCm0Ktkk73aFOylBEnGlrXM0YK2LcPzO9ZXOzURWIFbn3/NwYMZsVR9zW5s/uWMtChK8DPupEBChD2DZdHtkCSUscaUz kPvfm0lV M9s974px6fAIQ8mRLwBHF/C1Ze0hCb8B8Uf1NQqmVGwix/oqjdAhQwXQ7JvQCrK8STtd9Ii+36KPpALghvfD4fbHgJqW83T28iYMV8TOV0NYHwWZp9psjeIVMKt/7GI0sre1pGDrko9sSS5HCJGj+yS7qq+hgkPCCvSdT6HzoJVzEr5sGPZZTUC53NcMtujq96oqBBzplgkn2PMYqbh7/1uvDEXGjSuV0jVqQ+yO1nfqL522QMTrDAZgd2xcxg3EjuTYuHZGhMeRIaZEXrRwYs2WY/7kCCJCN+3hpJEkObz6iD8o8KCDlhTnoCGD0dhiVCyYW1AM25/MdfL7bzd1/1P9Rhne6f932VOTEgDNhUsfDAekv+tr2Mzd+2qlUR/DxZ4cu93HIrkqV41ECU00ee3KbpoEWX/6G1o2LqVdTvfbLmXbgfdnbH6bDm5fIeHOCIwZyDdfbhpR64pPKi/fKHcu9IoMcN1zGtM4wFAZ770s/ILk0/PiDdn93EVZSb328aiOf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 08:24:00PM -0700, Luis Chamberlain wrote: > > The minimum_io_size clearly is the minimum I/O size, not the minimal > > nice to have one. > > I may have misread the below documentation then, because it seems to > suggest this is a performance parameter, not a real minimum. Do we need > to update it? queue_limits.min_io is corretly described and a performance hint. The statx dio_offset_align is actual minimum I/O size and alignment and not in any way related to the performance hint in minimum_io_size.