From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85EA7C3064D for ; Tue, 2 Jul 2024 12:04:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F20156B0088; Tue, 2 Jul 2024 08:04:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA8BB6B008A; Tue, 2 Jul 2024 08:04:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D490B6B0095; Tue, 2 Jul 2024 08:04:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B7EE66B0088 for ; Tue, 2 Jul 2024 08:04:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D654E42153 for ; Tue, 2 Jul 2024 12:04:46 +0000 (UTC) X-FDA: 82294680972.28.2DA425F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 5602DC0013 for ; Tue, 2 Jul 2024 12:04:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RLlELJu9; spf=none (imf28.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719921862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d9z4p2MzaEAaeaMBOOPYtXfjQBBoKbQHMUDRf2gF2pw=; b=rH51qtSoZrlgCUiyBnvnJOUNSjqfdztJ/ez6Kt7BRfYZLNsrJuyJS3VzJLkcgOa5+kcQrg /jv/Bxxi6smmGZjXVZOFVq805zdBjZfFCv+H91Uj2oY/Go2Q6K6Ampp9y3+qXlklePFRgh 9VK4+EKcnGkcFR6mQjHyQrHfrVGesRc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719921862; a=rsa-sha256; cv=none; b=RnDylMPUBkwPmQnYp6P379sLU75BbPnbJfNx8NLkWBnZXuZ44r80Zv9lQ6f7xK+aT2cqPr qIDOlJGSgEepfnBpZ9chByXf9P4y8UkIFtHFO+AdJUsMxkIRH22enMpaC/SEAFe9vke6+n /VdzhmsdMWD8WQATKXmoF6iBEXwxanA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RLlELJu9; spf=none (imf28.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d9z4p2MzaEAaeaMBOOPYtXfjQBBoKbQHMUDRf2gF2pw=; b=RLlELJu9ZDvb6/ca5kEpiffpn9 AXM4DXiayCCL/ue1TvQdBfuuONUrUp2KY9mHdvvHSFj8qiRwQCzBeWukZl/NQpK9fYgoDgolJ8RTp 7CatmwQKkCDwqrfPy4afHx56bsBzomm9Qzd+VOf4LJS/FfLKPcIKwtH8K8VJAhNUAckJqcXkxnsv/ 1DSgpoQZfYdkDzfQZHPxKk1P5B9K0dd6w+7mrLkL3mRX0bFReG7ANIUEgNso3r3fYPet5Y3PR16zh LpHCDFHjoVx3UuaRSrtK6EOq8Lbhh6ho3GKWV2k3SpssdidQ4MXGuO6V/s4r3aqANyozmhV2Nb1Lj TeYixs3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOcFN-00000006bnO-0uO9; Tue, 02 Jul 2024 12:04:33 +0000 Date: Tue, 2 Jul 2024 05:04:33 -0700 From: Christoph Hellwig To: Jeff Layton Cc: Jan Kara , Christoph Hellwig , "Darrick J. Wong" , Alexander Viro , Christian Brauner , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Message-ID: References: <20240626-mgtime-v1-0-a189352d0f8f@kernel.org> <20240626-mgtime-v1-1-a189352d0f8f@kernel.org> <20240701224941.GE612460@frogsfrogsfrogs> <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> <20240702101902.qcx73xgae2sqoso7@quack3> <958080f6de517cf9d0a1994e3ca500f23599ca33.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <958080f6de517cf9d0a1994e3ca500f23599ca33.camel@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 8x8uzw1ca4m39ych7j9qgm9ibuymrgkp X-Rspamd-Queue-Id: 5602DC0013 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719921883-226894 X-HE-Meta: U2FsdGVkX1+VbHFXWk+eNjHJnCdbScEmPFmyOSumsnUit7EjySbSmVf66fRiNovnVD1GNNTuZCmOqdSrFuvZSh3ejVtfXh43nOeR331S1Kk/exd5/QpAZNp/x3iItgLza1L3Mtp9AhEZxOKReTghB9arwfbDWEKYYD9SazNagbQtAoVDsUM5wvxdeRvKDy/7iJxYzT5X3RKUQVOuZycjyluBNmgLpfZ2nTKyQUBk8dH99N/O2MrBOK4bT84EUCDIZxke6H4gwwodHpPoOP1tgvgVtyJDafHyMiCvwdj+sRuIB6SRcqs1gRZ1Q5Gkou6tg/+eEqiI54khkZbHizmV78SoVbc+jTFvQ7/rzRyHWZBIntwW2YzdnU4T5bbejRWIQTO8EykghKYq2WXc0drJ6Fvoape5aSgCxG8NqwULL4Cjh1UNhmaSrqvxsHtMtwjJ2IyebqLpUt4ekZq2LQLd/BVbpGWj7HZ9HqaBKurcRlNYLI9Mt/DOur6KiGQTAL43apALUBgjBf/8IlkStVzuyaQCnwHJsaRRMNrKTbiio0AEOlpwj4Op0erfuGSOHpr87rc81n1FBeDrieDc4ggoKmVRrD5balKQZZ0qA7k0MQEbc98Q50BpyI4cNvC7bctRx34a4raVQZfjMZOJDgEmuGvLCOwKRMayd9OaBhsLVrnP9HF06hkCHVz6z0Rw2PAie1zNxnWWQJNPr3K2rRRs2JZ0rUYzAwsWGO0X5tXtRxtHjRQjB0PQofhOY4kav1v3NuLMOLym/ayXxwO5N1HjgZJj5L86fjEiP21GEFadXyqxWnPvQYa1uMWPd2gO90iyMu1lTT6LyATRmDWHkQinAXgWzmWy25Zp13r6GIqw6oULCzFOCfEuv+xUoz+uYFHiX8EzydeDxF0GPylVr93BwnBPYPRp7288iJ8oe+HxYoXlpBEp8vEcnKMiFlJZcRs3RTDjyEfC1DV/jZiGSlq y0iGi6E8 T00/+f0jMqPtX18hl5BHacmzd1d7Wu9t9UH6OztxumFVekhKTtdR0pkGWu48lOL8VHQXLFU+ZpAUCisQtYAnX9BdYTR6oP3EEmZNR5tfGnPo7H2rtW3bmRVxU8fFOuLulOhwkVHgoOoomuh514fplQ9KAsOevOol36WYbInsS501Ou5Gtjbqo5SLvNO3xRaMVLCYHiI5KKYCBl+PjGzlX16mrygJ9E3yolaEk7dzCalvbBL5fIUSfuI5LCVBxPZRp+bSIk/bSLe9UQXRSgEX+UW9kt9r5Js5XjNAAkDhf2I5fj5LIHLrUFjp14K5innPU9NOid27PU7zm0lfYmZ1F/ThYnPpPOesfr8A+rcTVH3+ON2UkpT59D546zfNwW4E5DWqMkBSCPi4Nb526OKqLgPTkYTQjtktDiu907KaP0iOoMtWNtie3e5+O51uKj2K1kc8EI+mY1PHaHZt2497o8SOpBlAMO297R6becMNnhR+wKbxoKry2nV66SwC0iKjvmQxI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 07:44:19AM -0400, Jeff Layton wrote: > Complaining about it is fairly simple. We could just throw a pr_warn in > inode_set_ctime_to_ts when the time comes back as KTIME_MAX. This might > also be what we need to do for filesystems like NFS, where a future > ctime on the server is not necessarily a problem for the client. > > Refusing to load the inode on disk-based filesystems is harder, but is > probably possible. There are ~90 calls to inode_set_ctime_to_ts in the > kernel, so we'd need to vet the places that are loading times from disk > images or the like and fix them to return errors in this situation. > > Is warning acceptable, or do we really need to reject inodes that have > corrupt timestamps like this? inode_set_ctime_to_ts should return an error if things are out of range. How do we currently catch this when it comes from userland?