From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD1CC30658 for ; Tue, 2 Jul 2024 12:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53F566B0096; Tue, 2 Jul 2024 08:15:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 520746B0099; Tue, 2 Jul 2024 08:15:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DE1D6B009D; Tue, 2 Jul 2024 08:15:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1DC616B0096 for ; Tue, 2 Jul 2024 08:15:17 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C48D6C2118 for ; Tue, 2 Jul 2024 12:15:16 +0000 (UTC) X-FDA: 82294707432.11.3D6D590 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 7AC6012001D for ; Tue, 2 Jul 2024 12:15:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BkRP4wh6; spf=none (imf29.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719922503; a=rsa-sha256; cv=none; b=0dY7m6roGbMQCJT/J0F/DQuqonUaWQP4VbRKZu0JPOCJVkiV5K9gTbJKmZMsEZtCFSJZSI PwFuT8ROUqHjSDYqeNMtvKg+ESXw+yqn7Expcc7gUrj7gP9Ca6wLJ5YA6rEaixr5g2T1n7 uGUsShAvcLwrXp1QuRU+HDu8d7Y6WtQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BkRP4wh6; spf=none (imf29.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719922503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4H0kn1lNWzVJfOABE8UVhmMrapLkOqkflBiu0II1OzI=; b=An/IGKURDqhbKjCCDvgf2VMm2J0qHFACrlhVT2+T98BYYPTcaZqYHvqYvADj8/j9i3Cd3c EgLein4JO4JUZ7UgD4vjSp3YxtwBPXTowP+Dr+KzrCLDUWZceP5kH/2OrMxyqxfBRvGJiA 2e9jJnSJYOEfzWMVI4oCxcjl3Wv8aFA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4H0kn1lNWzVJfOABE8UVhmMrapLkOqkflBiu0II1OzI=; b=BkRP4wh6h5/M14B1AqqGglvNcX iwivozmzpyoWh27g/3lRhEJLrmxdm1tf02XoZ26+xBicXfsIpJuturWphgXWW7rvN95zuXNqYgDQR 9UIkUGf3C2jrueKsbdD1Ky1jo5iRPz/W11ehsVYkllZ35LOsCd48VblmSG/IgOmtaXrnsy2WZz8hp CESuZMR/SYEHEPla3jWILQ/PYhfoMfwKULLddVzXgcZkB8zT6nViFpsn1tESLNDxrXxODCZewyjYP 2eoTrrBtZ7DYLNQL98MRR7e5zUdKhSmb7tnywmPhxl8XS2meRungD78uUInbOm3Rezf5D+IEVZC4/ GDIK3Ihw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOcPX-00000006ddf-2NOb; Tue, 02 Jul 2024 12:15:03 +0000 Date: Tue, 2 Jul 2024 05:15:03 -0700 From: Christoph Hellwig To: Jeff Layton Cc: Christoph Hellwig , Jan Kara , "Darrick J. Wong" , Alexander Viro , Christian Brauner , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Message-ID: References: <20240626-mgtime-v1-0-a189352d0f8f@kernel.org> <20240626-mgtime-v1-1-a189352d0f8f@kernel.org> <20240701224941.GE612460@frogsfrogsfrogs> <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> <20240702101902.qcx73xgae2sqoso7@quack3> <958080f6de517cf9d0a1994e3ca500f23599ca33.camel@kernel.org> <09ad82419eb78a2f81dda5dca9caae10663a2a19.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09ad82419eb78a2f81dda5dca9caae10663a2a19.camel@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 3b8gtja6bkftsgad9d551sczhp7m9jyd X-Rspamd-Queue-Id: 7AC6012001D X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719922514-65311 X-HE-Meta: U2FsdGVkX18+aP9W41KSTNHn61ETFVMm9u8/LRsIm8iLWP6TLK6n+KrhOPiAGRPr0XTs+w0fVEM4g3d7vYWcaUFxJB61Lynq0+jM38ZfE3EipNxGYQVOa7aPq6uhnzNH8ZsXQ+/zUnsdyYhPnP9URbu2k5zHllBNZakDSDSSrhdF7yvaawFQwSPDuIMNd70XSW+UkdsoGEgRqJkSm3HG2T4bnJoaQekn9FBMGYKBOBlk6ND4HPhsjisZ5kzbgwrlBj2/PSQJKQRSdKQOpF91XjLuqQik0vt9kyYBzcG7CSqvHP+ypuy/XH9QPrw63RZyxq7BwuZl7qlfZv2ekVyaYVB91gbuSpsAGXiaUvgbc8MxHvrHeNjmPMQsk67kPV2HTj9/Rd1624QcqDUSwIpFlQjBFIR67xv0r27FkpNClLgTj3IrhAfhKB3qbeRFC7fxl0ycckt/OdzCPPz+Dc4Eo7F4jSZFttlNUTfFVEc5GUIpUgU53YlC1fWSGNcCdL59l39W6xZ9NfBLv9E9Xkj+5AzrqnQtLI7h+Mz7RX+PyQ0kgtT3YMWv8iWH1B15hMsfYv3HUEAbjuqjnXA/APuaZia+wfuiTxdi43UFSLFGFstEzRNdXWdViSa3g498y93FtkF8W1Wc0OB5pG+pWvj9lwAg6TsSM/+DvEjQFLwB9W+FYRo3xNipcs5JtRG567wdyrJfPhiOsB1LTCX30QNheANKgt8jRE2QK4UBPmQ2tOF+o8a9B9faDwWKsZ16v+3ovGtzHchA6LeUHdjMIU0YDcwxRqW6/B0mFDWanjz3fVYzgaoWCmKv7xFo7IwOpUOSH/F7mGohALjyLJyeJM7cOL2m5bpDC695cl0n7MrSSpwsDZ9R8Km6+exPYUX7mGQBn3uMXLgmjW20lfpXl/+wBXXNGDOXFZ5fMG46EAc1tH8f/IqS1hK+fnJZzJpoAtMK+U/9ev7oC4MqcD6kLC5 f1Q6CKMA ONTXGendK9ZJ3lCVpbYMOtu5XjTPa7fD3HbAVIq3sNw+RG5159BBRPz6BtrRsgowqW4yN4Q7BLFGLI1yatcTFt3yF2eo7KTCDD/UF9pvO7whETOJCK7cP+wtJ3i188W6EmTNQenOCb11Rhydbnhwlx8wkfTHMkIYX3tXNAhbeIt9m16mCGbWcyt7TblKCNJOb/FX0mScrFknNGuhQh8uj/0/bX85ZdlD+to0PTA/NBofldz/x5iOEz5QDxEVNWDKL47FoTFSIORp3DXk4dGiGa4kBGbZM+kx1C+3LIiQ+TxAvxEXFytfcF5NFa55U910lkHAIPYk8ZiJMUg7WQx9nVgyIq1JgZCEGNoMPPJ7kRQxNt6tvuiV+bYWHFRWxkKSVXFYKt6TGMYzpTUBH0AlErNm0TxmoD8ezTRpvdi/H/MlzPkb/NqVMJki75055RrD7sR8xPeQZtBQSNxntImYshveSj9eFhl3FzoleC98u2WB79LxFyeJeyJ3s5rO/6eqPXbFt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 08:09:46AM -0400, Jeff Layton wrote: > > > corrupt timestamps like this? > > > > inode_set_ctime_to_ts should return an error if things are out of range. > > Currently it just returns the timespec64 we're setting it to (which > makes it easy to do several assignments), so we'd need to change its > prototype to handle this case, and fix up the callers to recognize the > error. > > Alternately it may be easier to just add in a test for when > __i_ctime == KTIME_MAX in the appropriate callers and have them error > out. I'll have a look and see what makes sense. The seems like a more awkward interface vs one that explicitly checks. > > > How do we currently catch this when it comes from userland? > > > > Not sure I understand this question. ctime values should never come > from userland. They should only ever come from the system clock. Ah, yes, utimes only changes mtime.