From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AE3C3064D for ; Tue, 2 Jul 2024 15:12:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9FE6B0098; Tue, 2 Jul 2024 11:12:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A416B0099; Tue, 2 Jul 2024 11:12:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 578FC6B009A; Tue, 2 Jul 2024 11:12:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 390A16B0098 for ; Tue, 2 Jul 2024 11:12:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E9E2B1C0FF8 for ; Tue, 2 Jul 2024 15:12:48 +0000 (UTC) X-FDA: 82295154816.01.EB40082 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 7D79814000C for ; Tue, 2 Jul 2024 15:12:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dCljCzJR; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719933140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8aouOiHZz/CtkLH8RlphiC+CuL1fGX3TYjmQQVPOhZE=; b=bUvAxaHzX24DSSXKOEq81/WQuu4CdVrLkDEow8efFvabJ2YgZKqujB0STMHQslOkLFr8cR H4rLnMRuFfSqjXY4rNDgQK40cyRcw55SqzUPI3GkSr642K1yJALswz3HqPhAxZt7ioRGLI Aw7NBVjE4VLPy+ujWFGpIWZ4xHEc72w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719933140; a=rsa-sha256; cv=none; b=JM0OsevYFjBUrreS+hii2ycTAHflgDl2Z3IWj63nm7X4R+987hx1E8ZqzOall9DfuBwxW4 wW9kqZbiwb+sZ1FDXRZXZZ8ESSyyXz7zcEfL1L4EGyQb6+sj9Ar8PWFVX5hPVjNcUzhHhq YtKFWScwhEDglFrJoUc3ZXbtpJGw5NY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dCljCzJR; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8aouOiHZz/CtkLH8RlphiC+CuL1fGX3TYjmQQVPOhZE=; b=dCljCzJRSfznNuYHX5KeHFLuWV 1bGB2/E0ElcUGou1naiVTb8GjiRYIwBvBWILQ6RLqqRbBdOIErpJ+SWkBWdjlw0iN1lSHfonwrj0h wVdYu0AnkD5wOr6zpmOvc/VRJ7EyUE9eLSu3jJDW06TfZ4HwOGaTRkiCfriacF5Wo6FBnITHbgOe2 cUWZdK2jsEKUktlwltOfhcgJvoqG4q8eukNIK7KWBynHYywL5TPP8gs5jg82+w2Xyc2gd4deZhrue H21CvG2clgGVczz798MUMmJhoWGmR3TMIxyr1HailAgCTaIgccNe/f1h4oVzV2bhQzXPmu4J40qQX V4LqdFhA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOfBK-000000079no-1zHc; Tue, 02 Jul 2024 15:12:34 +0000 Date: Tue, 2 Jul 2024 08:12:34 -0700 From: Christoph Hellwig To: Jeff Layton Cc: Christoph Hellwig , Jan Kara , "Darrick J. Wong" , Alexander Viro , Christian Brauner , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Message-ID: References: <20240701224941.GE612460@frogsfrogsfrogs> <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> <20240702101902.qcx73xgae2sqoso7@quack3> <958080f6de517cf9d0a1994e3ca500f23599ca33.camel@kernel.org> <09ad82419eb78a2f81dda5dca9caae10663a2a19.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7D79814000C X-Stat-Signature: ww93cgeybbghtyh61d9rx88st816mrnz X-Rspam-User: X-HE-Tag: 1719933165-441346 X-HE-Meta: U2FsdGVkX1/SuQ3WIftzj9OA+wAg8zo2NT+N/MNHBSP55FtY+1N7iyuZHFtliHYxJRH5Dw8cu6Huptwd+S0QGrRxc8pmjjfIWEhJx72yvv/ML14WeV8au6F/cbW+I774SpM7vc4yL/1ANxjzfZICbeg9rOtBGKFZSc5henuiDQWPQInMqMA0jOzpqIvr85nk51pLL2vnCMCMVqWcRJ2/BCLxnuAjsgb+D/7weOsc6Yx57VaCpblFsVXtIhksZUF8TQ78QhHgViGUuKRBDMWfIDtjQZGwmNNuvc6uxO21cj1XUas6fXsopDyWB77cMQuq5kXwKLe2t5VILyp3jlxKNC/vMbUC+FHyqCRwMmDZ5aE8vOOxSkg/5+z6pvNQm/1n2auKI/sLvCxBh7AYkCXa0kUuzsqoiq4l0YvH//pY0Lbk8mRnU5NNWBJOHos1/oiIiCPlYQZ3xnMklvebY4e1xECutGajSnzO98o5XfX/98VTbr7/m5kQQYPkrw3izk+xIxtjr72VVPInvuPjpT66sZnPZ7Wwm+hZdU1Y1Qa8+BhXzvLSY8rNwoRkyrcwqOGFW2W20ZNNU1ggri4x7gfz1wA4R9N9vCE4UKVsHZggt6XMxXgwmruo4SVzN5b1xR6C1e+Dm3Q2zSxvO8c5QlGksux5X9DvJYAdAvNZN/GTfMJyI52Qzn5qVRQA8aYZcCDp9L0h62fHwbzX8auvuT+8T6BkChcwnDjL+TweF/Q298SPpgv5jRIAgzjF8YoVQvPGL5SLrrC6EtV0v43JF+GJ8n3JJbAa5Ems8M4gmU1k0/6Ho1TU19kUoOcTfujNqC1bZFdv1o2mGMQQTZyPQfUsqjMFHzXdhQCUKaDEcO8s3Vhbw65/pJXAeL1/FyL6b9zNX11KnYkTHcCz3peHG5GAN+g9PTnECC1k7mrKq0ydIWwUzc1+c5PWID2xxcH9QE/txFnZrPsLBDLt19nJ0wA VSsNAfxC OC8bBypgCWgkoGdEw2/llf41yED9LfPJd0Qv2qvC2fvXDhzUg2ej8PQI1VpeXKYKKaq/oYrbnczPooG7zuCtdk3o2CqUcfW4rSQc/0svIxi6wS6ScsXfCKTUu1Iy/8yCYZB1YVNhLP920vWOHXLftlgabZk0WRlCuRpwJzV4i4CnKXoOLhXIxF1wIH+bmTNx1ESjGAfmaYNgvumN7IK1cRObLQtja9qiocdIo5TlLwKF2LAAMED6GIeEeAczQXAfup+kD8jYriIDnGEs9lPlsKAnweG1u/XFl9nBUY9uXCgDbIi8Y2gBmFen1cj8RLdFs9PQQ0pMmDQeM6hraECSLd7j9naYC9S9vKf0dRYndn4MUIoMqavMzhWsZiUvFvneflnr/qa3KwkFwiWr7If4N0yRe4u+wXSxIwE00sYxIWys2dPlkQ/GF5SV25YIJ62uJ0ydl12XpfywGeKbINM2eHgVWDoNtvmyz+SXWMVOpToS7aTNgMYWThf4LFdGaV/946nTU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 08:21:42AM -0400, Jeff Layton wrote: > Many of the existing callers of inode_ctime_to_ts are in void return > functions. They're just copying data from an internal representation to > struct inode and assume it always succeeds. For those we'll probably > have to catch bad ctime values earlier. > > So, I think I'll probably have to roll bespoke error handling in all of > the relevant filesystems if we go this route. There are also > differences between filesystems -- does it make sense to refuse to load > an inode with a bogus ctime on NFS or AFS? Probably not. > > Hell, it may be simpler to just ditch this patch and reimplement > mgtimes using the nanosecond fields like the earlier versions did. Thatdoes for sure sound simpler. What is the big advantage of the ktime_t? Smaller size?