From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F234CC38150 for ; Thu, 4 Jul 2024 14:30:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8965E6B0088; Thu, 4 Jul 2024 10:30:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86D506B0092; Thu, 4 Jul 2024 10:30:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 735066B0093; Thu, 4 Jul 2024 10:30:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 589036B0088 for ; Thu, 4 Jul 2024 10:30:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 070D3120ED9 for ; Thu, 4 Jul 2024 14:30:07 +0000 (UTC) X-FDA: 82302304854.15.B43D878 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 6AE7F14001F for ; Thu, 4 Jul 2024 14:30:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vm8Ngrou; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720103380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Enu1N6gk1voQoov0gxRGHrtuHCfIvfGXa28Px1K5WpM=; b=Jn2sj+D+3AUzbcDovPkakFu7u7R6Sv7k/eKNUvyQcLYy9eWe+FC5xO1IwudfmuZBOv6v1a 2sIOW5T61vZF/Z7sIcONUucXpox6+ag1ztqClQhBGyxvWScNwhcz2Vk8jgtoKPGpaCeZVr 3Po6cPlhIOYjSf+UlM8rF+2shUoDa2c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720103380; a=rsa-sha256; cv=none; b=G1wlAEn+Ogopd4epJ3HgCssPZcURD65XYSSqeBUQXYDTDeZb/nZbXrkYjtl/aCekVVOsR/ 0gX/AcMyDeTst3xNvGhfD5CRn7olhKZ/k0sfZWlx8vWRCLG2XYJwNWpj5GNUhKHVUFZdvZ mNeuGQGSCorLS7yeeM8PqifS5FGErrY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vm8Ngrou; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Enu1N6gk1voQoov0gxRGHrtuHCfIvfGXa28Px1K5WpM=; b=vm8Ngrou02qz4Ib5mffZwNGQZl IyaFQ3g17dLdwT8o+mc8kq8K1iuGCFU6/DwMXKkWeDCu+ln7bMJyl/jMqN6i1dynQImA/pHHP4pvY 2Ktm0BxsEy5JnNZGDr7GViK1/fQrzlJzPW5+ildcGB1eGQKdtvUd4Ga1R635z9bSN9RlbUIE6njyq KSoyUFoDFIobHWvVBF1jV1SgwqI2ys7PU8eNZbofKaLcAt0kx3PfCXT+eXVyDcBImMt1IHXGRcP+K lYYl5L6DjuSSj7LtgWvc2YAonwrhpJRSseSgkJ+jNHELCIY2TsAIP5L99YQX66FYVBsUB8O2TKGhQ +9vF92DQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPNSZ-00000002vlv-41mX; Thu, 04 Jul 2024 14:29:20 +0000 Date: Thu, 4 Jul 2024 15:29:19 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: "Pankaj Raghav (Samsung)" , david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 03/10] readahead: allocate folios with mapping_min_order in readahead Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-4-kernel@pankajraghav.com> <98790338-0f86-4658-8dec-95e94b6d5c18@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98790338-0f86-4658-8dec-95e94b6d5c18@arm.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6AE7F14001F X-Stat-Signature: d8q5o7ixhwz3xnupfr9sw8wdirhf5bmw X-HE-Tag: 1720103403-128501 X-HE-Meta: U2FsdGVkX1828PzXRQA/zTw65FI9XmsebLRfFp1XMkoBxMvJhGz3cyL77CdfoWzzSKhXwRlLf22AjhFwDEwALZK11sBwrU4YNc+4Q5nYdk9+HxIuzTH+IL474SL3Tn68X/m2rvHjlDgwhd8qnuWJOyIBQUA7pRp+yWw7e5aydMUOVOj6OVZ0hzRTCCrolxwGpCoCApZlpWIn6V3VDMwaj3sn92juqLA0D/AW3oflz2b6e9n0gucZJD0ifjrloQyUd8Pn4+xE0nN20QKfcCFWVKhlVjjUf4G1vKiIgG1THyoqOHAokNbwnIObxO8V++zUl/YHtvGVgeb9WewFK4NsFIXb5VPCbd0yKVgaaFERzoKVwcd9RIFS03R/rC70F3X4pfHjIbdwTXdbGmJEsTvZbpJ6mb6+ViiTB658ZYD/ZvZImBEpkk/S4iCQdXLlh2O8U5/BJ/T1VTzz4ywq2SLaUiqozC+0Wjl+z3t/e+FMscLGiPFB24GSTye7fgCZIOQ94d63+XYMr+eVguRImH8jaP5NkPY9uylNIyRZT8R6N2vLNUOiJ4nGCoLj8N+NmiiaeOOSB8PzRvvHsEftwrupabxppR7l+Z1own24oPRPQ3Bz+UzyTQvmA0C59dU9kBMXO/kOC02t9+1PXAQRjhVx65XH8qWNNOwpuYAQp24zROrxMtOHEO7j2LMdKW5JqjcHf8RigdvL71K2EgyBdrpIkyMGNddBXEhmxWw12aU8hPVWLMDgsvuONAh43hTzI+IHZWYAobaJJuQl+2aungIE8elNCPsx/eCb9SaZXUcX9cGVFKH9YdNSAIf+erShqDAHZwuzIjwjnkmvHQ412nWhpOw9fCxRZmvU8T29Rc/hOAr/C2Q4bEBly+oWQvmuShe2MhgOHJ/gOhkiznDohGoC030IRAzFRNDPi7H14Hp/YhahHIA1LWOCzqzf2DtgcSjjliuZXEw5EVUwbe5DWE2 sKXIMoTI 6YjjA2Oh2o7dLTOy6wZtNEbH3ZODlX8Cu3wX5TKvsL8K3a2Fj+iI1GGBJvZxd6Cur23O/Jyg+onVrzcEqAPycThScWRjyfu+LFdBRyBaAImF1kEVztErZeQfkeuUmlbCwBLmMmNmBGkEFgwfjx4DgZ8/XNTmzlMzBRJu6nDjKNg2ZNuhHYqhsb6F+blRmW0CgCj0M6o+ZmzzTgP/XZ/RgUfbLD76gY+bjh0kdql0XJC7I/t9z3n8eXY+xsfkMdnwrK1KOvf7NHvT9AhgSn76SKTiaAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 03:24:10PM +0100, Ryan Roberts wrote: > > @@ -240,12 +257,13 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > > * not worth getting one just for that. > > */ > > For the case that the folio is already in the xarray, perhaps its worth > asserting that the folio is at least min_nrpages? We'd have to get a reference on the folio to be able to do that safely. Not worth it.