From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8230FC30653 for ; Thu, 4 Jul 2024 19:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03AAD6B00B0; Thu, 4 Jul 2024 15:49:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0E696B00B3; Thu, 4 Jul 2024 15:49:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA6066B00B4; Thu, 4 Jul 2024 15:49:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B4C536B00B0 for ; Thu, 4 Jul 2024 15:49:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 713F616123E for ; Thu, 4 Jul 2024 19:49:44 +0000 (UTC) X-FDA: 82303110288.19.5FFBF87 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 15D124000D for ; Thu, 4 Jul 2024 19:49:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lWTNjUV3; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720122557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=23UN5iauPHTCS5OpRoEco7H8tb49lnIlqtiELf2idnY=; b=NFR7gAQzdeF5j/YT4h8plF3hRJA7Jg+wkwMBGhcIS+zGUtIomlHvjgWDy3q1iIelmqX/X3 jITT82h3ERQd54/t9px0JwUReaqNmRUBciYOxmC5hkk0EwmJIehIOeBf6NVoFQQAcOZERf xiQdfu549GU6GMO/3rgM78LIeIEKM7Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720122557; a=rsa-sha256; cv=none; b=7g9msDEy2na3WVrQ8jSUqs+4uxnZbDE/V9DutF6YP4/JUGK8t9lx4rEGf3gYR9kSUhv9w4 MxpRRU7A3oGvg3JVWJNQ7/y1/MPQBlEupRRNq4AVdepH0pOhwR4ALycaTKliSFlhXWydV1 iNpDqgZu7P+z4zZZY4jJ9mvPy5udzUI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lWTNjUV3; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=23UN5iauPHTCS5OpRoEco7H8tb49lnIlqtiELf2idnY=; b=lWTNjUV3Z8NyX6a9ceffRK9Y9v TRk1lXW7peMuQNdleWNiDRxHDAcjfsSpv0y+Ukp/xNECrgRKsN+igzgubfSZW1bvmhG07ntg+f9KP QjU6JoW++IckVHh86fmXy4xuLIp8TmCh/6QKh7hepr4t19QkcJ0TDEVzSYndNohVSNgXs5bJbuxp8 czrrfptXFMDrKkP8smQkhCCN8wWWMTrZiE6d01R8ViijzdrTzQvtpVQAVROcMlH/C9UqAU1c+LBSd cJwKq17A0pnom7t8K0cdacBg0hOaqBArDJj0MuMQIaNXmWFSlKsJ1YDc+vfazzY9DQi1cP6CNzKqS 6DgH0QHw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPSSK-00000003Cat-45m7; Thu, 04 Jul 2024 19:49:25 +0000 Date: Thu, 4 Jul 2024 20:49:24 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Baolin Wang , akpm@linux-foundation.org, hughd@google.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/6] add mTHP support for anonymous shmem Message-ID: References: <27beaa0e-697e-4e30-9ac6-5de22228aec1@redhat.com> <6d4c0191-18a9-4c8f-8814-d4775557383e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d4c0191-18a9-4c8f-8814-d4775557383e@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 15D124000D X-Stat-Signature: b6rit1fdejr4ieq7bamogj8sfnymg9gw X-HE-Tag: 1720122581-324144 X-HE-Meta: U2FsdGVkX1+BAEog9GIkSgQzqeqBszlym8EFZXqB5O2ulcBQaBWmYkpfGw6X2yJcaX7Dz4+Ivf3XJH9rCqBtIYqaKSfO3DR0ck/zL6LywIoIvvNaDqnT8aME4oSK1KXG5xoy6TZSK+U9uqmodJHHK3B2hHQN9k+UDDLcdN4dWfj6L9mOFp3Itkv0x9Slh1m2i/iKwuLc4IR/jtW8LF9CmgcKWjRSz848PAaQAr5xAl8QJRHZHB4I47mk8vA5giihJO+X6+2BiZzhvyFNjG6MVBmy/+ocSNBmO13TSf2Wa2RQYy3QKq4exKYVsb8DkFkyrh/Tm6oGzJsgvwJDmwRi3K+Th5ta/5nPXorDQUREIoLKQkf9fyeQJJRasH8LWb46dR4Hfyq4ZAIqtEpRyW1i/500e7Hmus7O5cq6AYQqqxLyYOd/S9guaJJUvQvgNbar4tzPuky0E21l+2xWD10ShwbqpUgoAy4ldmWD1mUgPRwxNJquBP6ioiWPU6TG+HFhOoX1daAucdugnK7zf8fVOklpqsIDRYXx2eub8MZz/yDrpTU1s3610dojYZcJdAUf+pR7M+3n/LF/zkAoedWn7noegKkZe0zrcQ3AIBvPe5Zl2uNYZQfH2QaukpvUSE/YBfmwGhYK0R9byNVw7XHjCDzylkB6L5NNmaXBgmAJv+P0qGJb8nTmjpWE3gWOWoD6uEcDE9n+ThF9X5BvLJNECw1x44pqXUGioKkJhbj9kP2dn7DlCQHIfkDLyemkaAOwsAvoaTvk5/t47SK1wa87vkkXLEPktT5T0xdC/t8UWN68dNVcAtONGH6G3iXEZ26AYKQ832Cz9q8wGwCrlJsCNNiHpb6T6MH0kBlx1de1fF94fmyWJCsCGlBrYDT0SAdGHKDsM18LGq5zGB0s2lnIQeJyZ8hW72+ahVBal24EOyHLjR75obd9TJNYSA/Z+G69mGguaWLVPLuF/pmfArs 7ziRQF3S hJu8wM2swQGdNbd6kr2YmwG/XCkREu7Vht7fokMtW8EN9ccWfxY/ecLDM9hWnEJWwHdB5nH11Mnmlf8MiCktyOohII+b3xDXkgYah9AFLV7ySOYtfEYOZOQn6BdTSdYlgnMcoEuGzVvgpmRAdSxUT2ZeEdS6x2zEMQFqX3A4th9ifSbtq1sNlZ6afBQFM3oe3gBtsPP0sjks+MgBh+TIHnIk3yY9X4igg9eaHCiKFj3H7syLzyhjzhqMP4P/zpaDwjUEQhcWv5YzcWPFmwvuI8N9sMHM0dsaIfl/9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 09:19:10PM +0200, David Hildenbrand wrote: > On 04.07.24 21:03, David Hildenbrand wrote: > > > shmem has two uses: > > > > > > - MAP_ANONYMOUS | MAP_SHARED (this patch set) > > > - tmpfs > > > > > > For the second use case we don't want controls *at all*, we want the > > > same heiristics used for all other filesystems to apply to tmpfs. > > > > As discussed in the MM meeting, Hugh had a different opinion on that. > > FWIW, I just recalled that I wrote a quick summary: > > https://lkml.kernel.org/r/f1783ff0-65bd-4b2b-8952-52b6822a0835@redhat.com > > I believe the meetings are recorded as well, but never looked at recordings. That's not what I understood Hugh to mean. To me, it seemed that Hugh was expressing an opinion on using shmem as shmem, not as using it as tmpfs. If I misunderstood Hugh, well, I still disagree. We should not have separate controls for this. tmpfs is just not that special.