From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1360C30658 for ; Fri, 5 Jul 2024 14:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28C436B009D; Fri, 5 Jul 2024 10:24:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23B5A6B00A1; Fri, 5 Jul 2024 10:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DBEE6B00A2; Fri, 5 Jul 2024 10:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E01A76B009D for ; Fri, 5 Jul 2024 10:24:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 050E88016B for ; Fri, 5 Jul 2024 14:24:22 +0000 (UTC) X-FDA: 82305919206.14.898F10D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id E2B6B1C0013 for ; Fri, 5 Jul 2024 14:24:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GomyGT6q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720189441; a=rsa-sha256; cv=none; b=resJuH/Cjpp+lowyPPLi0TVsdPO6zPPx03BCjHIhxL2hDhKjcMnfMyUuXmVREA2tr/3GiW er+iiG2FSwCkFQnkWTf5VvQo2pomRQHpT0DKGMqWwCkMK3BpT1ESVNnXezWMK88t6gvRFO itpZLToaVSB1fDnZqCCHufZHVTjPAKY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GomyGT6q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720189441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IqBTg61cVL77faXIzfdAxULAIPGMk1ZHXjVPHmfrZtE=; b=CPxUTydugfTv8W3efWU4Cwmg6dVdIP6T4rMA0tgQJvdb7NJCG6ywr52GtURXHbUeHnJutS FtW+VKE/49/v1js5cu3JChir5WTkoEkMsrFrOUXsCAW2GKL/ceCnKp6FohR5Zs6kYVNeL1 RReggmf6t/e8oiJdZk272MccgXTiayU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720189460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IqBTg61cVL77faXIzfdAxULAIPGMk1ZHXjVPHmfrZtE=; b=GomyGT6q4Dkoew0pCRUYAoml9aFCdZYOXIEQEjz64CtThBXoFF7Mra3soyxFZs7BYZGnr4 vzGyfb+mUwBbgyhfR+bveNOh3TOMIFBnkRrYodstWMD/mhDtfkrnQteBVO2+kFcUWqNqxi S8ghGxK+13S2T1g7QDuve6Z+12fHe3M= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-L_6X062FNiKwYWK79hj6aw-1; Fri, 05 Jul 2024 10:24:18 -0400 X-MC-Unique: L_6X062FNiKwYWK79hj6aw-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-444fbad91f3so3113971cf.3 for ; Fri, 05 Jul 2024 07:24:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720189458; x=1720794258; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IqBTg61cVL77faXIzfdAxULAIPGMk1ZHXjVPHmfrZtE=; b=hRy1PC3KQPi24dY1f9xmPDND5fbUI7qNBh+y0nVKc0o++c5dTDhTtCADbm5gluh8az /Cqc6xR4lCYqGC/ius8r2QiGi7opiPdRPNR3+rrHBpkcfJd8OKgDmgj/uQxg71l3fCJj DJCv3VKOWC9F9etmH0cblbF8vDeDPTwPLqo9/0gTdNayHjcbOvjIlfLzS0Y7PLOK5fsP nbur4rpTKIRDjz9rcP5iO+Nq+LCRDqqMWEeBCAXP7qJ43nHv9WXKlya5ltVadseCD85h Dsktf0BXWMgXv2NmMjOHxxwdG9lV75HiWef2hF9Wp1pJ7Kx/nhUnDaYoyWdjlYRGD3xs 1klA== X-Forwarded-Encrypted: i=1; AJvYcCXj8b/YD0+DfHleQlZ9qukNxKLmgSrFHFw3sHDrv43iiwLH2qwkONe/fOrXEjpuzf+VO2EJzAR6w5zA80Rex87QBCg= X-Gm-Message-State: AOJu0YwY59aJpmp6BcXbF8F2/iHczfYEATMZwh6bFVoPGkM2iQrL8mI6 ZH2OtvIyPiJKcx9gE4AJZY6LOFW1N0zgL5Opt9//KYV7lFHeLhFW+J4feokMFE71DXHsFrLzAwF KaDp6nf+D9TY1MCJ8RqhqGOmJaC0L6WWGwBaM7366MIbIUg2D X-Received: by 2002:ac8:7c4b:0:b0:446:395a:37c9 with SMTP id d75a77b69052e-447cc1cd760mr50256721cf.4.1720189458359; Fri, 05 Jul 2024 07:24:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKP4/uPX8iCeoUcNLMV3z8vBAByHvLymsXhgYIxVOYKgo8tVByPTMSYbiLBJ2KPlAF3hMSkQ== X-Received: by 2002:ac8:7c4b:0:b0:446:395a:37c9 with SMTP id d75a77b69052e-447cc1cd760mr50256521cf.4.1720189457935; Fri, 05 Jul 2024 07:24:17 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4465149b579sm69523231cf.75.2024.07.05.07.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 07:24:17 -0700 (PDT) Date: Fri, 5 Jul 2024 10:24:14 -0400 From: Peter Xu To: Alistair Popple Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, Alex Williamson Subject: Re: [PATCH 11/13] huge_memory: Remove dead vmf_insert_pXd code Message-ID: References: <400a4584f6f628998a7093aee49d9f86c592754b.1719386613.git-series.apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: <400a4584f6f628998a7093aee49d9f86c592754b.1719386613.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: E2B6B1C0013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k61suf6jf9wdp39zcnro4sixz5373bro X-HE-Tag: 1720189460-98911 X-HE-Meta: U2FsdGVkX1+eBzUjg/00xY8ugCQ+LjVKuC2l38JNPoXVnMafeZhoz2iOGaHL3ds/jTohmw7MjHmC39JBJ6tc3JV1R+1xxReeu9JPWDkqi3jxmmhTw1JEsSn5gR5ziq81vUg5fZEDobBy0u+ppCnAaTR67hBjNVuTtQ8P6IaQmodUmwvrhmo8B07rIqY5rkpmmslHBDSgMKJHf0oDYDylqlRRBsuu5BOPUbs9dMulQu6gETdwmXSVEaMfZ77l1gPZbKxs1mpRG6pk1ieSpHzL/fPnynwOJed+c8AnYosz4LzYak1T4CgW8OnicKLxWFlcwaWGYID7GM1tY0OlwyeL7Aqj+59GAm1VbOGZ0RQV+2bB3V7IBvayYL0YNOy1qoXiKC+K/n/hcW64wCUvQN7OgsAAqGgRwFt/95WTxw5XqsOPO979od7U9Pqhm/0SlDUd7WFXozHUzbQjRkoKKx/yq3L8BEYL0qfVoIXTqe058iQ9kC2aoof7ltPba2Gr1f7Z4APKNW4Og9nzr5Wl9ptIDTw8uYZmUe5aAEfsEx7fot+i7HiiBIL7q0pxLLGjG+mrC81RCmB5lPgNTF6i0PcxPFs64fomG+7ZZGbXbB6Gypqhr/ziJ51UEBJNWOkSmxvDFJKA6l8MjE9KkQyIaW+k52baah9qTJU8DB8LEof9PygpcI48k7UiRu8djUOri5QBVbrKrI8/ykpl7fVK15TnpOplSR8IMcmXp8SlLXWFKGH/KZdGMShoUh2t0kuanch3KVh6fMuVTntjnLyeTKlYV4U4Emao4aKJ/6f+YIcaNLh8C951KnQMtmzw2B/S/dWxPVljg5TVswXmURUoLQdLlh3EH4MTXI3pb0d15ryP2fiCE+oWhVohI+NTrGBjrCVSoZLHnjkUlmKnGFeh7HmjKh1/dLpO+e1myF1tpKb8t+Mf/WNX6Wjio8HLgoR8RZvzczFmA2hdpCo3/2JDPaP ky+WlYOP /l4vzIQthA6beJfArlThXy/naTA0BUdvMVz0MSYRtn8J/CAkLweh8O668cxvhe9tQN65K4ksFE2g+hQs8UqVp/REOANakCku3PdDkdEcPwfLxunnHRFteVB3p0OISODsoOE22Z06uOcydwvY75srrZTmvFfJ2CYiGSy9PD8/IkwpOhIPfM6+Ucr+3wahlk0xYSdjFBkMFwCGVlBNDeCRAfdXV1pbCrHEN4w4dDdiNuXsVC3WNfk9XVzheylGbpMzDyQW0nc1Het78voB3N/6DbkxHKEuq+9NjCmpRszHWg21WQwAaxNxlrexXpNd4/nd5Xax+xrRByX0D+zzUCVetHpyQFqm/GR49rDc9lQJTMZI1Yg/5NT5stTbrWehkR/O4DjRKw7nmvHq2QJAfgnroJFuWjxu3DDQK/hn2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Alistair, On Thu, Jun 27, 2024 at 10:54:26AM +1000, Alistair Popple wrote: > Now that DAX is managing page reference counts the same as normal > pages there are no callers for vmf_insert_pXd functions so remove > them. > > Signed-off-by: Alistair Popple > --- > include/linux/huge_mm.h | 2 +- > mm/huge_memory.c | 165 +----------------------------------------- > 2 files changed, 167 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 9207d8e..0fb6bff 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -37,8 +37,6 @@ int change_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > pmd_t *pmd, unsigned long addr, pgprot_t newprot, > unsigned long cp_flags); > > -vm_fault_t vmf_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write); > -vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, bool write); > vm_fault_t dax_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write); > vm_fault_t dax_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, bool write); There's a plan to support huge pfnmaps in VFIO, which may still make good use of these functions. I think it's fine to remove them but it may mean we'll need to add them back when supporting pfnmaps with no memmap. Is it still possible to make the old API generic to both service the new dax refcount plan, but at the meantime working for pfn injections when there's no page struct? Thanks, -- Peter Xu