From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD6BC3271E for ; Fri, 5 Jul 2024 17:00:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F395D6B0099; Fri, 5 Jul 2024 13:00:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9506B009B; Fri, 5 Jul 2024 13:00:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE2F06B0099; Fri, 5 Jul 2024 13:00:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C0C1F6B0099 for ; Fri, 5 Jul 2024 13:00:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 07E63C027B for ; Fri, 5 Jul 2024 17:00:06 +0000 (UTC) X-FDA: 82306311654.01.0CB2554 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 4297DC000F for ; Fri, 5 Jul 2024 17:00:04 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720198778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QFtXfsRIZe1UCShCwf3Fz59KqEpWu+9JgZyL4CKxYZE=; b=PnqCjnuUN6r/SErI1oTXOexLmHFuF5zvCsxvd5fcINldnjQ9EmlqbzN0xOY2zKk0Znl15L v5I+hr9wqzl4rghPGwvSFeUyRGzqMlpDslV6sAmIos8JvgI7W3/JqEhedv4JwN9T2S9bAl cho7LrPKfzB5kTXK3jaDq/k3mgWT8dw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720198778; a=rsa-sha256; cv=none; b=mnvYVPGhm2HOUSTTA4uBbBKl6vAG1qGXrLSfacyYSPJBRBVhGqNT4FdHPAun/20hJ+pt5w yZEemmSPD1hWwktPZDpcyrhy5rRk3cpEBeDJjh1XAs+CUqVIE8HZqYsYOyQ5NT1ii4uCTs P8IN0VjWo5WfARMI5o6P/ndutp6A5As= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AEF3FDA7; Fri, 5 Jul 2024 10:00:26 -0700 (PDT) Received: from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9D913F762; Fri, 5 Jul 2024 09:59:57 -0700 (PDT) Date: Fri, 5 Jul 2024 17:59:55 +0100 From: Catalin Marinas To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 17/29] arm64: implement PKEYS support Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-18-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503130147.1154804-18-joey.gouly@arm.com> X-Stat-Signature: 1neeenci3qgnmrni5k46d1shy9649614 X-Rspamd-Queue-Id: 4297DC000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720198804-319152 X-HE-Meta: U2FsdGVkX18v8fy8wJFU7oHtrqktSwNu6EnfhgYHMI0Z+Ud9/13xn/LtM1rxzF0Q+KkGH2Q4QZRJ0xRyn2R6TQb2jbL8v1ftn5/FJAWvdHB1gP5IwxHnKDbJo1HLOO59e3wEnA2ehkWk87YFwfll7Ep9zCzH6yFqsYF9jRCJXsrww01a9fjnVuhou2IW5Ee3pkKL6g4Y6S6VtyCwOQmq5IZunK0wkiuSN9EDxIgvrAQlpj5DN44JmJcXFwGoajQkJBxQYfUN/i4uvrRfqm11E4S0tDzQ+8lQdIX7Zyn++S57hjUvEVjaZ/RTXlWxyKUsuROakkhOFy+1sd2488AZf43DanD23X3NJQoEi+BApJvu++lNyJlc3sZyI2sc+9/8eWCnDJ4VF8Qw/PAJU/Y81kDuhI2mfgYNTEKR4GO5s97buyGVMgj/lG2MJxYU15xJm1ytBRbYM6xyVlOh4DjleN4QNygA6q7B4hAm7UlvOv4HQv+S4Q1PkSvkagNOg2rzFsSUxv/fNrllWKoksLJyAds9de710o3HNrvUE0xDEujosjkOyW84oVVzrFhe5lMYI2UD5idjY3usHQ7naE+GiJg2D0FjTLGXQW9iqvSIl3QLLkaRgOfa1EbUbm1N22z5b2t+rEbvddsPfZi3i7qsNjva2RbrREARXqiuZsM+QBm845bHta4sN6XOt/AjEobyb5Qd3njKXTnSZz9DsLKsKQg4ONQH50jH4tqHspxMsHdyoHy5e+28aIP/aXsY/9QM8h2q9bsl+vtutJHP0KJIww3ci8EPVl5RtNboGvIb3VIbjBI6/HYMLxsXtEKJZREzciENsTIZxI4Nlv2nNo9BPxbIvSK+lFavWG3nxx/7fPErneyq5UXmF3T1b4upx9Mr4ucxLcA6AOY6wmp3QGJ+efBtEKwiiJVbOAYtbUpwkur7aWtJpVUzGCRrT73lFKVVMtNYR0v+G/cg7258BkQ BhIx47OP SrbVC1N1UGzHurka8cEFn7VyRouyB1wGG0fZHY3nbDmIZYuanphKTT/lmqzxMIfWhzQPpbP5b6t9aTUDPf+zGyY6EznnPiyp7toiG4LtHjOQKD1XT8Y1M3L4iEFhxqsm/WPm/m8zTDVZOEx1gLB9WqNsUCw42y3tTVAoqaRgHRD8H+dg5Neijyn7V0P+pYuUJgsaYHnvDYBaPGnU0Vpo0RwY06e/bL+HPyvSd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 02:01:35PM +0100, Joey Gouly wrote: > @@ -163,7 +182,8 @@ static inline pteval_t __phys_to_pte_val(phys_addr_t phys) > #define pte_access_permitted_no_overlay(pte, write) \ > (((pte_val(pte) & (PTE_VALID | PTE_USER)) == (PTE_VALID | PTE_USER)) && (!(write) || pte_write(pte))) > #define pte_access_permitted(pte, write) \ > - pte_access_permitted_no_overlay(pte, write) > + (pte_access_permitted_no_overlay(pte, write) && \ > + por_el0_allows_pkey(FIELD_GET(PTE_PO_IDX_MASK, pte_val(pte)), write, false)) I'm still not entirely convinced on checking the keys during fast GUP but that's what x86 and powerpc do already, so I guess we'll follow the same ABI. Reviewed-by: Catalin Marinas