From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937F2C3DA45 for ; Tue, 9 Jul 2024 01:27:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 343886B00A5; Mon, 8 Jul 2024 21:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F3A76B00A7; Mon, 8 Jul 2024 21:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ED486B00A5; Mon, 8 Jul 2024 21:27:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 00DF26B00A5 for ; Mon, 8 Jul 2024 21:27:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9554341606 for ; Tue, 9 Jul 2024 01:27:41 +0000 (UTC) X-FDA: 82318477122.30.B4DECE3 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf22.hostedemail.com (Postfix) with ESMTP id 1EE48C000C for ; Tue, 9 Jul 2024 01:27:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Ci9YKUz/"; spf=none (imf22.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=ak@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720488430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sBC45OeBevAAqo8c0ci60elnCiFOJXOkvLC3yW3gny4=; b=yBkEnp+v9u2dK0FH1OnJuRwDYzj3bzOtGUMk/m6CitYAwk1g5tJVw3mvV2xOqV8Qp8Z9gI WUKxqyq3rcK9QNyTL41VwPqxXt85NDb4Rky9+kNCkyuGfgnvUUuhC5es6iYxBa7FtYFxtH U25oYT6K9GodO9OK1y3PEli+jheYzTo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720488430; a=rsa-sha256; cv=none; b=AwYM0phYjEb182k+SW2VMhUo45omSF1gl+bZxWLwE+qSmF6/AIXP4ERTx8r2yuxFABSkIG V+sPRrT0Q8oweMqIqLuHrbQ0gTzD/ED65Qdid7vFuwCkbxQaaJAuhY96xp5rkR/IGbmkDe 9OEgTguqSpcZMXCsjUbOBDvC8oYibv4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Ci9YKUz/"; spf=none (imf22.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=ak@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720488459; x=1752024459; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sBC45OeBevAAqo8c0ci60elnCiFOJXOkvLC3yW3gny4=; b=Ci9YKUz/5wIuj1kikrUdxgTuX3XcbeQGZk/6SFMQVTItnmb9zYjwuyN8 8FDrBperGrDGz1M2vmSkSixjrlLB6cK+bbTIicRFOn0tlAXWbjCkmY4fI VRnqw5i6LWG6cIa4bPs8jnwh9tl6wtzTtuzKMIiJzYPJVFKKQ9oqzp4Ys tukRNajtH4tBkXri/S191yELL5TauEZo4orXwoReeJMzeroJPhzBMiE5v nFJAgXSHErJZRpeOoCDrThSEOY6D4PzLozfKxLeKNfjByfMH88ImJGFTo cH3Cz1D2WcjEBl7X2BqefcQB3CA5M9J9PAmOD+6MsLISwGijbn02zkWQf A==; X-CSE-ConnectionGUID: uVHUvqXhTOmQgVXfuQsONw== X-CSE-MsgGUID: OsGwfFDRRfeVk8nVlqr40g== X-IronPort-AV: E=McAfee;i="6700,10204,11127"; a="28322537" X-IronPort-AV: E=Sophos;i="6.09,193,1716274800"; d="scan'208";a="28322537" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2024 18:27:37 -0700 X-CSE-ConnectionGUID: 1X9aegR3R5+2EY1KaceQ8Q== X-CSE-MsgGUID: qI8oXd3vSriZkgwJTBl06A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,193,1716274800"; d="scan'208";a="48104989" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2024 18:27:37 -0700 Date: Mon, 8 Jul 2024 18:27:36 -0700 From: Andi Kleen To: Andrii Nakryiko Cc: Andrii Nakryiko , linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, liam.howlett@oracle.com, surenb@google.com, rppt@kernel.org, adobriyan@gmail.com Subject: Re: [PATCH v6 3/6] fs/procfs: add build ID fetching to PROCMAP_QUERY API Message-ID: References: <20240627170900.1672542-1-andrii@kernel.org> <20240627170900.1672542-4-andrii@kernel.org> <878qyqyorq.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1EE48C000C X-Stat-Signature: e3foa4tybmw67wbgdk3rxrhii61i5inj X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720488458-951495 X-HE-Meta: U2FsdGVkX1+w0THPHMLoR8jv4pyRxEuiJr3f6J+eGdIS34+hbItjHKSttMv5csi1xJbO/aWk17jYzQfUkb7bm2nBNbeKJVZE43IY9dZNz61CJVCZi59NSDch5fR0CP2Kq+SAwl6YPZb8VjOwCne3bqxEM9whaA/3Gscr8V7P1yN14BymcwMD1RNf9YkM8+FoN/mrI1AGmX+IWAct5Tm/BBTCYaXWtnq/rkVjPPku5jR3xQsZTSQsjZ0Y3m/zVYLsxYIaEh7yX47CR42hZjoiztQCDfWOVl3+eQC3s/irJo6JcGWKiez2iMHbDRm0pHnN6jT5s0sAD2zdYq1x23GIjOAnvRUjtNbX0nsUPpEQnfwClYSA8zcyjXM7AX7UE1XkFMhsHAkazvaGm1R9dm1EpVusbDP3kaL//lQCLls5DqsXQtIOrbqmOf92qZ6KpuNr9puAISKFNfMb4PIaynhGSDXgS8o9+AbjQ91JuFD4PfuNplrMKlk7I46EHQIVb74uOiaN0qIPPoNPkdHkCV/Ggx92SnftuJ+KBlzdLpB/hR2G9imxAufPjOa+hc/EIOar8vNriOZ4R+0eZrn/BCAK2FG4aGVZU+41VWlVXwfcsEFQW2yrXlyUj6e3wo8eT58zcSvre8nOFBI50XLP5ug3Y3816oZyQ6hBUCu8NcoVvKD5sYdR+X/XUJ/n0OnkXH4VOhSOZxJHX0V76a9mHAgiJRp56GLrweGktw6jt4xteZliIA1TaDDK4MTo1xm2FqFmMP60mzxWyxJWrbEVlp150tlXbrzzn/4mDbxSoWq195GfjACY11soMlUK6nWZs4LlT+MD49J+Y+Enx4k/UUQXW596OmQlc5TDnRCCRWhAkkfGLu0ZnLIiS7J/AfGIGFSawl1NCs7w17NrHIV1vF3iOGXBVoMxbZfNkVsSO891m82lqJ6P3JrSV0mOXYtcuNm5W3zGX3lGxM2jTYGAMun AZwd0HKj RQbgmwhW6VTTOypBrMZ5VpZVsncAUJYn4t4ADBJU70guAKMaxkwnc15tXL9F/ZUDU71IYqcVOm8Gy1XdMRqRMx3SKwwyBs1o5+RlgQtcHw8GULQC61eXnpgLsoCybpbbRV/3i1Dw/jIAIvNk49LbYeL38tfKJsaATJKzw2EScviEN2Blv2I/Aq6rYH4d9DOwUW2L2zuF0vgrMAium25XWdPQqdybU5VMjdc4St8iLYQkYhLkkac+tWCIoRZ7zMuOkQ3lyXCDKM9MrUZRtu2D+WEs08A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > So what exactly did you have in mind when you were proposing that > check? Did you mean to do a pass over all VMAs within the process to > check if there is at least one executable VMA belonging to > address_space? If yes, then that would certainly be way too expensive > to be usable. I was thinking to only report the build ID when the VMA queried is executable. If software wanted to look up a data symbol and needs that buildid it would need to check a x vma too. Normally tools iterate over all the mappings anyways so this shouldn't be a big burden for them. Did I miss something? I guess an alternative would be a new VMA flag, but iirc we're low on bits there already. -Andi