From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BBBC3DA5D for ; Mon, 22 Jul 2024 08:08:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCF146B0082; Mon, 22 Jul 2024 04:08:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B80AE6B0083; Mon, 22 Jul 2024 04:08:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4A3F6B0089; Mon, 22 Jul 2024 04:08:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 84BA26B0082 for ; Mon, 22 Jul 2024 04:08:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 714B8C1599 for ; Mon, 22 Jul 2024 08:08:26 +0000 (UTC) X-FDA: 82366661412.01.3BEE937 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 45FDC40008 for ; Mon, 22 Jul 2024 08:08:23 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p25P0kST; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721635654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ynvEQPK0dWmWEMIkrxaS77Vo8ZK+ZAGAsKS2gvIK7sc=; b=z9azPLfCj7uDVdhVtW/8HPVxVplEXF6HBBABJVTy72gF51YHNWmg2kyM67cPa5ODbhkHzl IFUCIJETfJZVK7SvuqdoJk+RJ77FWntz/bBJSiarIME/retrzw9fuUZKnYxX60sVmL0lOB xxFBVZ7DeLkd4RavQWTeGw/OO6p0zsg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721635654; a=rsa-sha256; cv=none; b=ivByZ+bNA9zQxjzWd1hw1GCPf7MXrW1baYkaYz8kDtYykuwPx4hz55Az5bU7kkoG01z04n AiedwOVECiQn3fYc/vg11RfraZpQvc5jSZof5+DsXTCThXXVsipw5+NR0QfAa7bcbs71Zn i7FKe+gS6dvoKR1P+xcpOAOl7sZ9zdU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p25P0kST; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3954FCE0AD0; Mon, 22 Jul 2024 08:08:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8487EC116B1; Mon, 22 Jul 2024 08:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721635700; bh=CyGkt9FKsE7t82Fz3Aja4aysBlda3M5p39yI7jGRxvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p25P0kSTbiVOylOIEqDsNzu3H4FIr1FoKh51p+DLef42bOBD/+IeI2/qDrEkJ+aUx JOvOmKwgblc3PxoHZyePkukIsG2JOzUb1CtejWkJjsYEL+wE+xp+6wxEcuMsKupROE CA9CX/rTisj9sF8GN70yjNgXp/rNyLGfErtqlsic85lbYH2IS8/mqV6aMVfUuSaXtH topFnxcko1xfwmMPrFsEb8ponJJrkpshooXAGBp2O9P6TVcS4OTwIgmnR6Fyim1ny8 TO3+8cCWwXRhFKfLIEbl29aoxeQlMpLqB4pFhJuhOGKty/suok7RCzqd0dTMUm3oEi 9ce0/fUKEVZnQ== Date: Mon, 22 Jul 2024 11:05:11 +0300 From: Mike Rapoport To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 15/17] mm: make numa_memblks more self-contained Message-ID: References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-16-rppt@kernel.org> <20240719190712.00001307@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719190712.00001307@Huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 45FDC40008 X-Stat-Signature: eeexbfnxbceem1nj1wg9x65ku4gxstgj X-Rspam-User: X-HE-Tag: 1721635703-926854 X-HE-Meta: U2FsdGVkX18xJ39gdUiCdNo/qPbUnYBdDJtBjmCz7diAfOZuZutm4oRSosqWSQU9oauzkb0xwKTnbzAPCL8m7Y22HUgYrwU8Icg3QLbzLLDsdfFsJPTf7R11HrH8UNc/X7vkLogu5DYw5Rb0Xysx2F7CuuM5I2JFGMu2lXu1657ZPYzqi1AqKsf0NU3Mjg83s0rxWM8J/YCOErx7LvDHq8WfU6H36ccttCsOTmvM7Sql6zxsOkTHMNEXp55+Rp/p2nf/ALCHhaC40vixG6JP8yWKPgmxNU/zK3xkdqJXiWhd8rfVzGNen+rTl5TQRE2K0uI5YCTOHzidVYPsrpz4uehfzyOljh3CwXb7X7PynV+6PNvaj8SdrkITB4fIqnpP/cbsONVvQEVwy689r6LoJaGwaTV7M7rkheFm0cmrVBVTbv7PNriAdRarzBu6YC0I2HFopflko8xjqJ+VeXZjBT3PbQqIiaxf7HPIOw3TkoNQ64AyGbo31wrLhJSoM3k33BQ570gqo1ppIzHAHr/DziHEyT0o/odOmQQqV119+1ZIhe2j67WtmWkUjTQm8NbuoSgtXhhGUIMWwuA+8MT1CRma3huEcg/Zw+UVSgBWSy3UVUx8QZZDtUd7pr975AyRmRyG3Vo5ouV+Pwxx7GV9kobCFwkD9YGI+5BO/BNZRlfLQAH9R3Ah7Zll+/nIJDkhV78cU5eu/vdNtv28Rn7KbpTkGgIbICkayOZrjmel4IyYTUCYFuki/qVUDHuz9LxtbB7CL8H5xtcWVbNlEt8U8q8h3QRQWeYDNX/RBCotVdcKdTtApFuX3SoT7aGLahN63+dJXDKUwXkXz1PBkDjwUMlZ6FGHjoKizwT8W+3Pb+nOCcBa0YPgql53d4Z++i8l4WIiNR//zWgXaD7klqw5x7Okl5z9VeVWr0FUVOhTXGSvMcoPk9N14X6fLeKyk5hUucwIwZJPIZiTBWJqeKA sK7cwpRa PQOjMk22LuFjz7Ax48KcIy9K4NFSsYYmofMxs2svZdTvUQwQJvAiPhAwJH7hJofQszblQa6T2NUbl8da79l4p1r1v5b/epeLbTeo9JhAbCwJy4J/0FMBMTgYfm4pGOlUpcuBPRp7iqhW6Eeznnpnz96bopaergA0+cTPDHy0igQv7BwQM7/HkvjbZADz8g279dEIplP8kjQ/NTHMBRqLFGk6oMuKq1ESjcyQImhY3CqrEAJvX2NPWe2fxQ3Amv2VEpdI5+5qiDTGCiDpNNNO/n8P8EE0tfbbQG5woGbe/XVuy0kFUxVGJlRUqwnzAQvzgAIzhV9nPGyJujaEyqbvJrEvD16o8qyNXUKYM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 07:07:12PM +0100, Jonathan Cameron wrote: > On Tue, 16 Jul 2024 14:13:44 +0300 > Mike Rapoport wrote: > > > From: "Mike Rapoport (Microsoft)" > > > > Introduce numa_memblks_init() and move some code around to avoid several > > global variables in numa_memblks. > > Hi Mike, > > Adding the effectively always on memblock_force_top_down > deserves a comment on why. I assume because you are going to do > something with it later? > > There also seems to be more going on in here such as the change to > get_pfn_range_for_nid() Perhaps break this up so each > change can have an explanation. I'll split this into several commits. -- Sincerely yours, Mike.